From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B487A2EEB for ; Fri, 13 Sep 2019 17:09:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F38E71F038; Fri, 13 Sep 2019 17:09:28 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B5D121F037 for ; Fri, 13 Sep 2019 17:09:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 08:09:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="386415440" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga006.fm.intel.com with ESMTP; 13 Sep 2019 08:09:25 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.123]) by ORSMSX106.amr.corp.intel.com ([169.254.1.16]) with mapi id 14.03.0439.000; Fri, 13 Sep 2019 08:09:25 -0700 From: "Wang, Yipeng1" To: Aaron Conole , "agupta3@marvell.com" CC: "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Honnappa Nagarahalli" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite Thread-Index: AQHVakFUG/l77kYWakuOfpaqQNDRzqcptOuA Date: Fri, 13 Sep 2019 15:09:24 +0000 Message-ID: References: <1567748973-24192-3-git-send-email-agupta3@marvell.com> <1568362357-18061-1-git-send-email-agupta3@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg2Zjg3MWQtOTY5OC00NDk5LTk4YjYtMmQ5OTBhZGY2ODE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaDllRmQzdm9WRjZsUjdNaEVKdVVvRThrakxCMEMybG1Zbm9tb3FhSkxVRWdWZEh5Zng4ZkJoeWV3ODNxQzFXeCJ9 x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, September 13, 2019 7:41 AM > To: agupta3@marvell.com > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to > dpdk perf testsuite >=20 > writes: >=20 > > From: Amit Gupta > > > > hash_readwrite_lf test always getting TIMEOUT as required time to > > finish this test was much longer compare to time required for fast > > tests(10s). Hence, the test is being renamed moved to perf test > > category for its execution to complete. > > > > Signed-off-by: Amit Gupta > > --- >=20 > Okay. I'll note that we pass the '-t 3' flag, so it is actually timing o= ut with 30s > instead of the default 10. We do this because occasionally the lpm6 and = table > tests would also exceed the 10s timeout in the travis environment. I agr= ee, > it's better to pull the perf part of tests out. >=20 > I think there isn't any additional functional test in this readwrite - is= that so? > If it is, then we need to also prioritize adding back in some of the func= tional > testing. Maybe I misread the lf_autotest, though. >=20 [Wang, Yipeng]=20 Yes that is my concern too, if we just move all the lock-free test into per= f test then we miss the functional test. Would any of you like to consider adding a small functional test into the r= eadwrite or readwrite_lf_functional? That would be great :)