From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC94E45648; Thu, 18 Jul 2024 23:34:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2A1340662; Thu, 18 Jul 2024 23:34:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 92BAA40616 for ; Thu, 18 Jul 2024 23:34:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721338461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CttKCyqT3gHD7OnKqhQduhdsQftGpTlx+dljn5xLUgo=; b=U5ItneGcYBRVxJL4toOOSogVsoUJSAgSJemcItxOAW4FUDsdDjuuZBr8UwhEserxuhJhFt Us60ez3WPB2qivTUOmLuVN9eHdGqpcoCpmdn6M9HjeUMqhNR/buaIcn4LkaLTbzYX+7byw 6hUNwVHT8DRSbnfuVt7gz3nmH5yVv+E= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-QC-NJGZbMzKJsATok8KYfg-1; Thu, 18 Jul 2024 17:34:19 -0400 X-MC-Unique: QC-NJGZbMzKJsATok8KYfg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee847979c4so16641561fa.3 for ; Thu, 18 Jul 2024 14:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721338458; x=1721943258; h=in-reply-to:references:user-agent:cc:subject:to:from:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CttKCyqT3gHD7OnKqhQduhdsQftGpTlx+dljn5xLUgo=; b=niQt+9n3kndfYODfs0qe354tuCT0gSympohI9WgK4zO/+SYOMoLweLywV8LWv9B9kk vE9PZmI6ZdhmgnXbMcbAdiR4xGvK98YDH0j24lZm6hJFCbDl6vJFKo7dDjrPj9PqFL9V MHxDoFLl3zViJS7hP44IBsPlF2nPCr+wTDB74FsWGuT3Fs2ybqL1Ye8aYai+ENSMYL+I h6wY0dth/dTqK9fs8vtmQiH1WAP3F9O2Mk/DUISLAQtz4/cp/4yOLzJsJYnVXBCUHKEP NiElQtWA/3YmtIjDdWLIZiUbEehApYPc5JxYltK1J7vcsdADMO3ekg5ZtTpCMHMk/sS6 lQIw== X-Gm-Message-State: AOJu0YxB//5V/6tRM5wuhwzbNcoVuxFP+oP6fE7pv8Y1FY5LECozTqFf gTET71f05bJcU/xHLCoIn+3YlV55pM7p5oL7bhPlqzeVD+3OLbVlbJtTwhZFCoj30xOyP5WIJzS XZrrk+NmMC8+wi/6s6SIlbsyoAFqA/LsKYfnAqhMR X-Received: by 2002:a05:6512:4020:b0:52c:db75:9640 with SMTP id 2adb3069b0e04-52ee54111d0mr4747594e87.48.1721338458134; Thu, 18 Jul 2024 14:34:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuhVlRzQ/RZGcZPC/mnQfa7XrYMPxQRXQAQD6fpzZe66Pn0dv5Es9bvQELdVzVCEHb2/dMQA== X-Received: by 2002:a05:6512:4020:b0:52c:db75:9640 with SMTP id 2adb3069b0e04-52ee54111d0mr4747463e87.48.1721338455729; Thu, 18 Jul 2024 14:34:15 -0700 (PDT) Received: from localhost (2a01cb0003516600d9d313ed6b23ad48.ipv6.abo.wanadoo.fr. [2a01:cb00:351:6600:d9d3:13ed:6b23:ad48]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d6936e1esm2028285e9.44.2024.07.18.14.34.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jul 2024 14:34:15 -0700 (PDT) Mime-Version: 1.0 Date: Thu, 18 Jul 2024 23:34:14 +0200 Message-Id: From: "Robin Jarry" To: "Vladimir Medvedkin" , =?utf-8?q?Morten_Br=C3=B8rup?= Subject: Re: IPv6 APIs rework Cc: , "Sunil Kumar Kori" , "Rakesh Kudurumalla" , "Vladimir Medvedkin" , "Wisam Jaddo" , "Cristian Dumitrescu" , "Konstantin Ananyev" , "Akhil Goyal" , "Fan Zhang" , "Bruce Richardson" , "Yipeng Wang" , "Sameh Gobriel" , "Nithin Dabilpuram" , "Kiran Kumar K" , "Satha Rao" , "Harman Kalra" , "Ankur Dwivedi" , "Anoob Joseph" , "Tejasree Kondoj" , "Gagandeep Singh" , "Hemant Agrawal" , "Ajit Khaparde" , "Somnath Kotur" , "Chas Williams" , "Min Hu (Connor)" , "Potnuri Bharat Teja" , "Sachin Saxena" , "Ziyang Xuan" , "Xiaoyun Wang" , "Jie Hai" , "Yisen Zhuang" , "Jingjing Wu" , "Dariusz Sosnowski" , "Viacheslav Ovsiienko" , "Bing Zhao" , "Ori Kam" , "Suanming Mou" , "Matan Azrad" , "Chaoyong He" , "Devendra Singh Rawat" , "Alok Prasad" , "Andrew Rybchenko" , "Stephen Hemminger" , "Jiawen Wu" , "Jian Wang" , "Thomas Monjalon" , "Ferruh Yigit" , "Jiayu Hu" , "Pavan Nikhilesh" , "Maxime Coquelin" , "Chenbo Xia" User-Agent: aerc/0.18.0-5-gd32d93015ed7 References: <98CBD80474FA8B44BF855DF32C47DC35E9F5AB@smartserver.smartshare.dk> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Vladimir Medvedkin, Jul 18, 2024 at 23:25: > I think alignment should be 1 since in FIB6 users usually don't copy IPv6 > address and just provide a pointer to the memory inside the packet. Curre= nt > vector implementation loads IPv6 addresses using unaligned access ( > _mm512_loadu_si512) so it doesn't rely on alignment. Yes, my intention was exactly that, being able to map that structure=20 directly in packets without copying them on the stack. > > 2. In the IPv6 packet header, the IPv6 addresses are not 16 byte aligne= d, > > they are 8 byte aligned. So we cannot make the IPv6 address type 16 byt= e > > aligned. > Not necessary, if Ethernet frame in mbuf starts on 8b aligned address, th= en > IPv6 is aligned only by 2 bytes. We probably could safely say that aligning on 2 bytes would be OK. But=20 is there any benefit, performance wise, in doing so? Keeping the same=20 alignment as before the change would at least make it ABI compatible.