From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 693C945665; Sat, 20 Jul 2024 19:43:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56F084027E; Sat, 20 Jul 2024 19:43:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1054640269 for ; Sat, 20 Jul 2024 19:43:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721497430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0cGU/EoE/Ythsn83BfbE29m8TRhVtqYUSQjuHhGCEDM=; b=E66walVWWNYHff7CtxmVKZVf/8h1tBBlZCGZGDBYSik2CxtlxC9lYHvc5gnPR1xcWk2pdL oFQPVUHjL+KOb7GyVcjdHCAyirkT6re2UVlokMOmlV7tDE72vO3cv7Z/wcGPSMLTilWh97 TX1Steww8BMDX6D4rKDaSUcR+WfbEK0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-JSsrjyNnNPSZTiIZ9e5q0g-1; Sat, 20 Jul 2024 13:43:48 -0400 X-MC-Unique: JSsrjyNnNPSZTiIZ9e5q0g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42667cc80e8so21140075e9.2 for ; Sat, 20 Jul 2024 10:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721497427; x=1722102227; h=in-reply-to:references:user-agent:from:cc:subject:to:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0cGU/EoE/Ythsn83BfbE29m8TRhVtqYUSQjuHhGCEDM=; b=LDhZZ0mOIzGW55Ir97IqFEFBf3tRPXopCrVNmWTdL23TTOR04CqgojJBECOZHDQbtZ F4xjPqzW5jEctKzQ1nu5GYREdeziIB+oGj2N59u7yR2B1gropPzmIh4m3LjLlv19LmDm aXZfwNDNx1V09iHkD/xf9uZpHrPXP90jY5qg+5MvZR95WiAdSnl3EbNnEJhPp+FwT7D0 rF4+m+hP+yhWzBPhYfU9tfrhux2gr0CVJ5PwBrRyl5zjfCWx14ZKV+HlQCMrWm4pjIgI bxIukpBmjYMFXFBMToJNIlhkNntgJ/cwivAMX6X0xMzxcTzzSTX/+WUuXUrI5aXdnZVg iy2g== X-Forwarded-Encrypted: i=1; AJvYcCVZkgCf0QzjPioqXaQqXa2r2b3fxd7coXue6mijUpAEkaPCYA3KLy8lmttSxSY4syzmZXxqgATG6HeS644= X-Gm-Message-State: AOJu0YxJNmIFgJWMDGptepETygLUy8fFt03SkE4+8DxGFOF7o+27JS7u gCAxbCZqky1Ksa59Xizl1Bz2uXfSY8qcgSoc3sWErcXX78Av8CAM///SIIdvn+ayNOaPofmClg0 X4XFXJxY1DvRYBHY54wk35GJXw0yC1yMYC56JFUtm X-Received: by 2002:a5d:524d:0:b0:367:8e53:7fd7 with SMTP id ffacd0b85a97d-369bae652ccmr1463927f8f.28.1721497427289; Sat, 20 Jul 2024 10:43:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGl6jrSySVafrYClRQPmSSHEWefhlDUhJrLLA3NIogZEw5n+JSxTqfTJB27qqT/POilyFzH0w== X-Received: by 2002:a5d:524d:0:b0:367:8e53:7fd7 with SMTP id ffacd0b85a97d-369bae652ccmr1463886f8f.28.1721497426866; Sat, 20 Jul 2024 10:43:46 -0700 (PDT) Received: from localhost (2a01cb0003516600d9d313ed6b23ad48.ipv6.abo.wanadoo.fr. [2a01:cb00:351:6600:d9d3:13ed:6b23:ad48]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787ceda0sm4315312f8f.87.2024.07.20.10.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jul 2024 10:43:46 -0700 (PDT) Mime-Version: 1.0 Date: Sat, 20 Jul 2024 19:43:45 +0200 Message-Id: To: "Stephen Hemminger" , =?utf-8?q?Morten_Br=C3=B8rup?= Subject: Re: IPv6 APIs rework Cc: "Vladimir Medvedkin" , , "Konstantin Ananyev" , , "Sunil Kumar Kori" , "Rakesh Kudurumalla" , "Wisam Jaddo" , "Cristian Dumitrescu" , "Konstantin Ananyev" , "Akhil Goyal" , "Fan Zhang" , "Yipeng Wang" , "Sameh Gobriel" , "Nithin Dabilpuram" , "Kiran Kumar K" , "Satha Rao" , "Harman Kalra" , "Ankur Dwivedi" , "Anoob Joseph" , "Tejasree Kondoj" , "Gagandeep Singh" , "Hemant Agrawal" , "Ajit Khaparde" , "Somnath Kotur" , "Chas Williams" , "Min Hu (Connor)" , "Potnuri Bharat Teja" , "Sachin Saxena" , "Xiaoyun Wang" , "Jie Hai" , "Yisen Zhuang" , "Jingjing Wu" , "Dariusz Sosnowski" , "Viacheslav Ovsiienko" , "Bing Zhao" , "Ori Kam" , "Suanming Mou" , "Matan Azrad" , "Chaoyong He" , "Devendra Singh Rawat" , "Alok Prasad" , "Andrew Rybchenko" , "Jiawen Wu" , "Jian Wang" , "Thomas Monjalon" , "Ferruh Yigit" , "Jiayu Hu" , "Pavan Nikhilesh" , "Maxime Coquelin" , "Chenbo Xia" From: "Robin Jarry" User-Agent: aerc/0.18.0-5-gd32d93015ed7 References: <98CBD80474FA8B44BF855DF32C47DC35E9F5AB@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AC@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AE@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AF@smartserver.smartshare.dk> <20240719100701.7e7dfc7f@hermes.local> In-Reply-To: <20240719100701.7e7dfc7f@hermes.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Cutting down the quoting a bit. I understand the arguments against having an unaligned packed struct.=20 But it is precisely what we have in the current code base. All IPv6=20 addresses are uint8_t[16] arrays. And nobody ever complained about it. Since this rework is already massive, could we proceed in steps? First, I can replace all uint8_t[16] arrays by an unaligned packed=20 struct which is 99% of the work. Second, *if there is a real and measurable performance gain*, change=20 that structure to remove explicit alignment. Does this sound like a good plan to everyone?