From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 909A545667; Sat, 20 Jul 2024 22:33:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EBD34027C; Sat, 20 Jul 2024 22:33:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 68D7440269 for ; Sat, 20 Jul 2024 22:33:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721507609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V8a/2LyTelsLC44QoZ8FoUCvl85PCYZIR65E/c3EhUw=; b=BPiUR8+PQgPJoaNa+mdDCC7XS32arlkE7/sbMK1N/rwL4/ASqENchfr+ma8pfuGRlhxavR WRhEcPW2mAW2ooYkkdKt4p2WeGpzMK1qvxYAJu0wzCw9PP9/dk/imcb5srdZd2VzCRyhzK tN76QbsjRT5UwUQ2jbWcDBd/fOkGM8Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-vi61c1p9PiiSRXTtPG0V6Q-1; Sat, 20 Jul 2024 16:33:28 -0400 X-MC-Unique: vi61c1p9PiiSRXTtPG0V6Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-427d9e61ba8so9760665e9.3 for ; Sat, 20 Jul 2024 13:33:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721507607; x=1722112407; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V8a/2LyTelsLC44QoZ8FoUCvl85PCYZIR65E/c3EhUw=; b=RIddbBQ37vmnuSubdcW2enjDEkxX4diTHEGjvn1Shbno0JNudzIHtBg9IvM6Xi3Csa adSgzDqEIffZVoYsocfXmRt5uZ4+Ke2iVUrya5b+jZ5AYnI0T7mvT7jyvHzHmIRGnZhg sJxuUuhvdp+snn0Zh0hBVMKjFj+UHSbxUXeoi5kdxnfAu3++3WEDkfU2iG17qSAOLJWV SGQZFI/6mnUJau3+TJQHKtM5iRnRr2VswPctAiSSiF9qn6SosTTBfu6aQ5GvNIeCpS03 uXnJPBGntE+NHWX/YgJ4SUFj6MydhylQ4Sbqx44saNDQ64l4AL9lYuOjjmCLp8PQcCV/ K10Q== X-Forwarded-Encrypted: i=1; AJvYcCUao4zTkulWhLZMPgVbg3P6zbOj5UfEjfViIi7TamGF0VWFQrF9MK/ggWZMHZTDY8LxP+y6K1s2VUIjjfI= X-Gm-Message-State: AOJu0YxgPPJCI2v9P6Chq5u6rCR38T9fc5mTpgSShMuG0gfFmRVZDcsO cDyUzbQfOqauvMkEBbKu3tjPX7NhPtGScx//lAn2lzM3X18v+L1hAW2Q+pDWcVh3MrRropaZ8G7 URzWG+kuTzE3eXAVe4aa+9vcK1GrS0WvXLPu4sGN7 X-Received: by 2002:a05:600c:1d91:b0:426:64a2:5375 with SMTP id 5b1f17b1804b1-427dc520cc9mr14650735e9.1.1721507607046; Sat, 20 Jul 2024 13:33:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEToUE6X44HjXy0/KdE5GqvQJ7m1nRWkhqEm5AGRquL0RVt36TH6t8yb5gMDz5pkHQgazvyWQ== X-Received: by 2002:a05:600c:1d91:b0:426:64a2:5375 with SMTP id 5b1f17b1804b1-427dc520cc9mr14650385e9.1.1721507606575; Sat, 20 Jul 2024 13:33:26 -0700 (PDT) Received: from localhost (2a01cb0003516600d9d313ed6b23ad48.ipv6.abo.wanadoo.fr. [2a01:cb00:351:6600:d9d3:13ed:6b23:ad48]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d6697c3fsm67816665e9.0.2024.07.20.13.33.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jul 2024 13:33:26 -0700 (PDT) Mime-Version: 1.0 Date: Sat, 20 Jul 2024 22:33:25 +0200 Message-Id: Subject: Re: IPv6 APIs rework Cc: =?utf-8?q?Morten_Br=C3=B8rup?= , "Vladimir Medvedkin" , , "Konstantin Ananyev" , , "Sunil Kumar Kori" , "Rakesh Kudurumalla" , "Wisam Jaddo" , "Cristian Dumitrescu" , "Konstantin Ananyev" , "Akhil Goyal" , "Fan Zhang" , "Yipeng Wang" , "Sameh Gobriel" , "Nithin Dabilpuram" , "Kiran Kumar K" , "Satha Rao" , "Harman Kalra" , "Ankur Dwivedi" , "Anoob Joseph" , "Tejasree Kondoj" , "Gagandeep Singh" , "Hemant Agrawal" , "Ajit Khaparde" , "Somnath Kotur" , "Chas Williams" , "Min Hu (Connor)" , "Potnuri Bharat Teja" , "Sachin Saxena" , "Xiaoyun Wang" , "Jie Hai" , "Yisen Zhuang" , "Jingjing Wu" , "Dariusz Sosnowski" , "Viacheslav Ovsiienko" , "Bing Zhao" , "Ori Kam" , "Suanming Mou" , "Matan Azrad" , "Chaoyong He" , "Devendra Singh Rawat" , "Alok Prasad" , "Andrew Rybchenko" , "Jiawen Wu" , "Jian Wang" , "Thomas Monjalon" , "Ferruh Yigit" , "Jiayu Hu" , "Pavan Nikhilesh" , "Maxime Coquelin" , "Chenbo Xia" From: "Robin Jarry" To: "Stephen Hemminger" User-Agent: aerc/0.18.0-5-gd32d93015ed7 References: <98CBD80474FA8B44BF855DF32C47DC35E9F5AB@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AC@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AE@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AF@smartserver.smartshare.dk> <20240719100701.7e7dfc7f@hermes.local> <20240720132619.4ed7a53a@hermes.local> In-Reply-To: <20240720132619.4ed7a53a@hermes.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Stephen Hemminger, Jul 20, 2024 at 22:26: > There is no need for packing or alignment in in6_addr or current DPDK,=20 > what would be the benefit? Compilers generate worse code if=20 > a structure is marked packed. The only benefit is to maintain current behaviour. At first, I had not packed nor aligned anything and I had tons of test=20 errors because the compiler added padding in structures that contained=20 IPv6 addresses. I don't want to mix things together. In my opinion, removing that=20 alignof(1) constraint is an optimization which has nothing to do with=20 the IPv6 API functional rework. So my proposal is: add a structure *packed and unaligned* first so that=20 *all tests are passing*. And *then*, after the changes have been applied on the main branch and=20 no critical issues have been reported, see if we need to remove these=20 packed and unaligned constraints.