Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver

[Harish Patil <harish.patil@qlogic.com>]

>
>On Tue, 29 Mar 2016 22:28:20 -0700
>Rasesh Mody <rasesh.mody@qlogic.com> wrote:
>
>> +
>> +static void qede_print_adapter_info(struct qede_dev *qdev)
>> +{
>> +	struct ecore_dev *edev = &qdev->edev;
>> +	struct qed_dev_info *info = &qdev->dev_info.common;
>> +	char ver_str[QED_DRV_VER_STR_SIZE] = { 0 };
>> +
>> +	RTE_LOG(INFO, PMD,
>> +		  " Chip details : %s%d\n",
>> +		  ECORE_IS_BB(edev) ? "BB" : "AH",
>> +		  CHIP_REV_IS_A0(edev) ? 0 : 1);
>> +
>> +	sprintf(ver_str, "%s %s_%d.%d.%d.%d", QEDE_PMD_VER_PREFIX,
>> +		edev->ver_str, QEDE_PMD_VERSION_MAJOR, QEDE_PMD_VERSION_MINOR,
>> +		QEDE_PMD_VERSION_REVISION, QEDE_PMD_VERSION_PATCH);
>> +	strcpy(qdev->drv_ver, ver_str);
>> +	RTE_LOG(INFO, PMD, " Driver version : %s\n", ver_str);
>> +
>> +	ver_str[0] = '\0';
>> +	sprintf(ver_str, "%d.%d.%d.%d", info->fw_major, info->fw_minor,
>> +		info->fw_rev, info->fw_eng);
>> +	RTE_LOG(INFO, PMD, " Firmware version : %s\n", ver_str);
>> +
>> +	ver_str[0] = '\0';
>> +	sprintf(ver_str, "%d.%d.%d.%d",
>> +		(info->mfw_rev >> 24) & 0xff,
>> +		(info->mfw_rev >> 16) & 0xff,
>> +		(info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff);
>> +	RTE_LOG(INFO, PMD, " Management firmware version : %s\n", ver_str);
>> +
>> +	RTE_LOG(INFO, PMD, " Firmware file : %s\n", QEDE_FW_FILE_NAME);
>
>This means the driver is far too chatty in the logs.
>Can't this be made DEBUG level?
>
Not clear what is the issue here?
RTE_LOG is used here to display basic adapter info like firmware/driver
versions etc without the need to enable any debug flags.
The driver debug logging is under the control of appropriate debug flags.