From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from prod-mail-xrelay07.akamai.com (prod-mail-xrelay07.akamai.com [23.79.238.175]) by dpdk.org (Postfix) with ESMTP id 6DC5D5680 for ; Sat, 23 Jul 2016 00:06:44 +0200 (CEST) Received: from prod-mail-xrelay07.akamai.com (localhost.localdomain [127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id D1EBA433465; Fri, 22 Jul 2016 22:06:43 +0000 (GMT) Received: from prod-mail-relay11.akamai.com (prod-mail-relay11.akamai.com [172.27.118.250]) by prod-mail-xrelay07.akamai.com (Postfix) with ESMTP id BC0E8433464; Fri, 22 Jul 2016 22:06:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; s=a1; t=1469225203; bh=OVjAhj5Pnmch/HPtQ5LJsElCBIq9C4xLsXrY+dage6c=; l=1061; h=From:To:Date:References:In-Reply-To:From; b=GsUn2suMHr0zAz0eUtHx1OwX9FoSOsxn1N+jOW50g4p2AdRuAzJt6+FsBffsuHcl2 2FcXYc0TNdIk2IdDePxHO/Oy6hOcRmh8F//0Bn+wGeZW3h9Plfw08CSZTNnOj6TTCW UDUmK8QFzSX5vxk9sWDWHA17zHVHP4OvTjRy6KOs= Received: from email.msg.corp.akamai.com (ustx2ex-cas4.msg.corp.akamai.com [172.27.25.33]) by prod-mail-relay11.akamai.com (Postfix) with ESMTP id A31EF1FC92; Fri, 22 Jul 2016 22:06:43 +0000 (GMT) Received: from ustx2ex-dag1mb6.msg.corp.akamai.com (172.27.27.107) by ustx2ex-dag1mb2.msg.corp.akamai.com (172.27.27.102) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 22 Jul 2016 17:06:42 -0500 Received: from ustx2ex-dag1mb6.msg.corp.akamai.com ([172.27.27.107]) by ustx2ex-dag1mb6.msg.corp.akamai.com ([172.27.27.107]) with mapi id 15.00.1178.000; Fri, 22 Jul 2016 15:06:42 -0700 From: "Sanford, Robert" To: Hiroyuki Mikita , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [PATCH] timer: remove unnecessary timer add call Thread-Index: AQHR4FGx1t5CKFZmSUipoNcCXzgj5KAlPE2A Date: Fri, 22 Jul 2016 22:06:42 +0000 Message-ID: References: <1468776950-32693-1-git-send-email-h.mikita89@gmail.com> In-Reply-To: <1468776950-32693-1-git-send-email-h.mikita89@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.3.140616 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.19.133.74] Content-Type: text/plain; charset="us-ascii" Content-ID: <19460E7A1E255E4CB812ACFBA61EEA68@akamai.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 22:06:44 -0000 On 7/17/16 1:35 PM, "Hiroyuki Mikita" wrote: >When timer_set_running_state() fails in rte_timer_manage(), >the failed timer is put back on pending-list. >In this case, another core tries to reset or stop the timer. >It does not need to be on pending-list > >Signed-off-by: Hiroyuki Mikita >--- > lib/librte_timer/rte_timer.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c >index 3dcdab5..94878d3 100644 >--- a/lib/librte_timer/rte_timer.c >+++ b/lib/librte_timer/rte_timer.c >@@ -562,10 +562,9 @@ void rte_timer_manage(void) > pprev =3D &tim->sl_next[0]; > } else { > /* another core is trying to re-config this one, >- * remove it from local expired list and put it >- * back on the priv_timer[] skip list */ >+ * remove it from local expired list >+ */ > *pprev =3D next_tim; >- timer_add(tim, lcore_id, 1); > } > } >=20 >--=20 >2.7.4 > Acked-by: Robert Sanford