From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 660A61F5
 for <dev@dpdk.org>; Wed, 26 Jul 2017 16:35:19 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP; 26 Jul 2017 07:35:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,415,1496127600"; d="scan'208";a="112202954"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga004.jf.intel.com with ESMTP; 26 Jul 2017 07:35:19 -0700
Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 26 Jul 2017 07:35:18 -0700
Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.214]) by
 fmsmsx118.amr.corp.intel.com ([10.18.116.18]) with mapi id 14.03.0319.002;
 Wed, 26 Jul 2017 07:35:18 -0700
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: DPDK <dev@dpdk.org>, "Dumitrescu, Cristian"
 <cristian.dumitrescu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: hierarchy_commit() message displayed when not using TM
Thread-Index: AQHTBhxnM/vUlGOiSk6DUrtCwkx2DA==
Date: Wed, 26 Jul 2017 14:35:18 +0000
Message-ID: <D3D856D3-CCC7-4B47-8BEB-401C093CCEA3@intel.com>
References: <20170725222107.23203-1-thomas@monjalon.net>
 <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> <5680989.RRpAUyPcSC@xps>
In-Reply-To: <5680989.RRpAUyPcSC@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.254.49.103]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <08B5086BCC3AF44C8B0B1CB42020E663@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: [dpdk-dev] hierarchy_commit() message displayed when not using TM
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 14:35:20 -0000


> On Jul 26, 2017, at 12:39 AM, Thomas Monjalon <thomas@monjalon.net> wrote=
:
>=20
>> I noticed a new message:
>> i40e_dev_start(): please call hierarchy_commit() before starting the por=
t
>> i40e_dev_start(): please call hierarchy_commit() before starting the por=
t
>> i40e_dev_start(): please call hierarchy_commit() before starting the por=
t
>> i40e_dev_start(): please call hierarchy_commit() before starting the por=
t
>>=20
>> and I tried to add the call in pktgen, but it had no effect. To me the T=
M API should be defaulted to the original mode and just work unless someone=
 needs to use the TM APIs. The hierarchy_commit routine could not need to b=
e called in the normal case is my guess.
>=20
> PS: I've noticed that you are the author of all the pktgen commits.
> Are you using git-am when applying patches from other contributors?

Cristian and Wenzhuo responded in another email and the messages above will=
 be fixed.

Regards,
Keith