From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D54045823; Tue, 20 Aug 2024 17:59:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E26F9406B7; Tue, 20 Aug 2024 17:59:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4C3B14025F for ; Tue, 20 Aug 2024 17:59:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724169587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z78bks2jQ4C0K8olQGe5NVwJ8aYSCWJ889C7/3T1lME=; b=Y+yW4RMGqfN9kVuBsfZT9oZr1cMmZORw9dOg+uks7bkDP76T6Kn6AK5H7Ky5e6SpLh4anU UvBrzgkDc6Inb03LzIMT+1lh2KZ3IVvszzzhB9W6eShu1IpaGBSvwm3BJoWydnItuJESfE cnExKqfmZPfk7wkQKCc5BSnSExzoYrs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-m3Kmm6jhOYyBjtRTk694qw-1; Tue, 20 Aug 2024 11:59:46 -0400 X-MC-Unique: m3Kmm6jhOYyBjtRTk694qw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428ea5b1479so45101285e9.0 for ; Tue, 20 Aug 2024 08:59:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724169585; x=1724774385; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z78bks2jQ4C0K8olQGe5NVwJ8aYSCWJ889C7/3T1lME=; b=Qez7a+pZHB/dzVICorbd8n65VHuwAfvsS4TiW5gES8xGJZCiBU4yrO+UzyESnVGxYz ZeCnQ9sapVVvqAhItiTM0YYu1HVUAhgx+njSfe4I7up1Y3ifaw4LNCVARdY56wew7elQ 0mJR5jxHFlXfRAGvCi4cOjMORMsJC1UBOygeVDw1B3c0+t1rix0G1cohBMKwQSHPtvku V0INm6vNuP+amMzL+1V1yB4FQ5pUDqzy/73/6U+2alO7Tw8aMYfLXXg/H5RopWGJ5Tcp HZX+V9my4mWAxReOpA2ZSXtnhLQJ4aDkxyRU77Z1v+hXUoTs+WeZbfw9tgBXXUzgw1FP vToQ== X-Forwarded-Encrypted: i=1; AJvYcCUj3CmLPKzE2ZZUfmVkQTGIH40eB9g8B3Cv6BGemQU3MboMfOEpMn6sb+or8i3eyeM17Tc=@dpdk.org X-Gm-Message-State: AOJu0Yw8mcBGB2JsZlUehHI3c5eqdwzAD8wo4ecDAfax+M8HRKyrtMFv u/bnpaA+62PxrfwCfFNHf99s4nFRmSGS6keGpCVQgkFPRlWvlg5x8ywh46L1WolBoZySwDElHSP CxgZJF4d+37XDtyPiA2j4Lp8J0apCdXa2TSIYjcfp X-Received: by 2002:a7b:c4d3:0:b0:428:e820:37ae with SMTP id 5b1f17b1804b1-429ed785f4dmr99268165e9.1.1724169585559; Tue, 20 Aug 2024 08:59:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiPV/8qDsE6f1GcBxFXdfzlKvKvjyjPugvrUboW8OpEGY6SJ9sTk/8Q5LdoG32XVqdJ7VYwA== X-Received: by 2002:a7b:c4d3:0:b0:428:e820:37ae with SMTP id 5b1f17b1804b1-429ed785f4dmr99268045e9.1.1724169585052; Tue, 20 Aug 2024 08:59:45 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed6586f7sm146223175e9.23.2024.08.20.08.59.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 08:59:44 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 20 Aug 2024 17:59:44 +0200 Message-Id: Subject: Re: [PATCH v3 1/4] usertools/cpu_layout: update coding style Cc: From: "Robin Jarry" To: "Anatoly Burakov" , User-Agent: aerc/0.18.2-53-g11f57b5f3378-dirty References: In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Anatoly Burakov, Aug 20, 2024 at 17:35: > Update coding style: > > - make it PEP-484 compliant > - address all flake8, mypy etc. warnings > - use f-strings in place of old-style string interpolation > - refactor printing to make the code more readable > - read valid CPU ID's from "online" sysfs node > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v1,v2 -> v3: > - Import typing as T instead of individual types Looks good to me. Same remark than dpdk-hugepages.py: could you format=20 it using black or ruff? Thanks!