From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 709AE4582E; Wed, 21 Aug 2024 11:23:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCDB440E96; Wed, 21 Aug 2024 11:23:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0EE6A40E64 for ; Wed, 21 Aug 2024 11:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724232183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kESsERLcohIV15/DMpqFxzm2YxTYXX5xW3VC1vebq1U=; b=Pr/u/b7acgwqc4j4o9BFdt07z6xVm5gPVDY3049OXsgh2FzWERObp6RDBhm8Ew7S//eiTu c/z3Pt0CAq5+7/oycM6feyaw6VTOkjAKtsPJMc1Btbcvpq4j9lPxdDBV0+FkJmMQRkHHBs JCuJbiHWaTmjf73jMAehRi5fup2LuL4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-ZsSgiq60M_ms1T1OKmxW4A-1; Wed, 21 Aug 2024 05:22:59 -0400 X-MC-Unique: ZsSgiq60M_ms1T1OKmxW4A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3718bf7d54aso3762534f8f.1 for ; Wed, 21 Aug 2024 02:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724232178; x=1724836978; h=in-reply-to:references:user-agent:cc:subject:to:from:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kESsERLcohIV15/DMpqFxzm2YxTYXX5xW3VC1vebq1U=; b=u2U2U8AvG5pc7/U58V3WdLm30cHY6igUfMxqngXjB/LghJWWJOkjlzVSIdFQemn+PQ 1WwIdnOGJZUTWVEJ0OeFwd5rc6sZz2D44NgMVUjVbDzHHnQb/EAu6GeDxniMlPi0Pwef C9ot8PjuhwwHSRfmKR6aAXYT+20YHWqvpnZYKAH5uKX1kh7Ihg+MQQ9RZKnvcQsAxacv LyGzyr0iuOxht7uzQeEUfvVhGt3KoWFNdeoOJRd2O2fLYRkF2jToGDChsXndvbbf22I2 w2/g90id7ASdFBW4ALBnRxBBV9vaVH+HpMxW1XMhHxpqmfLjy+CRKbvNYTYMnizBB4oh OlnQ== X-Forwarded-Encrypted: i=1; AJvYcCW7z1Xgxkbcb5Hmi+B5CPQMt334Jvvgm1c4wq0MfM4kGLghdPS8fLVEy6Zk5tBOkC1uInE=@dpdk.org X-Gm-Message-State: AOJu0YxZmcCl1MVbEv5Ng2apUg/ujE2JdG6/1cuRZAOrTDcd43wYPwv8 VArgW5ZYdFW61fNz7efiEHwwSVhIIgKkos32MPgyBH32RLi2J5UZhiOb2KQFCCZk+KAnkcKOR1B 29eoZ1ob29LWC9MrJ6X57nNC+ZDmYUatEe5KT1AiJ X-Received: by 2002:adf:e8cf:0:b0:368:255e:ab13 with SMTP id ffacd0b85a97d-372fd71f43amr944480f8f.50.1724232178451; Wed, 21 Aug 2024 02:22:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzs5GqCYcQvvGQT2vNKV2qBx+aHGWIZlSY1ojIjZcJgfpfH3wJMTVApYmGhYnbWL0V6KBLMQ== X-Received: by 2002:adf:e8cf:0:b0:368:255e:ab13 with SMTP id ffacd0b85a97d-372fd71f43amr944466f8f.50.1724232177892; Wed, 21 Aug 2024 02:22:57 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ab87ef024sm38502205e9.1.2024.08.21.02.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 02:22:57 -0700 (PDT) Mime-Version: 1.0 Date: Wed, 21 Aug 2024 11:22:57 +0200 Message-Id: From: "Robin Jarry" To: "Burakov, Anatoly" , Subject: Re: [PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style Cc: User-Agent: aerc/0.18.2-53-g11f57b5f3378-dirty References: <1c9f589c434cfb91c53dae7528cfc165c976b0c6.1724168117.git.anatoly.burakov@intel.com> <5f7fcc6e-5e36-47e9-aed7-875a9d44d1e7@intel.com> In-Reply-To: <5f7fcc6e-5e36-47e9-aed7-875a9d44d1e7@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Burakov, Anatoly, Aug 21, 2024 at 11:16: > > Actually, I take that back - I had a configuration mishap and didn't=20 > > notice that I wasn't using Ruff for formatting on the machine I was=20 > > creating the commits. > >=20 > > Still, cpu_layout's formatting is not affected, but hugepage script is. > >=20 > > However, after formatting with ruff, I can see that 1) most single=20 > > quotes became double quotes, 2) some lines I broke up for readability,= =20 > > are no longer broken up, and 3) some lines I broke up to avoid exceedin= g=20 > > the 80 symbols count, are no longer broken up. Using these tools allow developers to stop thinking about coding style=20 and focus on more important matters :) > > I'll see if using Black yields different results. > > Regarding line length, it seems that it's configurable. Perhaps we could= =20 > include a Ruff/Black configuration file with DPDK to solve this problem= =20 > once and for all? Adding --line-length=3D79 to ruff config addresses the= =20 > last issue, but it wouldn't be necessary if there was a Ruff=20 > configuration file in the repo. I can live with first two things that I= =20 > highlighted. Both black and ruff have the same formatting rules and use a default 88=20 line length limit. Which yields good results in most cases: https://black.readthedocs.io/en/stable/the_black_code_style/current_style.h= tml#line-length I would prefer if we kept the default settings without any=20 customization. The DPDK code base is already allowed to go up to 100=20 columns anyways.