From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59B0E4582E; Wed, 21 Aug 2024 11:27:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEDDC40E44; Wed, 21 Aug 2024 11:27:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2CBD84003C for ; Wed, 21 Aug 2024 11:26:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724232418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KTjanI3ZJBbSF3UzZvP5FbzlJ3bwxzj565YUyYoP9e4=; b=PhQAvFZPA1XQHVg7EpVJDL6gQ01XawwFUQ++j56fCLfpEAaMjpigdgPeMU7MD/qlijVjzP vsdYL3XistnhMbHdUBUoArDOrOoCCoJJmjgxeYqMc3BmH7PEk0GnnMUOI1l8tCeoRNMlIt vlOF5T0E3oDjjmH/YOBm35zveJ+tWNs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-5j779tTkONSaeGdbN7aehg-1; Wed, 21 Aug 2024 05:26:57 -0400 X-MC-Unique: 5j779tTkONSaeGdbN7aehg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3717ddcae71so3415955f8f.3 for ; Wed, 21 Aug 2024 02:26:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724232416; x=1724837216; h=in-reply-to:references:user-agent:subject:to:from:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KTjanI3ZJBbSF3UzZvP5FbzlJ3bwxzj565YUyYoP9e4=; b=j23ykWYNALolskyAuCjh1uaa05//xqjkRU3iTYd37wQweZS2rkgk/yQwcRNu9sU/JJ 0CQ+0ZvroWEJlSu8wLn0xcu6Lrj9TrmH7TraY/K0lCXkhXwATLa3hp2xlz+SKJhGaaX1 dRUdYp/cUa2YnyMjZ8ImTm8ve/BFl7zgR20KyKusqfIX506VgX6FlJ4S27ha8GLuYZXW Bs+btkzgZTtNZaQpHQUAz+hXxgQs6N+psjWKOJq4sqOACP907yLqaPpP3qdHvMQmeb8h JDkBMmEiVdUtEEUKhQs6IjAP1kEea8YrSNOcrObz1AcRj70TwXgNrE8aipDO5RneNFvZ 6B9g== X-Forwarded-Encrypted: i=1; AJvYcCWSor7xuc56im6QRRE3XDNa/8aPuMIF8MYtuBdNx4E71d7SQaqMOa6xbwICYUJiufablYU=@dpdk.org X-Gm-Message-State: AOJu0YyC1/s2uDRGIwt7vPu7Uv9olQ6dLjeZrllvU0LkWJ36SZsyE0rh p0PVUEb0bvHkvgtfi3IQeiew5Ycd+sHiwn6kKpo7PhFE39zqy8YkDG5WwVGDPHueqj0GDMkW+hi iDGnhXR1bXWchttdQ92qvQt2XY2r9ptgEKvfw+h3a X-Received: by 2002:a5d:628f:0:b0:371:9353:6132 with SMTP id ffacd0b85a97d-372fd706263mr977569f8f.36.1724232416109; Wed, 21 Aug 2024 02:26:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPUQtO1b6fxDKKgm3KD2/CWijXQOClTK/+BBllvcS9kkXcmGCBgPmN5BeqQiqZHAGwWkN3fA== X-Received: by 2002:a5d:628f:0:b0:371:9353:6132 with SMTP id ffacd0b85a97d-372fd706263mr977557f8f.36.1724232415617; Wed, 21 Aug 2024 02:26:55 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189859d4esm15186342f8f.49.2024.08.21.02.26.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 02:26:55 -0700 (PDT) Mime-Version: 1.0 Date: Wed, 21 Aug 2024 11:26:54 +0200 Message-Id: Cc: , "Stephen Hemminger" From: "Robin Jarry" To: "Anatoly Burakov" , Subject: Re: [PATCH v4 3/4] usertools/dpdk-hugepages.py: update coding style User-Agent: aerc/0.18.2-53-g11f57b5f3378-dirty References: In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Anatoly Burakov, Aug 21, 2024 at 11:22: > Update coding style: > > - Make the code PEP-484 compliant > - Add more comments, improve readability, use f-strings everywhere > - Address all Python static analysis (e.g. mypy, pylint) warnings > - Format code with Ruff > - Improve error handling > - Refactor printing and sysfs/procfs access functions > - Sort output by NUMA node > > Signed-off-by: Anatoly Burakov > Acked-by: Stephen Hemminger > --- > > Notes: > v3 -> v4: > - Format code with Ruff, line width 79 to avoid flake8 warnings > (Flake8 is by default configured with line width 79 on my system) Please keep the default ruff/black settings. And when formatting with=20 these tools, flake8 is mostly useless. If you want to check your code for defects, you are probably best with=20 `ruff check` which combines the features of multiple python linters and=20 runs much faster. > v2 -> v3: > - Rewrite of the script as suggested by reviewers > v1 -> v2: > - Added commit that sorted output by NUMA node