From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A94845847; Thu, 22 Aug 2024 17:27:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1743842EE3; Thu, 22 Aug 2024 17:27:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DECFD42E52 for ; Thu, 22 Aug 2024 17:27:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724340464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSD1c6B3AMyBZ/D9DxedCZIETyMbtyDD0FEbJF4cqK4=; b=SYgAur+ux0jWeTvaAB1hsK/rKRwLZiLMB0gpjk7JFM7CjR3ecG8UVB//GGNFNY4H2005Nj O8EFT14X+HZziwnajyArcjAT/qgpAjU5Ux5eYa2gEkJ9byIbFAKdKBNv7pzwGrtB+C0XiF 4WzB497RiqhiPaxq/YHKkwQOFeLrjhg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-FuVac9zzNZ2ONLT9agyqhQ-1; Thu, 22 Aug 2024 11:27:43 -0400 X-MC-Unique: FuVac9zzNZ2ONLT9agyqhQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37188f68116so428597f8f.3 for ; Thu, 22 Aug 2024 08:27:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724340462; x=1724945262; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eSD1c6B3AMyBZ/D9DxedCZIETyMbtyDD0FEbJF4cqK4=; b=hn6w/j0Jrq8WPWGM98q7SrxNTzDQkDy0geH3rVZtQ/M9XtFv9ehJC7w9tduIfpU8U7 EDNpebi3mO9DsXNdrFXVtXttAw3W4KB2zkNejWv3IqNbnN/rAhP/uEJIQHqqokYX+L1J xkLeP08V+s/vFRwJGXUE/tBcpaPzuD0icuet6gDoT0fo/85zoRpkl21IIXcUEXvYmzK1 iX7oltOPfX3hzm11wPVtBSe1ifcfHp5BNn7LpdeDCS6DT/q1vBaVVSWQTQwmYMGL/zhN BDr+Aeg7Jr8mtlZymyt4aJL7zcH4KhLsS/rYe6syK6oAzP/1vVGu9xcqk/kDNpMwbB0Z rgEA== X-Gm-Message-State: AOJu0Yxv8B0oV+c11RnJtpI3CWRPeresqO4dOmkAoeZOzKDLeJkT0Bsg wSYcIWLp+UOsRcTu2tXceF7SWUwgAs6guyEK6n8PIqkDkGE4HiWzH0sUd5Fnt4KUrkiVT720Kz+ ZbUP5Hvx+woxr+4TuiPufatsDa5IejPl0hYNBmzNK X-Received: by 2002:adf:e8c1:0:b0:368:4d33:9aac with SMTP id ffacd0b85a97d-37308c34a68mr1405384f8f.31.1724340461854; Thu, 22 Aug 2024 08:27:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEk7rkPbFMnFR6Nc0XtoBQp2/qeR9jAMu4v/utVGcBDNcSHsFe8HzV41YeNf86iA2S0JFLEmA== X-Received: by 2002:adf:e8c1:0:b0:368:4d33:9aac with SMTP id ffacd0b85a97d-37308c34a68mr1405358f8f.31.1724340461314; Thu, 22 Aug 2024 08:27:41 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37308110035sm1933404f8f.16.2024.08.22.08.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 08:27:40 -0700 (PDT) Mime-Version: 1.0 Date: Thu, 22 Aug 2024 17:27:40 +0200 Message-Id: Subject: Re: [PATCH dpdk v1 00/15] IPv6 APIs overhaul Cc: , "Vladimir Medvedkin" , "Konstantin Ananyev" , "Bruce Richardson" From: "Robin Jarry" To: =?utf-8?q?Morten_Br=C3=B8rup?= , "Stephen Hemminger" User-Agent: aerc/0.18.2-53-g11f57b5f3378-dirty References: <20240821162516.610624-17-rjarry@redhat.com> <20240822071352.5e4766ba@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F65E@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F65E@smartserver.smartshare.dk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Morten Br=C3=B8rup, Aug 22, 2024 at 17:13: > The types seem to be different in the Windows API (than in Linux/BSD): > https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba01080e9334= 9c2ed/Include/10.0.14393.0/shared/in6addr.h#L25 > https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba01080e9334= 9c2ed/Include/10.0.16299.0/shared/inaddr.h#L25 > > Furthermore, but less important: > The existing in the Linux/BSD/Windows IPv6 address type are 2-byte aligne= d. At least BSD is 4 bytes aligned. https://github.com/freebsd/freebsd-src/blob/498286d4e807d6b9e4caad22b96ebca= 7f16e9b18/sys/netinet6/in6.h#L91-L100 And on Linux, it depends on the libc implementation? https://github.com/torvalds/linux/blob/872cf28b8df9c5c3a1e71a88ee750df7c251= 3971/include/uapi/linux/in6.h#L33 > In the RFC discussion, we agreed to omit any alignment requirements for t= he DPDK IPv6 address, for tunneling purposes. > We could introduce 2-byte alignment later, using a union and an array of = uint16_t, if beneficial. > > Which makes me think... > Maybe the 'a' field in the DPDK IPv6 address structure should be named 'b= ' for "byte" instead, to prepare it for adding a union with a 'w' (for "wor= d") field if we want to introduce 2-byte alignment. My idea was to name the field a16 instead of w which would be confusing.=20 Also, how would you name a 32 bit array field if it presented itself?