From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0586045AAD; Fri, 4 Oct 2024 13:51:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA1EA40E5E; Fri, 4 Oct 2024 13:51:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B3C044027F for ; Fri, 4 Oct 2024 13:51:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728042687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uu/SbkZ1p88FlkdhsL5g1S5oI3EGy+y9JTS2OrpSfws=; b=NJNblCi9qPUYA1xmsUjW3sdSk0Iw6yEt4mRVmsXrCIy5IiggpLUhxTFnRsLrDrkfQmxtaC X9vva4z5oEFlyQ8IUiJhCdu2/BHU8k+AL4If1Ks/nfwuTYxQBYO0gUy13acwnzw84Puu0n dcC51EDb6Hv5l48kNzHCHNTzX8Pb0ao= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-2HVFFYnhNvuMMIFofZyIow-1; Fri, 04 Oct 2024 07:51:24 -0400 X-MC-Unique: 2HVFFYnhNvuMMIFofZyIow-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb89fbb8cso11487065e9.0 for ; Fri, 04 Oct 2024 04:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728042683; x=1728647483; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uu/SbkZ1p88FlkdhsL5g1S5oI3EGy+y9JTS2OrpSfws=; b=Wff+X2QUypSbFn2E3qIfzNzes6PhhMuvCxxwIAvUG76bvtio8A8j43IfyCioWgis5M iZ+sAVbBUyLDr5WRlgzrqd5N94Dt+6jYjs7NmKVL0s21X/dIEEjEi6nIOiRtSFykjyO1 veu/dHbYqAejLYKnuGGAHNTbgcstRkLhZa4e5wegWFciZxyZSzeborEYxiZJWcQvvv3J JFZrrKAbH1jjHpP0ptl2mDU1Nl0GixzZE2ttTwuP6GueO5unhIbc4KMkhIg7VNWeBBcm HgKAv4RJwMHbSL0b3M4vCwT6sRU61fSoqNGqj29rcNRJlDel4VJTZcXNREEOGAzs0BI8 h8SQ== X-Forwarded-Encrypted: i=1; AJvYcCWtcdCfIgS9fw0AP7TmkJLdBurtrqmiNQHjWQuc8mE/dDC/e/aMe6adR8cPOsuun10VR5k=@dpdk.org X-Gm-Message-State: AOJu0YwjCkYbmlQC3GQqpJyZMIu24d6opjOjHFyNWmiVs7MxqL4AqB0g JdTiXwWKyHD2vb+Ke2cCncc1F9k9gYAdKwdIIjNHtVe9O0kwKMEqlUea2XHr+2fdQIwzWf5n2Sf yi63Zws1PKXe/XOUNiAtM1ya9cccDkf6lIBAmVbIC X-Received: by 2002:a05:600c:468b:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-42f85af4ffdmr17072985e9.30.1728042682904; Fri, 04 Oct 2024 04:51:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwUG9qkIc6jXNDyL4rqeyboaZh9WVdE7/tbrAnxrc9OHHSYctFgnYkKQRq0SK216z9rlDRIA== X-Received: by 2002:a05:600c:468b:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-42f85af4ffdmr17072735e9.30.1728042682528; Fri, 04 Oct 2024 04:51:22 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86b1d640sm13819625e9.25.2024.10.04.04.51.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 04:51:22 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 04 Oct 2024 13:51:21 +0200 Message-Id: Subject: Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement Cc: "Heng Wang" , "Stephen Hemminger" , "Tyler Retzlaff" , =?utf-8?q?Morten_Br=C3=B8rup?= , "Jack Bond-Preston" , "David Marchand" , "Chengwen Feng" From: "Robin Jarry" To: =?utf-8?q?Mattias_R=C3=B6nnblom?= , =?utf-8?q?Mattias_R=C3=B6nnblom?= , User-Agent: aerc/0.18.2-74-g7e4ac1a5f54c References: <20240920062437.738706-2-mattias.ronnblom@ericsson.com> <20240920104754.739033-1-mattias.ronnblom@ericsson.com> <20240920104754.739033-2-mattias.ronnblom@ericsson.com> <74e86a66-4341-465d-bcba-d76db66035cd@lysator.liu.se> In-Reply-To: <74e86a66-4341-465d-bcba-d76db66035cd@lysator.liu.se> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Mattias R=C3=B6nnblom, Oct 04, 2024 at 10:40: > Making small scripts needlessly complicated is not good example, it's a= =20 > bad one. I don't find adding argument checks needlessly complicated but this is=20 a matter of preference. To me, Python is not shell script. If you want=20 something small, shell might be more appropriate? >>> Sure, but it would be required to invoke the script for every header=20 >>> file in the tree. Not sure I think that would be a net gain. >>=20 >> You can store a global exit status in the script and process all headers= =20 >> before exiting with an error if any. > > You will need to give the user a list of offending header files. I'm not suggesting to avoid printing the offending file names. I'm only=20 suggesting to exit(1) if there were *any* offending file names. That way=20 you don't have to check *in meson* if the script did output anything.=20 Checking the exit status is simpler. Sorry for being pedantic, but Python code in DPDK is already treated=20 badly. I wish we could improve the quality a bit. Cheers.