From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3956145A6D; Fri, 11 Oct 2024 11:54:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F25414028B; Fri, 11 Oct 2024 11:54:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DA39E40150 for ; Fri, 11 Oct 2024 11:54:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728640450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CueDgJp9WEywBtqK08RXK0Oo8PbIUJG+KtlwmjrHVms=; b=V9tYmOkjpkPIMRJd8h86cMW/Ke1UKH9qu+zL9i4kiPo9TunNYId/Ch5a5wNuiXAPYtqmJM rbrlSmTPA0QUhCbGt6jMXoC7s5J36zBFQ0iQc0GfD//dTlVh/Oq+Dl6yV16bfhr4b25EsB tFpY8gxCqcXHMTWpdtAyPTORp/7eAHM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-loJP3jTgOIy2u7PSVtq5hw-1; Fri, 11 Oct 2024 05:54:09 -0400 X-MC-Unique: loJP3jTgOIy2u7PSVtq5hw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d5116f0a6so520672f8f.0 for ; Fri, 11 Oct 2024 02:54:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728640448; x=1729245248; h=in-reply-to:references:user-agent:subject:to:from:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VgEQgOfmlOaNXmqMixAy4xPbnt5abZpa4LX1Gz+aWc8=; b=Tl3cywCCHcL7V76ISb2StPUYFD6YcGw9djw3yaXQyZFxnwhjyOhSkl6ekqIg4M3VBc r7MaKgTEaC/xWqxwhPiNBENzWRDU749xevYdHsfvYaoVccvNH/EZwucQAPGm1xHQDpeR 9Fp6yFSwuFvrSwD4bA1X++GKLROTQFN4r83VDle/MYaJuSjDBby6Lii+PgizLYe9sF5i Iy/SmTNT9LVZJ5H40q4/k55zM4swjjbt7AfezrQvq8t8B7P7oIdO/gDRTVBraJ4g9Nkl UlyYu8eMRQl/9gNFVbAizH4vTHAHEJxOgMvk1ryckDjM8nPpJgC+lgIMgVuJPiekVDJm fAeg== X-Gm-Message-State: AOJu0Yxe0S6lewkWVEUE9hMdtG6gkgCBZ0unLMYSa8AIrCihfUZioAaY zMXM1ueXg9xuQNMJCAb5awMcGqz49JG3hx7biuxvUIL2Tir00A0IFcm8Z4zxgXj4fcTwCPLBmb2 N6hxgnMJ2uHsDJLAbCjz05ciU2rAsqBsoNh9LMgSE X-Received: by 2002:a05:6000:18a7:b0:37d:5046:571 with SMTP id ffacd0b85a97d-37d551c07c5mr1578936f8f.22.1728640448093; Fri, 11 Oct 2024 02:54:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfFZ/j+SVLPBnt32kdc6UuXQKL9uIzFNFtCSCGdZmKnb0vimY7AbKHMNVRY3JfgXvx7AC8Jw== X-Received: by 2002:a05:6000:18a7:b0:37d:5046:571 with SMTP id ffacd0b85a97d-37d551c07c5mr1578912f8f.22.1728640447646; Fri, 11 Oct 2024 02:54:07 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6a8269sm3580822f8f.1.2024.10.11.02.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 02:54:07 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 11 Oct 2024 11:54:06 +0200 Message-Id: Cc: From: "Robin Jarry" To: , , , , , "Zhirun Yan" Subject: Re: [PATCH v4 3/5] graph: add stats for node specific errors User-Agent: aerc/0.18.2-74-g7e4ac1a5f54c References: <20240222122342.16375-1-pbhagavatula@marvell.com> <20240816150926.5789-1-pbhagavatula@marvell.com> <20240816150926.5789-3-pbhagavatula@marvell.com> In-Reply-To: <20240816150926.5789-3-pbhagavatula@marvell.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pavan, , Aug 16, 2024 at 17:09: > From: Pavan Nikhilesh > > Add support for retrieving/printing stats for node specific > errors using rte_graph_cluster_stats_get(). > > Signed-off-by: Pavan Nikhilesh > --- [snip] > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h > index b28143d737..12b6461cf5 100644 > --- a/lib/graph/rte_graph.h > +++ b/lib/graph/rte_graph.h > @@ -223,6 +223,10 @@ struct __rte_cache_aligned rte_graph_cluster_node_st= ats { > =20 > =09uint64_t realloc_count; /**< Realloc count. */ > =20 > +=09uint8_t node_error_cntrs;=09=09=09 /**< Number of Node error counte= rs. */ > +=09char (*node_error_desc)[RTE_NODE_ERROR_DESC_SIZE]; /**< Names of the = Node error counters. */ Why do you need the parentheses here? > +=09uint64_t *node_error_count;=09=09=09 /**< Total error count per eac= h error. */ The node_ prefix is redundant here. Can you use something shorter? uint8_t errors_num; /**< Number of Node error counters. */ char (*errors_desc)[RTE_NODE_ERROR_DESC_SIZE]; uint64_t *errors_value; Thanks!