From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AE3D45B42; Tue, 15 Oct 2024 10:17:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A6704064C; Tue, 15 Oct 2024 10:17:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 762B340656 for ; Tue, 15 Oct 2024 10:17:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728980222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=trP+A2M6dw2Uh84OWVBi9/sACOsIYG466FUbrwR+CoY=; b=Kyr1wRoZScwXlBEOf3GkVB2B8qLF7xJQ5MIpdgDeGNe6mq0oIBtAbUQR2bZH1CHjYjPnN7 FyvprssxUzeXwnfRTv1qAtRCNopxCvtVlx7mdre9YEjLizD88OR2PrfiDC8CH1gmglyPFH DQTffL+EsHsrDAorgTYS+J91Rdu+iPs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-XJMrK9WDOwyg_d2qBW8k7g-1; Tue, 15 Oct 2024 04:17:00 -0400 X-MC-Unique: XJMrK9WDOwyg_d2qBW8k7g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43052e05c8fso34435565e9.2 for ; Tue, 15 Oct 2024 01:17:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728980220; x=1729585020; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=trP+A2M6dw2Uh84OWVBi9/sACOsIYG466FUbrwR+CoY=; b=TcceEDLX311MG7g+mPLj2wVVo4I50OsRsgydMxkNwgeMpN2OQ9ytfHGbaMZeOBom3X T3/JzIIW8vaJmmFMeox/O06zjUeV5FhrU1tAOGAbs70uB0OjzYuadPyapyoXiXWH9Vht GsUIVmr7vZ+Efl6zN6EOMRYwbbK/7hZgCB4qQXJNBzdKiYIRKJiiUW0ajCG5E345UIw3 p2yZVeoB/BdOEkOQECdHZiPJq1x1+ESKiH3Er3OWqve+EixE3rNos7BwQnbpUwDAV2s9 W0RIoQQrz6PIXuB8HxooybkEf7NwEbmp47qzAnEFsTDU2lr4yfqg9LgulpNu1u7nBI0+ cHsQ== X-Forwarded-Encrypted: i=1; AJvYcCWv9ZeEsPXhR35m7eJwaYQ/bQArSNvEhDmLz7NIoYfji+kK1+5kvWjxCifsHdPjr73+9gY=@dpdk.org X-Gm-Message-State: AOJu0YyRyghBRbm8Z0yphfb7Zx7rffmR4LRdKx0GPhm3pCid01HE51FH VF7PDAwuFIg0T6X4N713ZXMZgZGNxtBBDWNtEmjrwCGSIG8bukgGEGUuqXp3NbBLuA8jNl2PgGL bgksBpjGM0CuO8OIXLnrvdpV1hQvdJDkhkqtbidLs X-Received: by 2002:a05:600c:4446:b0:428:e866:3933 with SMTP id 5b1f17b1804b1-4311df42e52mr116641575e9.22.1728980219654; Tue, 15 Oct 2024 01:16:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFleJSW5FP7W9ZiyDxJLr84vfT1KM5d70/H4KlsPoGSvyPHtscK4Z8hHOm7vtbNdHQmS7Rp/Q== X-Received: by 2002:a05:600c:4446:b0:428:e866:3933 with SMTP id 5b1f17b1804b1-4311df42e52mr116641355e9.22.1728980219238; Tue, 15 Oct 2024 01:16:59 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43143c952d5sm4828755e9.0.2024.10.15.01.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 01:16:58 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 15 Oct 2024 10:16:58 +0200 Message-Id: Subject: Re: [PATCH 2/5] build: remove version check on compiler links function Cc: , , , From: "Robin Jarry" To: "Bruce Richardson" , User-Agent: aerc/0.18.2-81-g43ce621f36dd References: <20240920125737.1197969-1-bruce.richardson@intel.com> <20240920125737.1197969-3-bruce.richardson@intel.com> In-Reply-To: <20240920125737.1197969-3-bruce.richardson@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Bruce Richardson, Sep 20, 2024 at 14:57: > The "compiler.links()" function meson documentation [1] is a little > unclear, in a casual reading implies that the function was new in 0.60 > meson release. In fact, it is only enhanced as described in that > release, but is present earlier. > As such, we can remove the version checks preceeding the calls to links > function in our code. > > [1] https://mesonbuild.com/Reference-manual_returned_compiler.html#compil= erlinks > > Fixes: fd809737cf8c ("common/qat: fix build with incompatible IPsec libra= ry") > Fixes: fb94d8243894 ("crypto/ipsec_mb: add dependency check for cross bui= ld") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Robin Jarry