From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D35945B61; Thu, 17 Oct 2024 20:03:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E64A64029C; Thu, 17 Oct 2024 20:03:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F5FF4025F for ; Thu, 17 Oct 2024 20:03:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729188227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4DehLD6E7/VJDr545A2Yh/97NPZpH6GpSTBUdDJknlA=; b=hu3NJ11aUR0ni16qJm7E3d6cCtQ3Q/y96NUkl9gDkldIWYobGYwJHb4zxek/3re8AzAu6x 001Q1y8rGEBNngeemh+UQZiQIfRmAeJKctCReQ5B9meYXQuRN4jjKNI1zLOM+omv2Uou8g Rabk/VbFQfVImH1YEwV3dwlQrIyaWcs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-j5NaeSzJMSCUYITdoU5gpQ-1; Thu, 17 Oct 2024 14:03:40 -0400 X-MC-Unique: j5NaeSzJMSCUYITdoU5gpQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d56061a4cso670006f8f.2 for ; Thu, 17 Oct 2024 11:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729188219; x=1729793019; h=in-reply-to:references:user-agent:cc:subject:to:from:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4DehLD6E7/VJDr545A2Yh/97NPZpH6GpSTBUdDJknlA=; b=ARox2RT8xYYtw4Oo8Kci/X8d6FRC/IUJFIjQnJwMO9fopHOulC7HUuhr7G7DL5hGfS TG+IFHfiU4uatyViJCHFpM1bGNSH9sNI5OoOBNuQrWw3z0fwiuT6dbxN4FSu7aikPJSa TfxTp7yJnwzjbJr6qfc4HAK7yBsZqy159MqdsJ+dmeaz3DKOwqS0hdy58jQzHmuryIFX tDT/hziX1sjEXk4o2tNnO+r0Rash2nnKzAGkLgGtxhMzKFrzIPQUc45NSCVY7yU0aqP4 h6B7/U4YKVpvF1SoB74d1fdqqaIFDDghV7XVoqFX0Wx72jx1TJzBA/UJzK/q/69ot22H IBAA== X-Gm-Message-State: AOJu0YwoAvXkXZC6kCttbVqJNs0ALiCOSdqC5l0VujcyPOL9/wc7godJ etnrbDcgMr+e47JkgPdCMAJi2Wcr0QNXEttSUygC8v9NkynBkjdAs3uqtZWOHp0qLMppM8ErVUT hPWo36NqEBMyp3XOH/pKperQb081PtJDwxn1myOTo X-Received: by 2002:adf:f050:0:b0:37d:454f:b49a with SMTP id ffacd0b85a97d-37d55262f0cmr17492804f8f.43.1729188219414; Thu, 17 Oct 2024 11:03:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGCc1R6/79CFzP8nXUZDUQmBC3OuRgJr7EXavW3XJmzSx1x9UYPQuHU0AauHFcO/aOuo0YjQ== X-Received: by 2002:adf:f050:0:b0:37d:454f:b49a with SMTP id ffacd0b85a97d-37d55262f0cmr17492786f8f.43.1729188218976; Thu, 17 Oct 2024 11:03:38 -0700 (PDT) Received: from localhost (2a01cb00025433001b9f807167cdbf20.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:1b9f:8071:67cd:bf20]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fa96357sm7959174f8f.64.2024.10.17.11.03.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 11:03:38 -0700 (PDT) Mime-Version: 1.0 Date: Thu, 17 Oct 2024 20:03:37 +0200 Message-Id: From: "Robin Jarry" To: "David Marchand" Subject: Re: [PATCH dpdk v3 00/17] IPv6 APIs overhaul Cc: , "Bruce Richardson" , "Ferruh Yigit" , "Konstantin Ananyev" , =?utf-8?q?Morten_Br=C3=B8rup?= , "Stephen Hemminger" , "Vladimir Medvedkin" , "Thomas Monjalon" User-Agent: aerc/0.18.2-82-g9e557d0f289f References: <20240821162516.610624-17-rjarry@redhat.com> <20241010194148.1877659-1-rjarry@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand, Oct 17, 2024 at 15:52: > Hello Robin, > [snip] > - Now that many changes hit the main repo, this series needs some > rebasing (conflicts are not too difficult, but having this rebase run > through a bit in the CI would be great). Will do. > - From a compatibility pov, I am not fond of the rte_ip.h =3D> rte_ip.h, > rte_ip6.h split. > > Applications will need to be updated for something that was ambiguous > so far: rte_ip.h defined all symbols, regardless of IPv4 and IPv6. > What do you think of keeping a rte_ip.h compat header that just > includes new rte_ip4.h and rte_ip6.h headers? I can include rte_ip6.h in rte_ip.h for backward compatibility. > - With current patch, since only rte_ip.h is parsed in doxygen, we > lost documentation for IPv6. > Regardless of keeping a compat header, doc/api/doxy-api-index.md needs > some update. Got it. I will add a new "IPv6" section in "layers" and a checksum=20 section in "basic" (rte_cksum.h split also removed some symbols from the=20 "IP" section). > - bonus 1: > It would be worth cleaning unneeded includes in rte_ip*.h. > But changing this is risky if we want to take this series in rc1. > Please don't do this in next revision, this will wait after merging this = series. > > For example, running iwyu returns: > > lib/net/rte_ip.h should remove these lines: > - #include // lines 26-26 > - #include // lines 28-28 > - #include // lines 33-33 > - #include // lines 23-23 > - #include // lines 24-24 > > lib/net/rte_ip6.h should remove these lines: > - #include // lines 26-26 > - #include // lines 27-27 > - #include // lines 31-31 > - #include // lines 23-23 Ok, I will hold off changing this for now. Btw, rte_mbuf *is* actually=20 used in rte_ip6.h. Maybe iwyu has some troubles identifying things :) > - bonus 2: > Would it be possible to provide a cocci script or some shellscript for > an application to convert to the updated APIs (especially the impact > on rte_flow and other structures)? > We did something similar for the prefixing of dpdk structures with RTE_. > > Idem, not necessary for rc1. I never used coccinelle and it may be complicated to come up with=20 something reliable. It is not a simple renaming of symbols. It is=20 a change of signature for a lot of functions. This would require=20 extensive changes in the application code. Cheers.