From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1764045B61; Fri, 18 Oct 2024 00:33:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B13B40279; Fri, 18 Oct 2024 00:33:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A07340268 for ; Fri, 18 Oct 2024 00:33:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729204393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZ4lZl5AdFPsqd2nfc16P6DWqxi5MO6pQyY1RGg3jMg=; b=QGyEyzedKHE9azXrkyduIf05WbcZLnjZ/p0J477Fa/WOxJahToF8JBxq7YWyHm0tW+8oQv ntKG5v7icC1Uw+LyZcW1m9dj1mJ85crsGImmcHiTfOGf8Fr04eh3GEhKOIKdjY2e2a/oFu zPJDc2+HGifnPHtIl/eVQu2v16a0kWk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-gdFP9VI7N8K4E7zcEcgj9A-1; Thu, 17 Oct 2024 18:33:12 -0400 X-MC-Unique: gdFP9VI7N8K4E7zcEcgj9A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d432f9f5eso680633f8f.0 for ; Thu, 17 Oct 2024 15:33:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729204391; x=1729809191; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RZ4lZl5AdFPsqd2nfc16P6DWqxi5MO6pQyY1RGg3jMg=; b=Ev0RgvIZK1DdG7e9r43ASW5P8W3EHS8w60gWJRtwkJsgE3Zppp8djQu485pmSdDfL2 SjbFErx6y0+jsB3p/1KUQ11wX2dc0JzYeAf4NTsq87Co4lvqt1D1eUp4c9HS3TIR6820 c3L+1T35hm56vIy3vN9Gz6fpwBJINR5fhxCWWy+FpIdRazYvrf7vPBLOEuJBB3pKvoQV PFayOLYtSGk03N1wugDzDVx82wlVsq0OPtHp5JamHH3FsOmwBqZ8vOK+A94i8XyjKtGE HIllattDI3oqhiWv39kcYsyzhocp9GYfVsxKHwe/u+HYOGZ4PLXjuspwKdRY5aQVk7ef g4Fw== X-Gm-Message-State: AOJu0YwVuT9DVftVJs64AMGMvlt0hVGOCTTZbf64p6aakejC9rHP94W8 aVCEvB1GwFWLjDamtQCD3LLWdw5SASunEuyiTw/iY8MZL0vq0k8yXShExm16GecVB293pFct5eJ cRykskGlLZ28nZ7OHsNKevPa9137kTUDDpV1IDgAM X-Received: by 2002:a5d:4b05:0:b0:377:6073:48df with SMTP id ffacd0b85a97d-37eb489b413mr241493f8f.58.1729204391174; Thu, 17 Oct 2024 15:33:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiPTF5m7CmmGVM5IroL2PMYEc5wJJNmwHnVPZEkLWbpBGM3axBnCvYfdx588HPi/DKLSQj4A== X-Received: by 2002:a5d:4b05:0:b0:377:6073:48df with SMTP id ffacd0b85a97d-37eb489b413mr241484f8f.58.1729204390768; Thu, 17 Oct 2024 15:33:10 -0700 (PDT) Received: from localhost (2a01cb00025433001b9f807167cdbf20.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:1b9f:8071:67cd:bf20]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ecf0ed5e9sm202905f8f.76.2024.10.17.15.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 15:33:10 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 18 Oct 2024 00:33:09 +0200 Message-Id: Subject: Re: [PATCH dpdk] net: add more icmp types and code Cc: , "Aman Singh" From: "Robin Jarry" To: "Ferruh Yigit" , "Stephen Hemminger" , "Thomas Monjalon" User-Agent: aerc/0.18.2-82-g9e557d0f289f References: <20241017083322.2166467-1-rjarry@redhat.com> <20241017090258.289a0aaf@hermes.local> <0d0c4a30-372e-4b68-a52f-e525bd2d21e9@amd.com> In-Reply-To: <0d0c4a30-372e-4b68-a52f-e525bd2d21e9@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ferruh Yigit, Oct 18, 2024 at 00:22: > On 10/17/2024 5:02 PM, Stephen Hemminger wrote: >> On Thu, 17 Oct 2024 10:33:22 +0200 >> Robin Jarry wrote: >>=20 >>> Add more ICMP message types and codes based on RFC 792. Change the >>> namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiatio= n >>> between types and codes. >>> >>> Signed-off-by: Robin Jarry >>=20 >> Should add a release note for this >>=20 >> Acked-by: Stephen Hemminger >> > > +1 to get this in 24.11 > > Acked-by: Ferruh Yigit > > > @Thomas, probably it is better to get this for -rc1 and as next-net > already pulled can this directly go to main? I will probably send a v2 with a release note. > > Btw, is following also required? Just because it is documented in RFC: > 15 Information Request > 16 Information Reply It seems some of the original codes have been deprecated: https://www.rfc-editor.org/rfc/rfc6918#section-2.2 > Ack stands if above added or not.