[dpdk-dev] app/testpmd: compilation error with bitrate/latency config flags disabled

[dpdk-dev] app/testpmd: compilation error with bitrate/latency config flags disabled

[Patil, Harish]

Hi,
Seeing compilation errors with DPDK 17.05-rc3 when I happened to disable
bitrate/latency configs during our internal testing.
CONFIG_RTE_LIBRTE_BITRATE=n and
CONFIG_RTE_LIBRTE_LATENCY_STATS=n.

/home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c: In function
?main?:
/home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c:2242:2: error:
?bitrate_enabled? undeclared (first use in this function)
  bitrate_enabled = 0;
  ^
/home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c:2242:2: note:
each undeclared identifier is reported only once for each function it
appears in
make[5]: *** [testpmd.o] Error 1
make[5]: *** Waiting for unfinished jobs....

Does the patch you sent for review: "[PATCH] app/testpmd: disable latency
stats by default” address this?
Please check.

Thanks,

harish

Re: [dpdk-dev] app/testpmd: compilation error with bitrate/latency config flags disabled

[De Lara Guarch, Pablo]

Hi Harish,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Patil, Harish
> Sent: Wednesday, May 03, 2017 7:34 AM
> To: Horton, Remy; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] app/testpmd: compilation error with bitrate/latency
> config flags disabled
> 
> Hi,
> Seeing compilation errors with DPDK 17.05-rc3 when I happened to disable
> bitrate/latency configs during our internal testing.
> CONFIG_RTE_LIBRTE_BITRATE=n and
> CONFIG_RTE_LIBRTE_LATENCY_STATS=n.
> 
> /home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c: In function
> ?main?:
> /home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c:2242:2:
> error:
> ?bitrate_enabled? undeclared (first use in this function)
>   bitrate_enabled = 0;
>   ^
> /home/root1/hpatil/17.05-rc3/dpdk/app/test-pmd/testpmd.c:2242:2:
> note:
> each undeclared identifier is reported only once for each function it
> appears in
> make[5]: *** [testpmd.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> 
> Does the patch you sent for review: "[PATCH] app/testpmd: disable latency
> stats by default” address this?
> Please check.

No, this is a separate issue. I will send a patch to fix it
(also a v2 for the patch that you mentioned, as it needs that fix too).

Thanks for spotting that.

Pablo
> 
> Thanks,
> 
> harish
> 
> 
>