DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kyle Larose <klarose@sandvine.com>
To: Declan Doherty <declan.doherty@intel.com>,
	"users@dpdk.org" <users@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] active_backup link bonding and mac address
Date: Fri, 12 May 2017 19:02:58 +0000	[thread overview]
Message-ID: <D76BBBCF97F57144BB5FCF08007244A7705D4E65@wtl-exchp-1.sandvine.com> (raw)
In-Reply-To: <8f0580c1-532c-83c5-df4b-68bdbb3a5a05@intel.com>

> -----Original Message-----
> From: Declan Doherty [mailto:declan.doherty@intel.com]
> Sent: Friday, May 12, 2017 11:47 AM
> To: Kyle Larose; users@dpdk.org; dev@dpdk.org
> Subject: Re: active_backup link bonding and mac address
> 
> 
> Yes it would be into the hw tables, rte_eth_dev_mac_addr_add() on each slave
> port should achieve this, so there will be no need to run in promiscuous
> mode. I'll try and setup a test for this on Monday morning in our lab.
> 
> Declan


Thanks for the suggestion. I modified mac_address_slaves_update to add the link
bond's mac address to all slaves in addition to setting their mac. Previously it
would only set the link bond's mac on the primary, and not add it to the hw.
This has solved my problem. On failure of the primary, my application starts
working via the backup seamlessly.

Now, I'm not sure if what I have done is ideal -- should we only be installing it
on the primary, and removing it from the old primary on failure? Either way, let
me know if you want my change as a patch, or whether you've come up with one of
your own. :)

Thanks,

Kyle

      reply	other threads:[~2017-05-12 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 14:31 Kyle Larose
2017-05-12 14:55 ` Declan Doherty
2017-05-12 15:34   ` Kyle Larose
2017-05-12 15:46     ` Declan Doherty
2017-05-12 19:02       ` Kyle Larose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D76BBBCF97F57144BB5FCF08007244A7705D4E65@wtl-exchp-1.sandvine.com \
    --to=klarose@sandvine.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).