From: Kyle Larose <klarose@sandvine.com>
To: "Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>
Cc: "Zhang, Jerry" <jerry.zhang@intel.com>,
Wanghanlin <hanlin.wang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable using wrong index
Date: Thu, 23 Nov 2017 16:53:27 +0000 [thread overview]
Message-ID: <D76BBBCF97F57144BB5FCF08007244A7EDB5A19C@wtl-exchp-1.sandvine.com> (raw)
In-Reply-To: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
Hello,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lilijun (Jerry)
> Sent: Monday, November 20, 2017 2:16 AM
> To: dev@dpdk.org; tomaszx.kulasek@intel.com
> Cc: Zhang, Jerry; Wanghanlin
> Subject: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable
> using wrong index
>
...
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -1159,7 +1159,7 @@
> uint8_t i;
>
> for (i = 0; i < internals->active_slave_count; i++)
> - bond_mode_8023ad_activate_slave(bond_dev, i);
> + bond_mode_8023ad_activate_slave(bond_dev, internals-
> >active_slaves[i]);
>
> return 0;
> }
>
I don't think active_slaves is correct here. The slave is not yet active, so it may not be in that array yet.
Should we instead use internals->slaves[i].port_id?
next prev parent reply other threads:[~2017-11-23 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 7:15 Lilijun (Jerry)
2017-11-23 16:53 ` Kyle Larose [this message]
2017-11-23 22:56 ` Kyle Larose
2017-11-23 22:57 ` Kyle Larose
2017-12-12 15:58 ` Doherty, Declan
2017-12-15 20:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D76BBBCF97F57144BB5FCF08007244A7EDB5A19C@wtl-exchp-1.sandvine.com \
--to=klarose@sandvine.com \
--cc=dev@dpdk.org \
--cc=hanlin.wang@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jerry.zhang@intel.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).