From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6E91556A8
 for <dev@dpdk.org>; Fri, 30 Sep 2016 17:48:15 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 30 Sep 2016 08:48:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; d="scan'208";a="1038692496"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 30 Sep 2016 08:48:15 -0700
Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 30 Sep 2016 08:48:13 -0700
Received: from fmsmsx114.amr.corp.intel.com ([169.254.6.222]) by
 fmsmsx124.amr.corp.intel.com ([169.254.8.236]) with mapi id 14.03.0248.002;
 Fri, 30 Sep 2016 08:48:13 -0700
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>,
 "david.marchand@6wind.com" <david.marchand@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] log: do not drop debug logs at compile time
Thread-Index: AQHSD+4sqGLXH6F1Bkisr12qzYWg4qCSUNQAgABowoA=
Date: Fri, 30 Sep 2016 15:48:13 +0000
Message-ID: <D9218931-1F74-4467-9C72-D6F989762383@intel.com>
References: <1474011832-29987-1-git-send-email-olivier.matz@6wind.com>
 <2969629.OOuc7vtRSA@xps13>
In-Reply-To: <2969629.OOuc7vtRSA@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.254.43.126]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3018D79D4F551A449245B13A97EF8644@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] log: do not drop debug logs at compile time
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Sep 2016 15:48:15 -0000


Regards,
Keith

> On Sep 30, 2016, at 4:33 AM, Thomas Monjalon <thomas.monjalon@6wind.com> =
wrote:
>=20
> 2016-09-16 09:43, Olivier Matz:
>> Today, all logs whose level is lower than INFO are dropped at
>> compile-time. This prevents from enabling debug logs at runtime using
>> --log-level=3D8.
>>=20
>> The rationale was to remove debug logs from the data path at
>> compile-time, avoiding a test at run-time.
>>=20
>> This patch changes the behavior of RTE_LOG() to avoid the compile-time
>> optimization, and introduces the RTE_LOG_DP() macro that has the same
>> behavior than the previous RTE_LOG(), for the rare cases where debug
>> logs are in the data path.
>>=20
>> So it is now possible to enable debug logs at run-time by just
>> specifying --log-level=3D8. Some drivers still have special compile-time
>> options to enable more debug log. Maintainers may consider to
>> remove/reduce them.
>>=20
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>=20
> I think it is a good change.
> However I'm not sure we should take it for 16.11 as it was sent late and
> there is no review comment.
> It is neither really a fix nor really a feature.
> If there are some +1, and no opinions against, it will go in 16.11.
> Note that some drivers would need some changes to fully benefit of
> debug logs enabled at run-time.

Would this be easier to add a new LOG level instead say DEBUG_DATAPATH and =
then change the RTE_LOG to exclude the new log level?