From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF3F3A034F; Sat, 2 Nov 2019 07:56:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FCD81E557; Sat, 2 Nov 2019 07:56:03 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 38EBE1E554 for ; Sat, 2 Nov 2019 07:56:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2019 23:56:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,258,1569308400"; d="scan'208";a="375780465" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 01 Nov 2019 23:55:59 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 1 Nov 2019 23:55:59 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 1 Nov 2019 23:55:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Sat, 2 Nov 2019 14:55:57 +0800 From: "Liu, Yu Y" To: "Wang, Haiyue" , Thomas Monjalon CC: "dev@dpdk.org" , "arybchenko@solarflare.com" , "Yigit, Ferruh" , "jerinjacobk@gmail.com" , "Ye, Xiaolong" , "Kinsella, Ray" , "Sun, Chenmin" , Slava Ovsiienko , "Damjan Marion (damarion)" , "Liu, Yu Y" Thread-Topic: [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information Thread-Index: AQHVkT6krHqtknl/+kySOROxuO4ejKd3a+QQ Date: Sat, 2 Nov 2019 06:55:57 +0000 Message-ID: References: <20191031171139.105110-1-haiyue.wang@intel.com> <20191031171139.105110-3-haiyue.wang@intel.com> <20693558.VL3dRorq05@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTc1M2I3YTItMzZjZi00MGY2LTk2MTQtNGEyYzU1NzJlZDkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnNTK3FOWXJ2UHJoajBwakVnVjdNRkZaNHBHTnVNcVZta1pmdXliOGFTandtUzdNbndxMVNOUU1GajVSWnZNaiJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add Damjan from FD.io for awareness... Hi Thomas, Long time no see. Sorry I use outlook which is not friendly to community em= ail. >Anyway I will propose to replace this API in the next release. Will your plan be affected by API/ABI stable plan?=20 BTW, if you propose new change in next release, it will make DPDK consumer(= FD.io) to change again. So even if it is not affected to the API/ABI stable plan, do we still have = time to get a solution for everyone in DPDK 19.11 with your contribution/ac= celeration? > I suspect a real hidden issue in Intel CPUs that you try to mitigate. Please be rest assured it is not the case.=20 This request is just from one FD.io project internal bug " tx/rx burst func= tion is shown as nil" reported by Chenmin.=20 My understanding is DPDK behavior was taken as bug for someone in FD.io pro= ject and potentially will mislead other DPDK consumer.=20 Haiyue is working with Chenmin to address the issue and with your support i= t will be even better. Your support will be highly appreciated! Thanks & Regards, Yu Liu -----Original Message----- From: dev On Behalf Of Wang, Haiyue Sent: Saturday, November 2, 2019 1:30 PM To: Thomas Monjalon Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh ; jerinjacobk@gmail.com; Ye, Xiaolong ; Kins= ella, Ray ; Sun, Chenmin ; S= lava Ovsiienko Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting = burst mode information > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday, November 2, 2019 06:46 > To: Wang, Haiyue > Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh=20 > ; jerinjacobk@gmail.com; Ye, Xiaolong=20 > ; Kinsella, Ray ; Sun,=20 > Chenmin ; Slava Ovsiienko=20 > > Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting burst=20 > mode information >=20 > Thank you for trying to address comments done late. >=20 > 31/10/2019 18:11, Haiyue Wang: > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) > > +#define RTE_ETH_BURST_NEON (1ULL << 3) > > +#define RTE_ETH_BURST_SSE (1ULL << 4) > > +#define RTE_ETH_BURST_AVX2 (1ULL << 5) > > +#define RTE_ETH_BURST_AVX512 (1ULL << 6) >=20 > Of course, I still believe that giving a special treatment to vector=20 > instructions is wrong. > You did not justify why it needs to be defined in bits instead of=20 > string. I am not asking again because anyway you don't really reply. I=20 > think you are executing an order you received and I don't want to=20 > blame you more. > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > No need to reply to this comment. > Anyway I will propose to replace this API in the next release. Never mind, if this design is truly ugly, drop it all now. I also prefer to= do the best, that's why open source is amazing, thanks! ;-)