From: Ahmed Mansour <ahmed.mansour@nxp.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
"Verma, Shally" <Shally.Verma@cavium.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Challa, Mahipal" <Mahipal.Challa@cavium.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Roy Pledge <roy.pledge@nxp.com>,
Youri Querry <youri.querry_1@nxp.com>
Subject: Re: [dpdk-dev] [RFC v2] doc compression API for DPDK
Date: Thu, 1 Feb 2018 20:50:29 +0000 [thread overview]
Message-ID: <DB3PR0402MB38522F2167498D9FCDCA46E2E1FA0@DB3PR0402MB3852.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43589315AF3@IRSMSX101.ger.corp.intel.com>
>>> [Fiona] I propose if BFINAL bit is detected before end of input
>>> the decompression should stop. In this case consumed will be < src.length.
>>> produced will be < dst buffer size. Do we need an extra STATUS response?
>>> STATUS_BFINAL_DETECTED ?
>> [Shally] @fiona, I assume you mean here decompressor stop after processing Final block right?
> [Fiona] Yes.
>
> And if yes,
>> and if it can process that final block successfully/unsuccessfully, then status could simply be
>> SUCCESS/FAILED.
>> I don't see need of specific return code for this use case. Just to share, in past, we have practically run into
>> such cases with boost lib, and decompressor has simply worked this way.
> [Fiona] I'm ok with this.
>
>>> Only thing I don't like this is it can impact on performance, as normally
>>> we can just look for STATUS == SUCCESS. Anything else should be an exception.
>>> Now the application would have to check for SUCCESS || BFINAL_DETECTED every time.
>>> Do you have a suggestion on how we should handle this?
>>>
>
[Ahmed] This makes sense. So in all cases the PMD should assume that it
should stop as soon as a BFINAL is observed.
A question. What happens ins stateful vs stateless modes when
decompressing an op that encompasses multiple BFINALs. I assume the
caller in that case will use the consumed=x bytes to find out how far in
to the input is the end of the first stream and start from the next
byte. Is this correct?
next prev parent reply other threads:[~2018-02-01 20:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 11:45 Verma, Shally
2018-01-09 19:07 ` Ahmed Mansour
2018-01-10 12:55 ` Verma, Shally
2018-01-11 18:53 ` Trahe, Fiona
2018-01-12 13:49 ` Verma, Shally
2018-01-25 18:19 ` Ahmed Mansour
2018-01-29 12:47 ` Verma, Shally
2018-01-31 19:03 ` Trahe, Fiona
2018-02-01 5:40 ` Verma, Shally
2018-02-01 11:54 ` Trahe, Fiona
2018-02-01 20:50 ` Ahmed Mansour [this message]
2018-02-14 5:41 ` Verma, Shally
2018-02-14 16:54 ` Ahmed Mansour
2018-02-15 5:53 ` Verma, Shally
2018-02-15 17:20 ` Trahe, Fiona
2018-02-15 19:51 ` Ahmed Mansour
2018-02-16 11:11 ` Trahe, Fiona
2018-02-01 20:23 ` Ahmed Mansour
2018-02-14 7:41 ` Verma, Shally
2018-02-15 18:47 ` Trahe, Fiona
2018-02-15 21:09 ` Ahmed Mansour
2018-02-16 7:16 ` Verma, Shally
2018-02-16 13:04 ` Trahe, Fiona
2018-02-16 21:21 ` Ahmed Mansour
2018-02-20 9:58 ` Verma, Shally
2018-02-20 19:56 ` Ahmed Mansour
2018-02-21 14:35 ` Trahe, Fiona
2018-02-21 19:35 ` Ahmed Mansour
2018-02-22 4:47 ` Verma, Shally
2018-02-22 19:35 ` Ahmed Mansour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB38522F2167498D9FCDCA46E2E1FA0@DB3PR0402MB3852.eurprd04.prod.outlook.com \
--to=ahmed.mansour@nxp.com \
--cc=Ashish.Gupta@cavium.com \
--cc=Mahipal.Challa@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=Shally.Verma@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.pledge@nxp.com \
--cc=youri.querry_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).