From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0068.outbound.protection.outlook.com [104.47.2.68]) by dpdk.org (Postfix) with ESMTP id 5B5BAE6D for ; Fri, 7 Oct 2016 13:32:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gVS74kM6z5EMMznrS9JrfR5QJuTsx0S94Vi3dwFjZJI=; b=nV57x69nB+WNKnGX+7B00JCNUIIRXBLV7smDMkon83yXhdyfL5zxsWWcL9XOfy5pzeRRLZI6t9mReOt4y+HTIOD7JUEC/Z6if6RtSiyhb8AtWU3btPA5AYjtTn2Sed2HjU0vCxk3G3M49cqTbWfHcir6KAXQcspMIn3udXsVwFE= Received: from DB3PR04MB107.eurprd04.prod.outlook.com (10.242.129.20) by DB3PR04MB108.eurprd04.prod.outlook.com (10.242.129.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Fri, 7 Oct 2016 11:32:56 +0000 Received: from DB3PR04MB107.eurprd04.prod.outlook.com ([169.254.12.145]) by DB3PR04MB107.eurprd04.prod.outlook.com ([169.254.12.145]) with mapi id 15.01.0659.014; Fri, 7 Oct 2016 11:32:55 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" , "Doherty, Declan" CC: "Jain, Deepak K" , "Trahe, Fiona" , "Griffin, John" Thread-Topic: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address Thread-Index: AQHSF+XYhy3Qv8JECkqsbF4i0sMx8qCZduMAgAAuewCAA0aeAA== Date: Fri, 7 Oct 2016 11:32:55 +0000 Message-ID: References: <20160926163300.22990-1-akhil.goyal@nxp.com> <20160926163300.22990-3-akhil.goyal@nxp.com> <17b5c942-4b83-2ef0-a0f7-6755eaf73383@nxp.com> <80307F746F1522479831AB1253B7024E6E9988@IRSMSX102.ger.corp.intel.com> In-Reply-To: <80307F746F1522479831AB1253B7024E6E9988@IRSMSX102.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 8cc5391a-8915-4b23-e334-08d3eea5aed4 x-microsoft-exchange-diagnostics: 1; DB3PR04MB108; 6:hYgfK/hLH+vQLp/oLj7HP0tcBsDd8KuYBmzdmMKumwcUcj3oWbDZUWkcmL+n0N4kHUNFCwWxCcuCWzMNGb8i7PRSW7jbbh8FAaBM1KC3L6RxFs30AHEM0xENXV4eWC0Yb60Mekx+f+HAWqCNHgf/wXC8Y7HXPA3EePlR9NwuIxHnYrbsbvz9P33bLycqyXN7rh05DskMFoOM7Ui49lbq08oIpUp0We9szz5v3XzZUvJd8gG9Unvx0how+qH++xvYkVtHaUigoqZq/XkZUCkbMr8eqa3zEP+pSgVTrsE9fsS706vNZQxiStz1gC0N8aWKHtznFls6mmQpjgB5ZIUHwA==; 5:1dc2Zrfnve376vwcVvNUa+wFtNdM+enokwylmh2ejwjW+w0dIhK6Q8QOuneDUgF8+NPS7o9u80AhxfYfNtZP+diQamZcdRW2o7h03P0qv6YdSX82Ruk+Fpohlw5Z4Ztup1NLZD8bV5Jaobr1KrBjU3DzfFemSdm2uLLoiJDq5c0=; 24:MA06ENKOnLxTrlcoLaRkp94LP4HmMDXfYEMd4Piug2KsSWx4xTroYgkYoL+Y/yv2rZ9TNhcsvxaWqMQFfy1NSSA8PQiYBQPUUcaQQtjiv/A=; 7:OORJy0F+b6p50W8OV9xC7ATBmwnQfiGa/6Vu3XNnHtrww8GfNqrmbxLhDEmOUKQhZCtmOFSe4ALhkzkW4AmIDcbM3ZDvyezLNIyijvkfUJyZ9UkU+s+HhVg4yXSmxzrH1khOoXZA7rcLFzuNFLCkarpRQVVx+AG8seF+R7KmR/qFIbESgo6idtiC5Fq9zNeok+wDCaljpd9V+RUNDJAH48ShnONLT9DF/TIJFuuU5vbtB+oj1PoFmuAym5/xgyzcsWFAeIJBHwbBYpTECWEvlcOD7bo/HnmJhJZ0xlzqjLAaxCDUXEg+yKQaV3pVg8uq x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR04MB108; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:DB3PR04MB108; BCL:0; PCL:0; RULEID:; SRVR:DB3PR04MB108; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(55674003)(189002)(24454002)(18543002)(199003)(377454003)(2906002)(66066001)(3660700001)(105586002)(122556002)(4326007)(87936001)(106116001)(5001770100001)(106356001)(92566002)(3280700002)(5002640100001)(8936002)(86362001)(2900100001)(305945005)(7736002)(189998001)(7846002)(102836003)(6116002)(33656002)(93886004)(68736007)(2950100002)(3846002)(5660300001)(54356999)(76176999)(101416001)(2501003)(50986999)(586003)(76576001)(7696004)(10400500002)(74316002)(8676002)(81166006)(97736004)(19580405001)(19580395003)(81156014)(9686002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR04MB108; H:DB3PR04MB107.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2016 11:32:55.6673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR04MB108 Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 11:32:57 -0000 Hi Arek, Ok. I would rebase the patch. Regarding changes required to qat_snow3g, I do not have setup to test on qa= t and the hardware that I test, currently snow3g support is not added. I ca= n send the patches for snow3g at some later stage. Regards, Akhil -----Original Message----- From: Kusztal, ArkadiuszX [mailto:arkadiuszx.kusztal@intel.com]=20 Sent: Wednesday, October 05, 2016 2:57 PM To: Akhil Goyal ; dev@dpdk.org; Doherty, Declan Cc: Jain, Deepak K ; Trahe, Fiona ; Griffin, John Subject: RE: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should b= e stored at a DMAeble address Hi Akhil, Could you rebase it against newest next-crypto subtree, there were changes = with function names in the meantime. And to make it really consistent across all hw tests could you add this cha= nge to qat_snow3g too, for snow3g I assume aad need to obtain correct physi= cal address too. Regards, Arek > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, October 05, 2016 7:40 AM > To: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest=20 > should be stored at a DMAeble address >=20 > On 9/26/2016 10:03 PM, akhil.goyal@nxp.com wrote: > > From: Akhil Goyal > > > > For physical crypto devices, IV and digest are processed by the=20 > > crypto device which need the contents to be written on some DMA able ad= dress. > > > > So in order to do that, IV and digest are accomodated in the packet. > > > > Signed-off-by: Akhil Goyal > > --- > > app/test/test_cryptodev_perf.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cryptodev_perf.c=20 > > b/app/test/test_cryptodev_perf.c index 0ea7ec1..930d5b8 100644 > > --- a/app/test/test_cryptodev_perf.c > > +++ b/app/test/test_cryptodev_perf.c > > @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op > *op, struct rte_mbuf *m, > > op->sym->auth.aad.length =3D AES_CBC_CIPHER_IV_LENGTH; > > > > /* Cipher Parameters */ > > - op->sym->cipher.iv.data =3D aes_cbc_iv; > > + op->sym->cipher.iv.data =3D (uint8_t *)m->buf_addr + m->data_off; > > + op->sym->cipher.iv.phys_addr =3D rte_pktmbuf_mtophys(m); > > op->sym->cipher.iv.length =3D AES_CBC_CIPHER_IV_LENGTH; > > > > + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, > > + AES_CBC_CIPHER_IV_LENGTH); > > + > > /* Data lengths/offsets Parameters */ > > op->sym->auth.data.offset =3D 0; > > op->sym->auth.data.length =3D data_len; @@ -2468,7 +2472,9 @@=20 > > test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, > > rte_pktmbuf_free(mbufs[k]); > > return -1; > > } > > - > > + /* Make room for Digest and IV in mbuf */ > > + rte_pktmbuf_append(mbufs[i], digest_length); > > + rte_pktmbuf_prepend(mbufs[i], > AES_CBC_CIPHER_IV_LENGTH); > > } > > > > > > > Hi Declan, >=20 > Sorry I missed out copy your name in the TO list. Do we have some=20 > comments on this patch. >=20 > Regards, > Akhil