From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE7B7A046B for ; Wed, 24 Jul 2019 13:26:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEDF91C1CB; Wed, 24 Jul 2019 13:26:24 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by dpdk.org (Postfix) with ESMTP id 0FC7F1C1C6 for ; Wed, 24 Jul 2019 13:26:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjXHUYgXwEpK/qqYj8eIsaxvGTi+39Stg6g7+5js1LBRUNZDPK14eLJ4K7KR13Cdd3AMVT3H6lKmGK8mxUROocriSGtXdomf2jC8V36TuGdx4Y8iWceEFpgpjc0ciqB7277YT3p26yCjt9w3O9hQ6f2ehTeLAS7UaD+WNPSyYnTxbYSmiTaQ9flfhjZv4/3tPcvluPLypJI1Wq3NJJp5KpmHYESVF4kKq49ilUYYr2kM00TSBaHJZY7zbeS39pqKc76+wDDC3sow3gb3nlRh7Bd0xKl4JkznjiXLyTCsp5zJcP2llhzSmesKvUbGovu4hybrukhHUz0WKfV5wnV84g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Mg3TFCo9eIo5k8oBEqxS9HLi7CbdeNYpdunrlKDKNg=; b=f67u0tAwRRoYskuW93Q6o987+6DbMEnvyi7UDvhf5cDMkJA7V2hRc8Sbtk6rATV9QXrKxUXKtr5onIoK01DsLkWjMDep/1jck4lt71nmQbKT0lmRKjQs/hlShsmGzg03+/ZFNQcirCbrbZg9Cx84HAzQHrn/YOmiQqfd7CI2hqAOul1Y5DRZOn3UW1ebHC93X51PCvlMF6AKdMk3xKeWiKaAghfATklktVBTY8KDAq0WGG1//Vsi1i3oLiz+0FXSZJSMIBoofz/YAtPbVVZ3JKX3pk+VrhZBGshMOzW8MqKW3u8f0Xp69r23sVD6Vu3KxfWVJX95eaEUI/ByCwYiBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Mg3TFCo9eIo5k8oBEqxS9HLi7CbdeNYpdunrlKDKNg=; b=LkJC5n5tAyWDenK3D6Zh7BC4KJiC+Nb+DB1ZzvBv+TVBSubdSj2E/RlTqhDQ9c0KR8HHMraQLI49lOAVauxQmtV2Bh78xFzeTQDvIV1o/Auj/DyWuUACaj1VpZO6OhEshIqNMxid9SI40UYYwV77GdxVhUc/IXpnmxBr/7GqB5Q= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3946.eurprd05.prod.outlook.com (52.134.71.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.15; Wed, 24 Jul 2019 11:26:21 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 11:26:20 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release Thread-Index: AQHVQf757shEP5Hf7kCDPf3nc3iJuqbZoSQw Date: Wed, 24 Jul 2019 11:26:20 +0000 Message-ID: References: <47295025fefa62288f5c59919c7f4a17b9cd4e7f.1563958186.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53bc211a-01cc-48c4-6258-08d71029c0c3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3946; x-ms-traffictypediagnostic: DB3PR0502MB3946: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(13464003)(189003)(110136005)(74316002)(229853002)(5660300002)(186003)(54906003)(76116006)(316002)(6116002)(305945005)(486006)(71200400001)(71190400001)(6636002)(33656002)(52536014)(7736002)(3846002)(53546011)(6506007)(66446008)(64756008)(6246003)(81156014)(66946007)(26005)(4326008)(66476007)(256004)(8936002)(102836004)(25786009)(76176011)(53936002)(476003)(9686003)(99286004)(11346002)(7696005)(446003)(86362001)(6436002)(2906002)(14454004)(66066001)(55016002)(478600001)(68736007)(81166006)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3946; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dqaWO9fkuHDsg/D/F3eKlwyC6keN3S0yhorftB9O/eJN30VW/knYFeIMFTkmn1dfhrtPgIV+9Ykec9UmJi8Jo3RbOOcswFY0EYqKSNt2NZumXtO0Qa68PHOKKuPYpiTzvGtTXmkeItEBVM9jvqEcMfmiC5/0oNvAHcqs4hG/HiGfs5AYQDg8EllK2YC4idp8nxAjQnmHzKJ67DvKuBN9/7+2ET9XxIaUmsENImhlRq/wVmMgap6XnySjSGJbRyjCNgqJ1zraQ8jxR8pi7wCnrtwP/XDG5/gdXRj810qJ4MIJcxw15AqEi7qV1a7HbXDNdf9FxnHMBic/y8X2r6ZzwxsB41LqnHHVmbNId8iprJRcVYlPuIoduaDxEFwGgKuJD31bN9Wif3ukolpFa4I+PiuJiSSJJKg34Mh31fIQoFM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53bc211a-01cc-48c4-6258-08d71029c0c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 11:26:20.6610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3946 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, July 24, 2019 12:05 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue > release >=20 > Function mlx5_rxq_release() calls mlx5_release_dbr() to release the doorb= ell > allocated for this Rx queue. > This call is relevant only for Rx queue objects created using DevX API. >=20 > This patch adds the required check, to call mlx5_release_dbr() only when > relevant. > It also updates mlx5_release_dbr() to use the input offset correctly. >=20 > Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API") >=20 > --- > v3: Use adequate 'Fixes' reference. > --- >=20 > Signed-off-by: Dekel Peled > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5_rxq.c | 6 ++++-- drivers/net/mlx5/mlx5_rxtx.h | = 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 617f5ee..ad0883d 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1460,6 +1460,7 @@ struct mlx5_dev_spawn_data { > rte_free(page); > } else { > /* Mark in bitmap that this door-bell is not in use. */ > + offset /=3D MLX5_DBR_SIZE; > int i =3D offset / 64; > int j =3D offset % 64; >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index b225055..c9df8b0 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1242,6 +1242,7 @@ struct mlx5_rxq_obj * > goto error; > rxq_ctrl->dbr_offset =3D dbr_offset; > rxq_ctrl->dbr_umem_id =3D dbr_page->umem->umem_id; > + rxq_ctrl->dbr_umem_id_valid =3D 1; > rxq_data->rq_db =3D (uint32_t *)((uintptr_t)dbr_page->dbrs + > (uintptr_t)rxq_ctrl->dbr_offset); > } > @@ -1829,8 +1830,9 @@ struct mlx5_rxq_ctrl * > if (rxq_ctrl->obj && !mlx5_rxq_obj_release(rxq_ctrl->obj)) > rxq_ctrl->obj =3D NULL; > if (rte_atomic32_dec_and_test(&rxq_ctrl->refcnt)) { > - claim_zero(mlx5_release_dbr(dev, rxq_ctrl->dbr_umem_id, > - rxq_ctrl->dbr_offset)); > + if (rxq_ctrl->dbr_umem_id_valid) > + claim_zero(mlx5_release_dbr(dev, rxq_ctrl- > >dbr_umem_id, > + rxq_ctrl->dbr_offset)); > mlx5_mr_btree_free(&rxq_ctrl->rxq.mr_ctrl.cache_bh); > LIST_REMOVE(rxq_ctrl, next); > rte_free(rxq_ctrl); > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 928d6c3..60d871c 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -184,6 +184,7 @@ struct mlx5_rxq_ctrl { > struct mlx5_priv *priv; /* Back pointer to private data. */ > unsigned int socket; /* CPU socket ID for allocations. */ > unsigned int irq:1; /* Whether IRQ is enabled. */ > + unsigned int dbr_umem_id_valid:1; /* dbr_umem_id holds a valid > value. > +*/ > uint32_t flow_mark_n; /* Number of Mark/Flag flows using this > Queue. */ > uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels > counters. */ > uint32_t wqn; /* WQ number. */ > -- > 1.8.3.1 Patch applied to dpdk-next-net-mlx, Kindest regards, Raslan Darawsheh