From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F47CA04C1; Wed, 13 Nov 2019 12:40:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE96C2BA2; Wed, 13 Nov 2019 12:40:02 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40056.outbound.protection.outlook.com [40.107.4.56]) by dpdk.org (Postfix) with ESMTP id 3E4512B99 for ; Wed, 13 Nov 2019 12:40:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZBrO/3vvrMlM+GfSks5vNu3H3+27obYMsLbCp9Wz3OF3yRqmIIGJu0hyQ4+HwLy/GTEd9TECGJ7RtBwOCoZ5L2rip+uVesmxEjW2Mb6J2JsFiounVxC9pBtCA79jgOvTowmnh7AAgLxsQNvmm1MP/5BV44ta6uG5iPNPESshjZrJGyoHfW3A2aq8IkxNeDQbkjrkQpXex9mQVeqXG2QLSaUvjtQpYLnNCeMO7mVy0h+BdKZH543gqM1Ln/+RYvAUoZ7+2HVpZu2HT1AyD0/8oEK2IgIAW1hgZsdPwwLS/MZKjyTpm/iyhWwGPWfIoGzhs0lRwaalIRUyydQcPjWG5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=55j3FleWeXXl2ZWmkbl36Kq3z+ke6L4vSIRhdWiFlLc=; b=kNNAshmlrJ88p/VEDrhctqVrFTwTJkDGpXatCVaxO9n6yIqzXNZts83PpOy8nvbeZqWfXmyWgF1aHKqH1tD4aayAQ4+00uWsSLf0xbrZ1qo0AkSDdZ+fg94fynkPXgbtzp+RT6Cl2pC27EhK5ROrywbunWA+JkY2gqxElVopnVSGtKSRQpoNjZ2okUoKGtoOrUPbg6CJsZTI9jPNog4VTeEQZ61YjaUXKRO3+47QH5EdOyAF1wtbvJkcnEWi/xYRsmKPVm3Lp72su5p5C9PKbLPu1gyL06yh01HjxL2wxDzNd3SLYz9kwXuE9440asne4P768Z2DAv18O4CH9dRNUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=55j3FleWeXXl2ZWmkbl36Kq3z+ke6L4vSIRhdWiFlLc=; b=IG0bt4I1AcM7NbyJ90sE6vdm+r+ly9/ua5LYbRhbCwkxpiPlYfNsC57NmrTra0Q2/BGYwPx6rd05ulTH3KZzm9XPMqGUs3Ox9d1WLmorftcDaGkpj5xkmci1HLEZtmJP9p5Ymo5OCDkYMEIVO8uptXkDGyLUvDipHf5AbS/jobQ= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Wed, 13 Nov 2019 11:40:00 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Wed, 13 Nov 2019 11:40:00 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue type Thread-Index: AQHVmJzwki9z8xHvBkO5tOuwBAfM+qeI/N9g Date: Wed, 13 Nov 2019 11:39:59 +0000 Message-ID: References: <237a2d46d825dc33a75a8c5aee27ed5d99fb68d6.1573482597.git.dekelp@mellanox.com> In-Reply-To: <237a2d46d825dc33a75a8c5aee27ed5d99fb68d6.1573482597.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c661fab2-edd6-4f68-5260-08d7682e373a x-ms-traffictypediagnostic: DB3PR0502MB4058:|DB3PR0502MB4058: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(13464003)(199004)(189003)(6506007)(76116006)(33656002)(2906002)(86362001)(305945005)(229853002)(99286004)(74316002)(6116002)(54906003)(7736002)(316002)(6436002)(3846002)(52536014)(81166006)(110136005)(53546011)(478600001)(76176011)(102836004)(6636002)(14444005)(256004)(66066001)(7696005)(486006)(66556008)(26005)(25786009)(71200400001)(71190400001)(6246003)(14454004)(81156014)(66446008)(55016002)(66946007)(8936002)(9686003)(64756008)(4326008)(11346002)(446003)(8676002)(186003)(5660300002)(476003)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z9ceKEpfQZT0FCX9LOV0gJgdDgMP7DmSTA27I83ENZGKIbL+s/3dxEfxvC7I+fxMaFSXOTLVh+wz9ELqt9qn9/fyL0etzxzxQr5Aol8kJLtxpb1SiPX6K4bWmaNoIG0vsmYCUAxzJGJDy2VPBTTJGhj7SkrR1XWt7kEamUqveq1Ob8maFUsCf01pnE4v12tRqf5Vpbr51/Wy28k89jipgh1TMPpRANXhCCAssoec3NzHb4utsPxk7RPVJCYiVBdtzUqX/TsyY+qKilSrQ7VcFmISZD7jex0KX5PsdZGjptClnUxYTB5qRY5Bhw0CaeOWCWPmx8L005XY4AkdQE/YFzKFmt9Z5vcILeVeOzkdmLD6/3L5pyRtS1tegk+z7pNMXHBIiqt7RzhaLgpOPJujkfZ5gMcs6SohDVaywAjhSHySHNNCli6JrkjKAvgSU0RO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c661fab2-edd6-4f68-5260-08d7682e373a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 11:39:59.8649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u/PUcCVCIKZL4pSQH6hA1f4HvGzV3J7ObRYmpqH7DPPdRiOXkRmEEIt7UC1IhYtOC338tV4jWEyzezBpVtZY6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, November 11, 2019 4:33 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue ty= pe >=20 > Function mlx5_rxq_get_type() uses the input queue index, without > checking it, as index to the Rx queues array. > If this value is too high, it will result in pointer to memory out > of Rx queues array bounds. >=20 > This patch adds check of the input queue index, to verify it is valid. >=20 > Fixes: 09775c04aace ("net/mlx5: split hairpin flows") > Cc: orika@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_rxq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 24d0eaa..f9b36ed 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -2113,7 +2113,7 @@ enum mlx5_rxq_type > struct mlx5_priv *priv =3D dev->data->dev_private; > struct mlx5_rxq_ctrl *rxq_ctrl =3D NULL; >=20 > - if ((*priv->rxqs)[idx]) { > + if (idx < priv->rxqs_n && (*priv->rxqs)[idx]) { > rxq_ctrl =3D container_of((*priv->rxqs)[idx], > struct mlx5_rxq_ctrl, > rxq); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh