* [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson
@ 2019-10-02 14:24 David Marchand
2019-10-02 15:17 ` Thomas Monjalon
2019-10-20 7:53 ` Raslan Darawsheh
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2019-10-02 14:24 UTC (permalink / raw)
To: dev; +Cc: stable, Matan Azrad, Shahaf Shuler
There is no dependency on this library for mlx4.
Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/mlx4/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index efee457..e6795ee 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -21,7 +21,7 @@ if pmd_dlopen
]
endif
-libnames = [ 'mnl', 'mlx4', 'ibverbs' ]
+libnames = [ 'mlx4', 'ibverbs' ]
libs = []
foreach libname:libnames
lib = dependency('lib' + libname, required:false)
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson
2019-10-02 14:24 [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson David Marchand
@ 2019-10-02 15:17 ` Thomas Monjalon
2019-10-02 15:23 ` David Marchand
2019-10-20 7:53 ` Raslan Darawsheh
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-10-02 15:17 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Matan Azrad, Shahaf Shuler
02/10/2019 16:24, David Marchand:
> There is no dependency on this library for mlx4.
>
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org
It seems this dependency was added by mistake.
It was used in mlx5 for TC Flower, and has been dropped recently.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson
2019-10-02 15:17 ` Thomas Monjalon
@ 2019-10-02 15:23 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2019-10-02 15:23 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, dpdk stable, Matan Azrad, Shahaf Shuler
On Wed, Oct 2, 2019 at 5:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 02/10/2019 16:24, David Marchand:
> > There is no dependency on this library for mlx4.
> >
> > Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> > Cc: stable@dpdk.org
>
> It seems this dependency was added by mistake.
> It was used in mlx5 for TC Flower, and has been dropped recently.
Yes, most likely a copy/paste from mlx5 at the time of 1dd7c7e38c19.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson
2019-10-02 14:24 [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson David Marchand
2019-10-02 15:17 ` Thomas Monjalon
@ 2019-10-20 7:53 ` Raslan Darawsheh
1 sibling, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2019-10-20 7:53 UTC (permalink / raw)
To: David Marchand, dev; +Cc: stable, Matan Azrad, Shahaf Shuler
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Wednesday, October 2, 2019 5:24 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in
> meson
>
> There is no dependency on this library for mlx4.
>
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-20 7:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 14:24 [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in meson David Marchand
2019-10-02 15:17 ` Thomas Monjalon
2019-10-02 15:23 ` David Marchand
2019-10-20 7:53 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).