Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant define of LRO masks

[Raslan Darawsheh <rasland@mellanox.com>]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, December 18, 2019 9:50 AM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: remove redundant define of LRO
> masks
> 
> Bit-masks MLX5_FLOW_LAYER_IPV4_LRO and
> MLX5_FLOW_LAYER_IPV6_LRO were
> added during work on LRO.
> They are not used anywhere in current code.
> 
> This patch removes these redundant definitions.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> ---
>  drivers/net/mlx5/mlx5_flow.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index 3fff5dd..08e223e 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -131,12 +131,6 @@ enum mlx5_feature_name {
>  	(MLX5_FLOW_LAYER_OUTER_L2 | MLX5_FLOW_LAYER_OUTER_L3 |
> \
>  	 MLX5_FLOW_LAYER_OUTER_L4)
> 
> -/* LRO support mask, i.e. flow contains IPv4/IPv6 and TCP. */
> -#define MLX5_FLOW_LAYER_IPV4_LRO \
> -	(MLX5_FLOW_LAYER_OUTER_L3_IPV4 |
> MLX5_FLOW_LAYER_OUTER_L4_TCP)
> -#define MLX5_FLOW_LAYER_IPV6_LRO \
> -	(MLX5_FLOW_LAYER_OUTER_L3_IPV6 |
> MLX5_FLOW_LAYER_OUTER_L4_TCP)
> -
>  /* Tunnel Masks. */
>  #define MLX5_FLOW_LAYER_TUNNEL \
>  	(MLX5_FLOW_LAYER_VXLAN | MLX5_FLOW_LAYER_VXLAN_GPE | \
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh