From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Yongseok Koh <yskoh@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: cache the associated network device ifindex
Date: Mon, 22 Jul 2019 08:43:29 +0000 [thread overview]
Message-ID: <DB3PR0502MB39642CA7DAC4605DF68A0CE1C2C40@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1563721001-3730-1-git-send-email-viacheslavo@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
> Sent: Sunday, July 21, 2019 5:57 PM
> To: dev@dpdk.org
> Cc: Yongseok Koh <yskoh@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; stephen@networkplumber.org
> Subject: [dpdk-dev] [PATCH v2 0/2] net/mlx5: cache the associated network
> device ifindex
>
> In mlx5 PMD the associated device index is retrieved via Netlink request to
> underlying Infiniband device driver. This network device index is permanent
> throughout the lifetime of device. We do not spawn the rte_eth_dev ports
> without associated network device, and if network device is being unbound
> we get the remove notification event message and rte_eth_dev port is also
> detached. So, we may store the ifindex in mlx5_device_spawn() routine at
> rte_eth_dev port creation and initialization time and use the cached
> value further instead of doing actual Netlink request.
>
> This approach allows the query API routines like mlx5_link_update to be
> thread-safe due to Netlink request elimination. mlx5_link_update() may
> be called in asynchronous event handler concurrently and it may cause
> application hang.
>
> This patch extends and updates the [1].
>
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F56417%2F&data=02%7C01%7Crasland%40mell
> anox.com%7C3c155fb435384529783608d70debb168%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C636993178256642102&sdata=GNj8%2B79
> %2FoBQzu7esmy4wN4e6WC7RHREDbV4OZTq6SOA%3D&reserved=0
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>
> ---
Series applied to next-net-mlx
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2019-07-22 8:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 20:54 [dpdk-dev] [PATCH 0/2] fix dev_info_get in mlx secondary process Stephen Hemminger
2019-07-12 20:54 ` [dpdk-dev] [PATCH 1/2] net/mlx4: fix crash in dev_info_get in " Stephen Hemminger
2019-07-30 13:48 ` Matan Azrad
2019-08-04 6:57 ` Raslan Darawsheh
2019-08-05 7:42 ` Raslan Darawsheh
2019-07-12 20:54 ` [dpdk-dev] [PATCH 2/2] net/mlx5: " Stephen Hemminger
2019-07-15 7:41 ` Slava Ovsiienko
2019-07-19 5:31 ` [dpdk-dev] [PATCH 0/2] net/mlx5: cache the associated network device ifindex Viacheslav Ovsiienko
2019-07-19 5:31 ` [dpdk-dev] [PATCH 1/2] " Viacheslav Ovsiienko
2019-07-19 16:15 ` Stephen Hemminger
2019-07-19 16:41 ` Slava Ovsiienko
2019-07-19 18:03 ` Stephen Hemminger
2019-07-19 18:31 ` Slava Ovsiienko
2019-07-19 5:31 ` [dpdk-dev] [PATCH 2/2] Revert "net/mlx5: fix master device Netlink socket sharing" Viacheslav Ovsiienko
2019-07-19 16:16 ` Stephen Hemminger
2019-07-19 16:21 ` Slava Ovsiienko
2019-07-19 16:23 ` Stephen Hemminger
2019-07-21 14:56 ` [dpdk-dev] [PATCH v2 0/2] net/mlx5: cache the associated network device ifindex Viacheslav Ovsiienko
2019-07-21 14:56 ` [dpdk-dev] [PATCH v2 1/2] " Viacheslav Ovsiienko
2019-07-22 5:52 ` Yongseok Koh
2019-07-21 14:56 ` [dpdk-dev] [PATCH v2 2/2] Revert "net/mlx5: fix master device Netlink socket sharing" Viacheslav Ovsiienko
2019-07-22 5:53 ` Yongseok Koh
2019-07-22 8:43 ` Raslan Darawsheh [this message]
2019-07-31 7:36 ` [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process Raslan Darawsheh
2019-07-31 13:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB39642CA7DAC4605DF68A0CE1C2C40@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).