DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
	dev <dev@dpdk.org>
Cc: Luca Boccassi <bluca@debian.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	Frank Heimes <frank.heimes@canonical.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64
Date: Mon, 2 Sep 2019 10:12:17 +0000	[thread overview]
Message-ID: <DB3PR0502MB39642FA8EA04D46E2D45C796C2BE0@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190813112843.27072-2-christian.ehrhardt@canonical.com>

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Christian Ehrhardt
> Sent: Tuesday, August 13, 2019 2:29 PM
> To: dev <dev@dpdk.org>
> Cc: Luca Boccassi <bluca@debian.org>; Thomas Monjalon
> <thomas@monjalon.net>; Frank Heimes <frank.heimes@canonical.com>;
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Subject: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64
> 
> The AltiVec header file breaks boolean type:
> 
> error: incompatible types when initializing type '__vector _bool int' {aka
> '_vector(4) __bool int'} using type 'int'
> 
> If __APPLE_ALTIVEC__ is defined, then bool type is redefined and conflicts
> with stdbool.h.
> 
> There is no good solution to fix it for the whole project without breaking
> something else, so a workaround is inserted in mlx5 PMD.
> This workaround is not compatible with C++ but there is no C++ in DPDK.
> 
> Related to:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dp
> dk.org%2Fdpdk%2Fcommit%2F%3Fid%3D725f5dd0bfb50192a2d2341d4cc690
> 84c2c4e03d&amp;data=02%7C01%7Crasland%40mellanox.com%7C4617eec7
> ac6c4eb7bf7408d71fe17042%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%
> 7C0%7C637012925439283556&amp;sdata=6tZDB%2F7%2Bq%2Fs%2FDsZksg6Z
> sAGTZcbufps84bT6wBe6nXs%3D&amp;reserved=0
> 
> Change-Id: Iceb058c07086def4176c5ab199ca4dd5018d0340
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)


Patch applied to next-net-mlx after small change in the commit log:
	1- removed Change ID.
	2- replaced related to link with the SHA of the commit only

Kindest regards,
Raslan Darawsheh

      parent reply	other threads:[~2019-09-02 10:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 11:28 [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08 Christian Ehrhardt
2019-08-13 11:28 ` [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Christian Ehrhardt
2019-08-13 23:49   ` David Christensen
2019-08-28 12:30     ` Christian Ehrhardt
2019-08-29 17:06       ` David Christensen
2019-09-01 13:52   ` Matan Azrad
2019-09-02 10:12   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0502MB39642FA8EA04D46E2D45C796C2BE0@DB3PR0502MB3964.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=frank.heimes@canonical.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).