From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 205ECA00E6 for ; Mon, 5 Aug 2019 17:16:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EF081BD52; Mon, 5 Aug 2019 17:16:34 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10061.outbound.protection.outlook.com [40.107.1.61]) by dpdk.org (Postfix) with ESMTP id 573CF1BA5E for ; Mon, 5 Aug 2019 17:16:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOyMkOdBt/JHb8AgGD47NlpuGLpgaAvZd7GOoH5ZxHyNrmZTg0gGTi01m3WvrwGU2YRunnPTzLsY0YZcESUnkiONfbsjEeDFVZz36Hdxxf1WvBi6m23krSwJXtwh385MFEymz9fzqMgJzuB0yiIjMPdwLhpwyAtSEyWXbFrKjFum2Rl+kWhKT96tQXyr6oO1pFoay+0S4YaKAKln3wRs/2RyOIc6pVE1PPMqinqjl+i9oe0XI+sNBJdCmhx72fN0zBG+9T4lPIDE3ANNauSOliu/sKw4SbDqSEHlUciI41WEGOMAbDYjh5A2i2h1hWp27b/trlU+e7QonJgfvl5u2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NyVW7KA738dkzLtu7DOugI+lQjawyKREVc4ynOeFVuU=; b=myLnTuMPHAci4bqM6Vg68Xa2TtSiUVOP1j+bk/GwRo05PuEDs6bkJR85SS6Ro/4ilKZOGMZpFfzUfbk0kKHmFerN0wuUqYnTjz9iDLIQ7qtHKjb/A9FLBM1N1HlNi3pJIbVLrRB2Q46dM6ooqfyg+P+CDQG1vFjglgHOpwlO2h6kBsyNXI6WovF1SZogq2lmHkR5g9PJYsbGtIWIMi0CIImk0EAdzB0UkjePw9A4kP+VFXMTFYgUL3i3Y4FSExlLFdKWhtWy5JgcWu1xXcqrmiiON2hyulBdm+SZQQzvnSYak9BGfob6PfeOVhVEDDv3EthAvB5OsLbUnVCmUZLmlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NyVW7KA738dkzLtu7DOugI+lQjawyKREVc4ynOeFVuU=; b=aGv87NuATZzMbPwdeJF/9ZUVyGmLy7B8N+fq/Y44w+BK8fAUcWifps3x40rfRuGwEf3+i2T3qnaI9q9L1kT3FXgBbjWy/O5RIRhKbyGV34GxQ6Qa3wMAihjje08hoeBLUrgypHGuXvC+t6Db1qKFbCHmj71vjrEJze9JU2nnibc= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4043.eurprd05.prod.outlook.com (52.134.68.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Mon, 5 Aug 2019 15:16:30 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 15:16:30 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" , Eli Britstein Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop Thread-Index: AQHVS4RTON7QawThd0qGA747W9rV8absqmOg Date: Mon, 5 Aug 2019 15:16:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8480a68e-5dca-4a7b-9334-08d719b7e4f7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4043; x-ms-traffictypediagnostic: DB3PR0502MB4043: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(39860400002)(376002)(366004)(189003)(199004)(13464003)(102836004)(68736007)(6246003)(5660300002)(107886003)(33656002)(14454004)(81166006)(81156014)(54906003)(4326008)(2906002)(110136005)(8676002)(316002)(64756008)(478600001)(3846002)(66476007)(8936002)(66946007)(229853002)(25786009)(14444005)(6116002)(305945005)(7736002)(486006)(446003)(11346002)(476003)(256004)(99286004)(66556008)(74316002)(76116006)(52536014)(76176011)(71200400001)(71190400001)(66446008)(186003)(6636002)(26005)(66066001)(53546011)(6506007)(9686003)(6436002)(53936002)(55016002)(86362001)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4043; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HZGLQi0q6OennfF6uBS94Ach5//jBdGL3sk+aT6AfBI2Jfu1O6ntvjoNtx4BO1Qi404U1X7kQo0gWBjJybllB28d9i6mx6tC5owEu6szACpbELF/SRhHra1KhX2dsLRA+7b6MAiLHj0xoPXsih28koPjem4L/dJQEEHwuDyQhxAvp3SxG/TqNrWTTjYC0FWeFLorsVS8vGqpHRIf/D9PUF0KSR1nqNCKYamVwm8ejH2N4EEbZSK5kWIh/oUl+AjK7Oj4X2X+tgWobjbbK+oji3aQwpBT62FZwhSgTB3m2d8JwTyHxXdyY91ry5MIZN6PqqD3UpP9cf0BZBNqX4h6i4GzACsitTCdY5h12E0b+uH02hYskAi7ZhAGCva9IPrC587fqomwLPVBmrB/Q/12SODndvKsWTww0zYE3yYN3Rw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8480a68e-5dca-4a7b-9334-08d719b7e4f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 15:16:30.5635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4043 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, August 5, 2019 2:51 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; Eli Britstein > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop >=20 > Function flow_dv_zero_encap_udp_csum() uses a while loop to iterate > over vlan items in flow rule. > Pointer next_hdr is incremented to the next item before it is used, > so the first item is skipped. >=20 > This patch moves the incrementing of next_hdr to the correct place. >=20 > Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation") > Cc: elibr@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 536059d..6c58634 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1504,9 +1504,9 @@ struct field_modify_info modify_tcp[] =3D { >=20 > /* VLAN skipping */ > while (proto =3D=3D RTE_ETHER_TYPE_VLAN || proto =3D=3D > RTE_ETHER_TYPE_QINQ) { > - next_hdr +=3D sizeof(struct rte_vlan_hdr); > vlan =3D (struct rte_vlan_hdr *)next_hdr; > proto =3D RTE_BE16(vlan->eth_proto); > + next_hdr +=3D sizeof(struct rte_vlan_hdr); > } >=20 > /* HW calculates IPv4 csum. no need to proceed */ > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh