From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4A87A2F6B for ; Tue, 8 Oct 2019 13:53:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A671A1C02D; Tue, 8 Oct 2019 13:53:09 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49]) by dpdk.org (Postfix) with ESMTP id BA7371BFC0; Tue, 8 Oct 2019 13:53:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWFbh0M5Y81c/1TZWuPlvNlRxPqXG3zxahEI01FkPqTh8aDtZqhQKY2/nLzMx7tteENs8nJeVhLWyWm/pGe8Kg9VgI1LbqgfbBalDsJvU7Bfu1s2Z8GaVHEqwTeGwStLmIsnGbiDsCkbdo6OQ//hr+2/t/F5BAYxvsVUJx+5eb08aAymXKjiRoVN0sEcXKDy97ySnOluA+bCQWf+vggvXCUzl9nNmq2hv4FlK5zi5TGV5Cu8IeRTg4mDY9yGigCo4bCNMaggRgV3/bvCpFTjDSE+u2PUVGZokcOx8n4ti208DDhDs7vE1GtPq4e4o5ZBkLP3/2D7bjLkQHwPJVfYjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ohRoy9GD+bGVxpgGjEtfDjQqVyUjV2wNZlKdWPqvtQ=; b=IUFr5et/aHg4sDPoATiwAOdb9HOOF4GdUJkEZ7OIIvUUv2fiK+tHU4EPDD/5Ct++8DoqSbOCZz4u4anOjTKNnRwrdH/usiVCg/rI6ka8H1tk/WhD3YJGB7yWhMdQ7pZ0voS28L5rP58Ckb4xhaFir8KSdFGfG3Ei+fkIkRflG36VC/HR7Fgr1wS1rwN1vxEc8qZaGe3669lYVh4qQ7bBS2ooJFzxI5Za4C6/X5+9F4oXPdYGNvLvMDhjBORXasLKcCySMcUVwbjTzAlt8Tg9lwmWGfDpKhgicTQurTH0q4xAY5oKdV6W4M4/ZEkoJnkAatx3YzSa6AbQYa+NB2hWJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ohRoy9GD+bGVxpgGjEtfDjQqVyUjV2wNZlKdWPqvtQ=; b=ZVAZv0jIZx/mHrhyXTcRBBl9vqVqu31qqaURm99YUqrjGStSAk9SxnuJGw42Hnev/6fwZOXOzoc9KkCRUSCl3NwnZsUsBHzYe3haEAMuqGA7bWvrlXVzEeUyY/3qxOqAhWmNiKwjUWNxdy3x/NOUmRdS0V6+7rU8DX6LJURWUXk= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4011.eurprd05.prod.outlook.com (52.134.68.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.17; Tue, 8 Oct 2019 11:53:06 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b%5]) with mapi id 15.20.2327.026; Tue, 8 Oct 2019 11:53:06 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , Ori Kam , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order Thread-Index: AQHVaH1yM40QI6w+EECoMx6cNGa2AadQzNMg Date: Tue, 8 Oct 2019 11:53:06 +0000 Message-ID: References: <272e27d0200f367e94ceeed7fae80655213f5c27.1568179407.git.jackmin@mellanox.com> <099aca2cedb8654adc85923e5497ff8df1003bc5.1568191352.git.jackmin@mellanox.com> In-Reply-To: <099aca2cedb8654adc85923e5497ff8df1003bc5.1568191352.git.jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7d237d9-6a6a-484d-cbda-08d74be6151c x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DB3PR0502MB4011:|DB3PR0502MB4011: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1060; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(366004)(396003)(376002)(136003)(189003)(199004)(13464003)(25786009)(74316002)(55016002)(486006)(446003)(86362001)(305945005)(7736002)(66556008)(11346002)(33656002)(186003)(6246003)(71190400001)(99286004)(4326008)(256004)(14444005)(66446008)(6506007)(450100002)(7696005)(102836004)(478600001)(76176011)(476003)(53546011)(14454004)(66946007)(26005)(8936002)(3846002)(81156014)(229853002)(6116002)(8676002)(9686003)(81166006)(316002)(5660300002)(4744005)(71200400001)(54906003)(76116006)(6636002)(66476007)(6436002)(66066001)(52536014)(64756008)(110136005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4011; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CL9+59VLxvQsSJrAkuGoh3vr0mG1AJlHvD0WiPXKoJDVNyUdQJrscWHCrDE9x4UQXSLch5IM3jwzNLFzXPXTJfbm3CXhmANSQlbD6Ldge4NbTjBNZa9E2XxHjLqeaAlHxkcTNaXNdWVE8SO89br/Npbfh5DdNvNksqz7Rhi0cbtXFIm8+VQrRnkYZU2a5ngazRQsmjgEgwExssWq15AF4ATDpIeMIVSjxBep7vy7XD9XArf1L+J05IjSjQsunRjPXi+f59AFZ5d6q8wqtC0rT8hmPF05CWaDMJVtDN7EE9DoTOGy4tCGDTtAV8kbq2JtcsKvCFTcmtjs/zbBJKJ34q3fbioc4UyG0LmsOQy+dCjScnH1BOBmoIhOHZDv6psDyUequysEh0DvmdMEJKhCKwx3rMe7VHhPL7EYA0pTcwA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7d237d9-6a6a-484d-cbda-08d74be6151c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 11:53:06.3655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vher+tadkwQUfArKqJlbi83LubS95/+DcRDlqm2eo+lnRsBSk1h6fm2Ap7ixWKzCAh648i/4m94RVmu+p3vf0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4011 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, September 11, 2019 11:46 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order >=20 > The Item order validation between L2 and L3 is missing, which leading to > the following flow rule is accepted: >=20 > testpmd> flow create 0 ingress pattern ipv4 / eth / end actions drop / > end >=20 > Only the outer L3 layer should check whether the L2 layer is present, > because the L3 layer could directly follow the tunnel layer > without L2 layer. >=20 > Meanwhile inner L2 layer should check whether there is inner L3 layer > before it. >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyu Min > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh