From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55D78A04AD; Thu, 7 Nov 2019 23:46:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59EDB1BFB4; Thu, 7 Nov 2019 23:46:19 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130077.outbound.protection.outlook.com [40.107.13.77]) by dpdk.org (Postfix) with ESMTP id 613831BF80 for ; Thu, 7 Nov 2019 23:46:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aO2EofyauxRAq9llv/c06bA6mWHTOHF1wObfSKI705EwqDHSFrProw+QiEksXnFXl6bBRHt6/ljvQ1ea58O1DNFTLmIAp9MdaY8M1KS4DM2xzZev+Md4yi6m8E+vCk1tBSDbMBt3t7ixRf12iT3AeMhCHuFKoENE6sOcs8NtP1RWA7TaslgDhYqGwBYzGAVtHu/5DLY+QbB5C2shd6baiWrEis0hxGgHX8yyEtz9WjJ8vJ8PhB4nyfwTHAcb1rJuXQ1S9EY06QqAzZZ9dHR5WLr1jw6upqSdaq47XMYRGItz3Dwb9l9dsOKGz+9kJo3K1AJ58T1v1gThQM/l0LBztg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fcij5FwvYwJQ0pCKrOhnu+L6KJbB6wBN+rooiIaJFMs=; b=AohtpXTxTDTOMezV3MfK/vSfkvL8YTZLlaR3RblKTxJ3oiU8ZkuFJL6qOUripO8PnYvKeKjV2/y3pc3kmZD2G7ta1uW+vFxy2aZW+2eTy48mefbkUFjR1DtuzIhbdqrktHnLfHjcPsQhIOxJCvB/60tr457EcLIqRHz27WJOVaRVhyWUBim1WFTRxwqxWz0J+hF4e+O+Pz10ofxHD1fsYLgrGy4PSpxCOAMWsVq16APZH2dAgymOIZMl7ogY1VxruvF4oEOB/q+oUXlDTcIauKG07nUBff1l8oIOicw4cEi+VZeesEI9zCVRHpAl047Z/CkvOGMDp+cQXi/3BvKY9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fcij5FwvYwJQ0pCKrOhnu+L6KJbB6wBN+rooiIaJFMs=; b=g2VaKP88//4nOI3jFltaSzZI2ai3FZq8bA4QKAuaZROvJuHLXp7yqqiCsvElLtyTsJQSWkbSIiejcJ6cnUAer+pX7oulXdl5uP+ZyubfQMJ2fGOlYFSmr5Gf3Gc60e5mAhQJ/tpxYVHsbPcm0vLBDTlFsH+KBP4y5cdA7Uf7TLY= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4076.eurprd05.prod.outlook.com (52.134.66.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.23; Thu, 7 Nov 2019 22:46:14 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 22:46:14 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Stephen Hemminger CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list Thread-Index: AQHVlKNCCzHls1a+Ik6sGBM57Fz096d/b+wAgADgzhA= Date: Thu, 7 Nov 2019 22:46:14 +0000 Message-ID: References: <1572967680-93338-1-git-send-email-bingz@mellanox.com> <1573045676-175122-1-git-send-email-bingz@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.230.21] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 920a6d41-8fa7-4dd4-f19b-08d763d44b60 x-ms-traffictypediagnostic: DB3PR0502MB4076:|DB3PR0502MB4076: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:199; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(51874003)(13464003)(199004)(189003)(64756008)(14454004)(110136005)(54906003)(229853002)(14444005)(256004)(25786009)(6116002)(26005)(102836004)(5660300002)(4326008)(6246003)(3846002)(186003)(52536014)(71190400001)(71200400001)(9686003)(30864003)(66066001)(8676002)(81156014)(81166006)(478600001)(11346002)(76176011)(446003)(2906002)(74316002)(76116006)(53546011)(33656002)(86362001)(305945005)(7736002)(66946007)(6506007)(8936002)(486006)(316002)(99286004)(7696005)(66476007)(55016002)(6436002)(476003)(66446008)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4076; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2LXLi3ffSB6Oo5blnVqxQb25TE9G/Gm4D4gEK+ynjK6KO9j4CyhZCF/Qtp9uwoAoRCnjaXEPljow02S6L0zo9emLLdhsfZ2cufDucOjJM+B6Eu61HYHYWH6pHCSwwgbrbD2aTKt+Sq4ujkgG4sTtHLGe9vMTWQGu5hUz92O6Ycv+YaLXlSpMxlsYofbV7h/KAT3QkqT6hImHrSdFwOHAwpaq582cFKN6d+PdYNIVA5jtibclhjb5kKTxQMYzgWVXpNIOC8ea3mbMLXcthjDxspNH4X9L+KutE1XH07XSAzt0JEoL+ynKPDIQMSSAS3tmGrc3hQu+l8iW99uoz/txTgTDwdfgfUfDMh18ovBGkhPpXpLjp5pXb4Rc68AmhGAKE3ZkbQ/6nWt9EzyqFecPDOjUEsu11F6wrI+RfwBHlNWM6aXFlGDZYbWSRuDd3X/7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 920a6d41-8fa7-4dd4-f19b-08d763d44b60 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 22:46:14.3566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TyUTko713tMRk7DigWoPtSC7veACDc6r0uBCeBZA5ldihM/hUgSQkoo4yYYIuHlqjsU8IR0gRybtuHY+v65wSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4076 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Thursday, November 7, 2019 11:21 AM > To: Bing Zhao ; Slava Ovsiienko > ; Stephen Hemminger > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list >=20 > Adding Stephen >=20 > Hi Stephen, would you please help to review the V2? > Many thanks in advance. :-) >=20 > BR. Bing >=20 > > -----Original Message----- > > From: dev On Behalf Of Bing Zhao > > Sent: Wednesday, November 6, 2019 9:08 PM > > To: Slava Ovsiienko ; dev@dpdk.org > > Cc: Ori Kam ; Raslan Darawsheh > > > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list > > > > Introduce simple hash list to the mlx5 utilities. User can define its > > own data structure containing the mlx5_hlist_entry and create the hash > > list table via the creation interface. Then the entry will be inserted > > into the table and linked to the corresponding list head. User should > > guarantee there is no collision of the key and provide a callback > > function to handle all the remaining entries in the table when destroyi= ng > the hash list. > > User should define a proper number of the list heads in the table in > > order to get a better performance. The LSB of the 'key' is used to > > calculate the index of the head in the list heads array. > > This implementation is not multi-threads safe right now. > > > > Signed-off-by: Bing Zhao > > Acked-by: Viacheslav Ovsiienko > > --- > > drivers/net/mlx5/Makefile | 1 + > > drivers/net/mlx5/meson.build | 2 + > > drivers/net/mlx5/mlx5_utils.c | 119 > > ++++++++++++++++++++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_utils.h | 107 > > ++++++++++++++++++++++++++++++++++++- > > 4 files changed, 227 insertions(+), 2 deletions(-) create mode > > 100644 drivers/net/mlx5/mlx5_utils.c > > > > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > > index dae5b9f..44cc26a 100644 > > --- a/drivers/net/mlx5/Makefile > > +++ b/drivers/net/mlx5/Makefile > > @@ -37,6 +37,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D > > mlx5_flow_verbs.c > > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D mlx5_mp.c > > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D mlx5_nl.c > > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D mlx5_devx_cmds.c > > +SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D mlx5_utils.c > > > > ifeq ($(CONFIG_RTE_IBVERBS_LINK_DLOPEN),y) > > INSTALL-$(CONFIG_RTE_LIBRTE_MLX5_PMD)-lib +=3D $(LIB_GLUE) diff - -git > > a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index > > 02494cf..b72ddb4 100644 > > --- a/drivers/net/mlx5/meson.build > > +++ b/drivers/net/mlx5/meson.build > > @@ -38,6 +38,7 @@ endforeach > > > > if build > > allow_experimental_apis =3D true > > + deps +=3D ['hash'] > > ext_deps +=3D libs > > sources =3D files( > > 'mlx5.c', > > @@ -58,6 +59,7 @@ if build > > 'mlx5_txq.c', > > 'mlx5_vlan.c', > > 'mlx5_devx_cmds.c', > > + 'mlx5_utils.c', > > ) > > if (dpdk_conf.has('RTE_ARCH_X86_64') > > or dpdk_conf.has('RTE_ARCH_ARM64') > > diff --git a/drivers/net/mlx5/mlx5_utils.c > > b/drivers/net/mlx5/mlx5_utils.c new file mode 100644 index > > 0000000..5d86615 > > --- /dev/null > > +++ b/drivers/net/mlx5/mlx5_utils.c > > @@ -0,0 +1,119 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2019 Mellanox Technologies, Ltd */ > > + > > +#include > > +#include > > + > > +#include "mlx5_utils.h" > > + > > +struct mlx5_hlist * > > +mlx5_hlist_create(const char *name, uint32_t size) { > > + struct mlx5_hlist *h; > > + uint32_t act_size; > > + uint32_t alloc_size; > > + > > + if (!size) > > + return NULL; > > + /* Align to the next power of 2, 32bits integer is enough now. > > */ > > + if (!rte_is_power_of_2(size)) { > > + act_size =3D rte_align32pow2(size); > > + DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power > > of 2, will " > > + "be aligned to 0x%" PRIX32 ".\n", size, act_size); > > + } else { > > + act_size =3D size; > > + } > > + alloc_size =3D sizeof(struct mlx5_hlist) + > > + sizeof(struct mlx5_hlist_head) * act_size; > > + /* Using zmalloc, then no need to initialize the heads. */ > > + h =3D rte_zmalloc(name, alloc_size, RTE_CACHE_LINE_SIZE); > > + if (!h) { > > + DRV_LOG(ERR, "No memory for hash list %s > > creation\n", > > + name ? name : "None"); > > + return NULL; > > + } > > + if (name) > > + snprintf(h->name, MLX5_HLIST_NAMESIZE, "%s", > > name); > > + h->table_sz =3D act_size; > > + h->mask =3D act_size - 1; > > + DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is > > created.\n", > > + h->name, act_size); > > + return h; > > +} > > + > > +struct mlx5_hlist_entry * > > +mlx5_hlist_lookup(struct mlx5_hlist *h, uint64_t key) { > > + uint32_t idx; > > + struct mlx5_hlist_head *first; > > + struct mlx5_hlist_entry *node; > > + > > + assert(h); > > + idx =3D rte_hash_crc_8byte(key, 0) & h->mask; > > + first =3D &h->heads[idx]; > > + LIST_FOREACH(node, first, next) { > > + if (node->key =3D=3D key) > > + return node; > > + } > > + return NULL; > > +} > > + > > +int > > +mlx5_hlist_insert(struct mlx5_hlist *h, struct mlx5_hlist_entry > > +*entry) { > > + uint32_t idx; > > + struct mlx5_hlist_head *first; > > + struct mlx5_hlist_entry *node; > > + > > + assert(h && entry); > > + idx =3D rte_hash_crc_8byte(entry->key, 0) & h->mask; > > + first =3D &h->heads[idx]; > > + /* No need to reuse the lookup function. */ > > + LIST_FOREACH(node, first, next) { > > + if (node->key =3D=3D entry->key) > > + return -EEXIST; > > + } > > + LIST_INSERT_HEAD(first, entry, next); > > + return 0; > > +} > > + > > +void > > +mlx5_hlist_remove(struct mlx5_hlist *h __rte_unused, > > + struct mlx5_hlist_entry *entry) > > +{ > > + assert(entry && entry->next.le_prev); > > + LIST_REMOVE(entry, next); > > + /* Set to NULL to get rid of removing action for more than once. > > */ > > + entry->next.le_prev =3D NULL; > > +} > > + > > +void > > +mlx5_hlist_destroy(struct mlx5_hlist *h, > > + mlx5_hlist_destroy_callback_fn cb, void *ctx) { > > + uint32_t idx; > > + struct mlx5_hlist_entry *entry; > > + > > + assert(h); > > + for (idx =3D 0; idx < h->table_sz; ++idx) { > > + /* no LIST_FOREACH_SAFE, using while instead */ > > + while (!LIST_EMPTY(&h->heads[idx])) { > > + entry =3D LIST_FIRST(&h->heads[idx]); > > + LIST_REMOVE(entry, next); > > + /* > > + * The owner of whole element which contains > > data entry > > + * is the user, so it's the user's duty to do the > > clean > > + * up and the free work because someone may > > not put the > > + * hlist entry at the beginning(suggested to > > locate at > > + * the beginning). Or else the default free > > function > > + * will be used. > > + */ > > + if (cb) > > + cb(entry, ctx); > > + else > > + rte_free(entry); > > + } > > + } > > + rte_free(h); > > +} > > diff --git a/drivers/net/mlx5/mlx5_utils.h > > b/drivers/net/mlx5/mlx5_utils.h index 97092c7..b4ed8c6 100644 > > --- a/drivers/net/mlx5/mlx5_utils.h > > +++ b/drivers/net/mlx5/mlx5_utils.h > > @@ -151,13 +151,13 @@ > > snprintf(name, sizeof(name), __VA_ARGS__) > > > > /** > > - * Return nearest power of two above input value. > > + * Return logarithm of the nearest power of two above input value. > > * > > * @param v > > * Input value. > > * > > * @return > > - * Nearest power of two above input value. > > + * Logarithm of the nearest power of two above input value. > > */ > > static inline unsigned int > > log2above(unsigned int v) > > @@ -170,4 +170,107 @@ > > return l + r; > > } > > > > +/** Maximum size of string for naming the hlist table. */ > > +#define MLX5_HLIST_NAMESIZE 32 > > + > > +/** > > + * Structure of the entry in the hash list, user should define its > > +own struct > > + * that contains this in order to store the data. The 'key' is > > +64-bits right > > + * now and its user's responsibility to guarantee there is no collisio= n. > > + */ > > +struct mlx5_hlist_entry { > > + LIST_ENTRY(mlx5_hlist_entry) next; /* entry pointers in the list. > > */ > > + uint64_t key; /* user defined 'key', could be the hash signature. > > */ > > +}; > > + > > +/** Structure for hash head. */ > > +LIST_HEAD(mlx5_hlist_head, mlx5_hlist_entry); > > + > > +/** Type of function that is used to handle the data before freeing. > > */ > > +typedef void (*mlx5_hlist_destroy_callback_fn)(void *p, void *ctx); > > + > > +/** hash list table structure */ > > +struct mlx5_hlist { > > + char name[MLX5_HLIST_NAMESIZE]; /**< Name of the hash > > list. */ > > + /**< number of heads, need to be power of 2. */ > > + uint32_t table_sz; > > + /**< mask to get the index of the list heads. */ > > + uint32_t mask; > > + struct mlx5_hlist_head heads[]; /**< list head arrays. > > */ > > +}; > > + > > +/** > > + * Create a hash list table, the user can specify the list heads > > +array size > > + * of the table, now the size should be a power of 2 in order to get > > +better > > + * distribution for the entries. Each entry is a part of the whole > > +data element > > + * and the caller should be responsible for the data element's > > +allocation and > > + * cleanup / free. Key of each entry will be calculated with CRC in > > +order to > > + * generate a little fairer distribution. > > + * > > + * @param name > > + * Name of the hash list(optional). > > + * @param size > > + * Heads array size of the hash list. > > + * > > + * @return > > + * Pointer of the hash list table created, NULL on failure. > > + */ > > +struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t > > +size); > > + > > +/** > > + * Search an entry matching the key. > > + * > > + * @param h > > + * Pointer to the hast list table. > > + * @param key > > + * Key for the searching entry. > > + * > > + * @return > > + * Pointer of the hlist entry if found, NULL otherwise. > > + */ > > +struct mlx5_hlist_entry *mlx5_hlist_lookup(struct mlx5_hlist *h, > > +uint64_t key); > > + > > +/** > > + * Insert an entry to the hash list table, the entry is only part of > > +whole data > > + * element and a 64B key is used for matching. User should construct > > +the key or > > + * give a calculated hash signature and guarantee there is no collisio= n. > > + * > > + * @param h > > + * Pointer to the hast list table. > > + * @param entry > > + * Entry to be inserted into the hash list table. > > + * > > + * @return > > + * - zero for success. > > + * - -EEXIST if the entry is already inserted. > > + */ > > +int mlx5_hlist_insert(struct mlx5_hlist *h, struct mlx5_hlist_entry > > +*entry); > > + > > +/** > > + * Remove an entry from the hash list table. User should guarantee > > the > > +validity > > + * of the entry. > > + * > > + * @param h > > + * Pointer to the hast list table. (not used) > > + * @param entry > > + * Entry to be removed from the hash list table. > > + */ > > +void mlx5_hlist_remove(struct mlx5_hlist *h __rte_unused, > > + struct mlx5_hlist_entry *entry); > > + > > +/** > > + * Destroy the hash list table, all the entries already inserted into > > +the lists > > + * will be handled by the callback function provided by the user > > +(including > > + * free if needed) before the table is freed. > > + * > > + * @param h > > + * Pointer to the hast list table. > > + * @param cb > > + * Callback function for each inserted entry when destroying the > > hash list. > > + * @param ctx > > + * Common context parameter used by callback function for each > > entry. > > + */ > > +void mlx5_hlist_destroy(struct mlx5_hlist *h, > > + mlx5_hlist_destroy_callback_fn cb, void *ctx); > > + > > #endif /* RTE_PMD_MLX5_UTILS_H_ */ > > -- > > 1.8.3.1 Patch applied to next-net-mlx, Stephen, If you still think there are more reviews to be added please let me know. I'm merging because the metadata series is depending on this patch. Kindest regards, Raslan Darawsheh