From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6E1BA04C1; Wed, 13 Nov 2019 10:51:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 272B41BF1D; Wed, 13 Nov 2019 10:51:02 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by dpdk.org (Postfix) with ESMTP id AF1331BF08 for ; Wed, 13 Nov 2019 10:51:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZWHeJ3842aybE72YqOEcYHqu14pmkhKkN+N40EkV94hJdlWUHJjJL6zm0TYDBdalMYYYI6RSwAIV+WqrVcIOiapb6qSSXu3dewdQy6FFtgKi/A6MIZNV40OSMo+jlT1xEUive7ChftbDw6YNxK/k8KhAJN4kQfLQLa+7gLXGRL4lDvTV/YGtMqwOCWW+UzSk3GF4qQ8quDg0xu85ia76stvfyIMuQMpKncNVao2SoeZCgaCpMVzkTVkZkTUhaNK65XAJUNZhP9/PxaimsRhtMT8bW6NP7Bdj0EAjgTNJZo1Yvxgq3kY1D6enDn7eY9ETYMoLQ81tAw5TEG0STqLAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7SYEX3uVA0HVm4K+TQVNN+72jCZkDePXFiMtJxA3hs=; b=gI2uqRPYCWrONZ4CBs3jMubX7tXt/KDjAm9H4jIuFr91BZdfdDwkPJ+VYQShBi+AmbMbnVDcIkB6mKid2fBn/gyuP26v5o7XqIMRrx2BG3kNtrhN6K42WT7qZxj3dIsNHicOmBY6SUpccGXEsaH5eshsp++ROgYG2avm4zkBZvIC1/0iOsfpDJiLyPT2KszrN4sGY/Usg8TTN+XQhhWUHCYq5GR0gnILzAO0dtVyyml9KZ08TeCJ/ylBXk+kvICfMtDwrBlgmkM2/dXkg7Go94FkTC6cKEDC5cPFWuOE3ual0MtzDNeyGkdmoh/mfZ9SdJxxYXHkxKrtSOTOAYgahw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7SYEX3uVA0HVm4K+TQVNN+72jCZkDePXFiMtJxA3hs=; b=AqcjwJYAujPoBcy89mHFso6gd/7P1WaJe8aNeo5m4HtOKCh0CHxxy90oLZgPz1dGp1kOHU4vxvseT4+EkWuMERDB4cRZrrTiLdSFAXO7YcQBlS2ks6sInLJCJrOVwyCC41UM896aiKjM6bP24qhxWkzSUYA3EakBrCvB43nZLWE= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3978.eurprd05.prod.outlook.com (52.134.65.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Wed, 13 Nov 2019 09:50:59 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Wed, 13 Nov 2019 09:50:59 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix suffix flow creation in metadata split Thread-Index: AQHVmfxGOnhm2Ah/VUCEFJDT9PrJdKeI256g Date: Wed, 13 Nov 2019 09:50:59 +0000 Message-ID: References: <1573633665-10519-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1573633665-10519-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 207d1350-0502-4253-91df-08d7681efcef x-ms-traffictypediagnostic: DB3PR0502MB3978:|DB3PR0502MB3978: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(136003)(376002)(199004)(189003)(13464003)(74316002)(186003)(102836004)(76176011)(5660300002)(86362001)(486006)(53546011)(7736002)(7696005)(26005)(6506007)(446003)(11346002)(33656002)(478600001)(316002)(3846002)(6116002)(66476007)(305945005)(66946007)(66446008)(64756008)(66556008)(8676002)(81156014)(81166006)(14454004)(2906002)(110136005)(54906003)(107886003)(4326008)(6246003)(2501003)(9686003)(6436002)(52536014)(25786009)(71200400001)(8936002)(55016002)(71190400001)(66066001)(256004)(99286004)(229853002)(476003)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3978; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WEnZw5bBtsMu3RRCzE4FpAbVCvfYULLzynmsAj+hQquYpYmIPmY7EEp9wlN5h3G1vAXx/ZeZfuoKjoFCjvl2Ycq+x8Ho64qlXvH6nNTddhl1wlYIcfFc9KGvDm7B/oJBUxFpLC+j90A2gWnkdlKs4qc+05nIO8JrR1A+gHI69sSMNBYFTRJDmSkC/DjCsH3vpneUn31m2555WYg/drtoXKv8zNcoPHj+rrW6xYO6Xbwn53/Qp8jNnemt0LPbm0h40MRn361suLZ6dhyH0nSTIEObUqBQQWcp6zggMZPNqPayzKscHJzHK1g2OG3RH7dui1CjLWptdX9zNCjItCABLpVknlQFcqiOZECTjgTn7D8ypV7Gnnowii73ehuLipL6ZYkSA0wTEYVoVrffjCm4Klk3u7ZZ0PYYIB8nPRgofXpNzzSxjfYCwT8vn2JFn21B Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 207d1350-0502-4253-91df-08d7681efcef X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 09:50:59.7161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fZSlxKKxIXporALvhurX1J+kU6z03peoe0d460vJCn66fd/W/04U4GlIby/ZVjjLUsGT5G7ViCPTzwY0Q/bP0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3978 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix suffix flow creation in metadata split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Wednesday, November 13, 2019 10:28 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix suffix flow creation in metadata split >=20 > The variable cleanup was erroneously done before pointer usage. > The cleanup is moved to appropriate place, comment is clarified. >=20 > Fixes: 8d72fa668964 ("net/mlx5: share tag between meter and metadata") >=20 > Reported-by: Eli Britstein > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 14a89e2..d677de8 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -3862,16 +3862,18 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > }, > }; > uint64_t hash_fields =3D dev_flow->hash_fields; > - dev_flow =3D NULL; > + > /* > - * Configure the tag action only if we are not the meter sub > - * flow. Since tag is already marked in the meter suffix sub > - * flow. > + * Configure the tag item only if there is no meter subflow. > + * Since tag is already marked in the meter suffix subflow > + * we can just use the meter suffix items as is. > */ > if (qrss_id) { > + /* Not meter subflow. */ > + assert(!mtr_sfx); > /* > * Put unique id in prefix flow due to it is destroyed > - * after prefix flow and id will be freed after there > + * after suffix flow and id will be freed after there > * is no actual flows with this id and identifier > * reallocation becomes possible (for example, for > * other flows in other threads). > @@ -3884,6 +3886,7 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > goto exit; > q_tag_spec.id =3D ret; > } > + dev_flow =3D NULL; > /* Add suffix subflow to execute Q/RSS. */ > ret =3D flow_create_split_inner(dev, flow, &dev_flow, > &q_attr, mtr_sfx ? items : > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh