Re: [dpdk-dev] [PATCH v2] net/mlx5: adjust inline setting for large Tx queue sizes

[Raslan Darawsheh <rasland@mellanox.com>]

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Tuesday, October 1, 2019 9:54 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad
> <matan@mellanox.com>
> Subject: [PATCH v2] net/mlx5: adjust inline setting for large Tx queue sizes
> 
> The hardware may have limitations on maximal amount of supported Tx
> descriptors building blocks (WQEBB). Application requires the Tx queue must
> accept the specified amount of packets.
> If inline data feature is engaged the packet may require more WQEBBs and
> overall amount of blocks may exceed the hardware capabilities.
> Application has to make a trade-off between Tx queue size and maximal data
> inline size.
> 
> In case if the inline settings are not requested explicitly with devarg keys the
> default values are used. This patch adjusts the applied default values if large
> Tx queue size is requested and default inline settings can not be satisfied due
> to hardware limitations.
> 
> The explicitly requested inline setting may be aligned (enlarging
> only) by configurations routines to provide better WQEBB filling, this implicit
> alignment is the subject for adjustment either.
> 
> The warning message is emitted to the log if adjustment happens.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> ---
> v2: - check explicitly specified parameters
>     - allow adjust aligned parameters
>     - added extra asserts
> v1:
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F59735%2F&amp;data=02%7C01%7Crasland%40mell
> anox.com%7Ca35d54a2949143d3d89608d7463c25a7%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C1%7C637055096469653065&amp;sdata=%2FCXfd2V
> VjpGntk%2BAynInVj2VQld%2BBC%2BJc66%2Bgu63hso%3D&amp;reserved=
> 0
> 

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh