From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEECFA04DD; Tue, 26 Nov 2019 16:14:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 984F8CF3; Tue, 26 Nov 2019 16:14:23 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20084.outbound.protection.outlook.com [40.107.2.84]) by dpdk.org (Postfix) with ESMTP id C67DBA3 for ; Tue, 26 Nov 2019 16:14:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hiBAqkLSZ1KqO+xj0AwvUhNQOCYn5/7X3Njix+WLYOhKvQevANU7Y4lQj58qmc6A04pXnvDNfytBeYqNWPdDrTTpLytYOnhh0ZfVWSSZ7UXiefcFbXyc28NSnEbWu9kQP+TCUb1AXf1+0hAIM06iU5c1pYuVgfxE8CiH4patT1bk+PCgTW4onH0UpsjM0IxxZ4oMMHKK6Dj6/aa5qRQUXkuWOCRf0MLzhYORTq+TVA82XB6TqGu/2MDWgq8Pk0pD7XZPRv+kw+nIHDkrtKOdWWrVt/mHc8Iaq2xf0kR+hwtS7pevZ+WspxbSmCtDFtNi+665lvUjnU1KgegRUMwnuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wSmqZ1sTF7Zns1O74nUmtCGhWCnQ24DWIhMu7qzJpg=; b=VSQXPRJx6vN3ebBpWHyXCgz+JT0BOCTEidXnzU8fvherwmf7P0sH6Ma+8PuezNNmBTw0iQVSU3xQynMoK70sdJCQj2tDdDcK7+U2oVWjAUar1m8atjb7XHpYUG3arp9qEghdnwPCpI51otoQ7uS4NPL54UDTJ44Sqyc07UKIo/Sqcjt13p7v/bWEJDF9qd0v8zjf9/vNWhqOeVGI6nyzg5eQF77AGLxtRvSSTAXoKmufQDG8X6cw3lU/k3a3XoJjMAxzGN7gqABOF61svVM/ZEAfEAwSI9YPBIw5IEAi/UVgy8ZE737WxG+sejscAut4kKKmdOSXO47ZjF4A6Ndo5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9wSmqZ1sTF7Zns1O74nUmtCGhWCnQ24DWIhMu7qzJpg=; b=ngsjs59yTkM2v+dPE258ycRAEAYHeZjllVzNSOEr19eKlcHmyXBmqwfYEbXoM5fDAhkz3GWSouXgS77IVtNgvQo4sKLWdGIpTFDq/DiP3GdMYBedoAu0zWF5bmo2K+rEh2pHNbqRtT31+cpdcwjZQ3rOrKsjybqd8Yqga1f0Ygo= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4076.eurprd05.prod.outlook.com (52.134.66.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16; Tue, 26 Nov 2019 15:14:21 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2474.023; Tue, 26 Nov 2019 15:14:21 +0000 From: Raslan Darawsheh To: Ali Alnubani , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix build with dlopen linkage Thread-Index: AQHVpDRy647emPT2f0m0jLeKILEtJaedj+JQ Date: Tue, 26 Nov 2019 15:14:21 +0000 Message-ID: References: <20191126083503.23498-1-alialnu@mellanox.com> In-Reply-To: <20191126083503.23498-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 51eb3204-b647-4058-0863-08d772835097 x-ms-traffictypediagnostic: DB3PR0502MB4076:|DB3PR0502MB4076: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-forefront-prvs: 0233768B38 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(13464003)(189003)(199004)(33656002)(6506007)(6246003)(478600001)(25786009)(7696005)(74316002)(186003)(102836004)(9686003)(86362001)(305945005)(76176011)(7736002)(53546011)(55016002)(66476007)(110136005)(71200400001)(66446008)(2906002)(52536014)(5660300002)(2501003)(81166006)(81156014)(76116006)(66946007)(8936002)(6436002)(14454004)(446003)(11346002)(229853002)(99286004)(6116002)(3846002)(256004)(66066001)(316002)(14444005)(8676002)(64756008)(71190400001)(66556008)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4076; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UhDs6kwf/3pgsop/+H4s/zD6wRPRCilZI6PyKXY1keWH+Lp3URlHpmtDRmtkhVKFckdLPRDdMTsKBu4u29Rub9NmwNMx4TWQR83J3lUn6K+GabktPGiQdg8gdXhNNWmlZ4DP5ZEXCtxG27VSuw97rIoR42LRv93AkCIEWIoUT2rpmVZdf80ojtpNxavKOU3+s6V3YI7LLxvA7qim5tcZwFRDpqorPVIhlxHmSxF1Dsgzm4DPHP7JvKwCMW1uJf85izcKY/VwE0FicnLOIhmvwDOIiD/z277LMuzY+e5iUfBmelnsiO4VtyZwUljXBi0U5rctH/jSdGCHxSkUQKv62h7sr/Mqzu8y2AlLmdX7A4BycCAbpJ/LBu1DHzlUGoJ2U9NVTd3f3lC+kdLmrdkRhLVPmdWguYKd25saRw6+fjwafH7pMbBIWvuk9VEN1I8B Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51eb3204-b647-4058-0863-08d772835097 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2019 15:14:21.3422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfKO49tma9/FejB3FMwTbM2WZ47QKodbboX87KAS8gg+JNsbBj6aEI+7q3+gFnX4WFcWExaF1eGhCZLdV907DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4076 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Ali Alnubani > Sent: Tuesday, November 26, 2019 10:35 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage >=20 > The header mlx5_glue.h includes rte_byteorder.h, which isn't > pulled by global_inc. This patch adds the missing include directory > and fixes the build error: >=20 > In file included from drivers/net/mlx5/mlx5_glue.c:31: > drivers/net/mlx5/mlx5_glue.h:12:10: fatal error: > rte_byteorder.h: No such file or directory >=20 > The build failure can be triggered with: > meson -Dibverbs_link=3Ddlopen build && ninja -C build >=20 > Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to > glue") >=20 > Signed-off-by: Ali Alnubani > --- > drivers/net/mlx5/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index 05fadf608..d6b32db79 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -206,10 +206,14 @@ if pmd_dlopen and build > dlopen_so_version =3D LIB_GLUE_VERSION > dlopen_sources =3D files('mlx5_glue.c') > dlopen_install_dir =3D [ eal_pmd_path + '-glue' ] > + dlopen_includes =3D [global_inc] > + dlopen_includes +=3D include_directories( > + '../../../lib/librte_eal/common/include/generic', > + ) > shared_lib =3D shared_library( > dlopen_lib_name, > dlopen_sources, > - include_directories: global_inc, > + include_directories: dlopen_includes, > c_args: cflags, > dependencies: libs, > link_args: [ > -- > 2.24.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh