From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EC61A04C1; Wed, 20 Nov 2019 15:25:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55DBA2B8E; Wed, 20 Nov 2019 15:25:58 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by dpdk.org (Postfix) with ESMTP id D70432B87 for ; Wed, 20 Nov 2019 15:25:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHACqzUhFmBhQrbPeeRaXe6rB3Ru2tSxBJJk6lQoYJsKF0BaubtiKmvX0eGiTX49uOYVmmpDppkrtBootaUz9T5eVci/jCnezfXXweJ9VyRO7c60l4A7JiO0aMrYDeLDT1wM/LX3H6xc4KNRArI9lcfJK108QMboZ31Ghd9j7xalUIa4LOjbpSZYybOqBQ7cAxY/q6ph0jFHCWcmUuYl9iXulODFmAf+/rcCnYQ5A5MKO8LP8W0K1UzCT6WbgdHs2VJpW6eYtfh1SwWMDxWO3jXTfZQii/Yxgi62gdSGHBtGxMszEdgkS7X5ETZOZtdqRHanb8ssMr7vTyR2Q7j+bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcOLM37Jjm3HBvd9E9XEaG6DXFazo/nVOTBZkA7qZeM=; b=PG+9OoAkoDMhCoY8IGrE+Oai475RRrTd9Nt/usZFi5mXU+jKr7Fs6mQjonnJmPQw9Zx7WHKKnIkTOv1X0v5Ze8eOcgmAm/SHM1H9IJ+aDVmoEshSmZNA7lXygWWrB7NfHOiAhxl64Ht3X1dM+LzL2pYPjHlsk8tS/TxInKYX9T/7uM61/yzmXBnvq4far0M7iSFEKkdqSgsn4mVajZw+UAYQm5tmjG77/9oc2TFp0cEnsYTOA1ak7cteA92rYS2q2kEhJoRozf1KP5CzsYb4BUGiCcC+1FtGYhXqLkFtziMVzK3VcV3CcuYmDJnzvTE5AkscElS1BMLPPUn8YhuPkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcOLM37Jjm3HBvd9E9XEaG6DXFazo/nVOTBZkA7qZeM=; b=RqtTgpMOmU/x6D01iOTrG4cSI2fvpaEEZQNUX/J9GmSWA1HvJZI3OxxzZUZshIjypkreRXozwvQHDO7vhe6rgDPxCE/lr3Ly2Dds7REraUf9lo+qa90GHauwQ8IlIGksQPJrY9RZBgZaiRQR7FtpsDAyOND+L+mU41VBlNbnVH0= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3977.eurprd05.prod.outlook.com (52.134.70.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Wed, 20 Nov 2019 14:25:55 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2474.015; Wed, 20 Nov 2019 14:25:54 +0000 From: Raslan Darawsheh To: Matan Azrad , "dev@dpdk.org" CC: Slava Ovsiienko , Ori Kam Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release assertions Thread-Index: AQHVn4Pj7fmuUZqi4E+HOlzkyzJ3caeUHb0Q Date: Wed, 20 Nov 2019 14:25:54 +0000 Message-ID: References: <1574241676-14807-1-git-send-email-matan@mellanox.com> In-Reply-To: <1574241676-14807-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2473cdc9-9121-44bf-d040-08d76dc58d70 x-ms-traffictypediagnostic: DB3PR0502MB3977:|DB3PR0502MB3977: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-forefront-prvs: 02272225C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(189003)(199004)(13464003)(25786009)(2906002)(74316002)(186003)(14454004)(54906003)(478600001)(9686003)(6436002)(76116006)(71200400001)(86362001)(110136005)(316002)(71190400001)(256004)(14444005)(99286004)(229853002)(55016002)(3846002)(2501003)(486006)(81156014)(476003)(107886003)(33656002)(64756008)(66556008)(66476007)(66946007)(6246003)(66446008)(4326008)(5660300002)(7736002)(66066001)(26005)(52536014)(8936002)(305945005)(446003)(11346002)(6506007)(53546011)(81166006)(76176011)(8676002)(102836004)(7696005)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3977; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kYgIhRzq4oy4oOKbjIAST4F7ykyxKxJGPwRKbQNdKe+89HswOIk4LeYLYKnTBiyriD6cM3pcx7mcgO15EzsmSJ8TtuM/T2nLyNGYrCNj7ATfa/Qlmne2Lim3cJQfGRvNunoVqf7Gk8kDj4wZoQlQM3HX8d7weGXMW/5q5lim3aHH1Ib9dZN5qCRdv3QNq9o1kzQeRiunZ1yBnctY8GPbslV8Yz8ipltZESVt3InJlEPb6VWlKd6fKIYkLzaLMS61lBYn4TLS9bdUSrTcMxqLPwRu9FCujSIGVYEfJLdWsRmkRNbCPcQdbB2m6gaq4lrlunP9vfa03LVoHZ/Go5fS8LN5J3u649WqwcGxQa8hvJpm4tgvsPQ58p6lqvrJCJWsOf0opAGmL9UhXelQxzZruf2DOo7HlgixfZtnoVhHPe5jeOkht961Eu+ijDpd27mU Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2473cdc9-9121-44bf-d040-08d76dc58d70 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 14:25:54.3461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W01i30TgNQwatVKvIp8plQSssaXWEBiOSSksMYrpkaE5Lczjt0Rluqmj1MCA587v+w0MM8nXFzNB8vci3uTraA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3977 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release assertions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, November 20, 2019 11:21 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release assertions >=20 > In debug mode, there is assertion to validate the CQ object before the > release. >=20 > Wrongly, the assertion is done for any type of RX queue even if it > doesn't use CQ at all, for example in hairpin Rx queue. >=20 > Ignore CQ assertion when hairpin queue is released. >=20 > Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") > Cc: orika@mellanox.com >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxq.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 2a12d5f..986ec01 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -671,23 +671,25 @@ > mlx5_rxq_obj_release(struct mlx5_rxq_obj *rxq_obj) > { > assert(rxq_obj); > - if (rxq_obj->type =3D=3D MLX5_RXQ_OBJ_TYPE_IBV) > - assert(rxq_obj->wq); > - assert(rxq_obj->cq); > if (rte_atomic32_dec_and_test(&rxq_obj->refcnt)) { > switch (rxq_obj->type) { > case MLX5_RXQ_OBJ_TYPE_IBV: > + assert(rxq_obj->wq); > + assert(rxq_obj->cq); > rxq_free_elts(rxq_obj->rxq_ctrl); > claim_zero(mlx5_glue->destroy_wq(rxq_obj->wq)); > claim_zero(mlx5_glue->destroy_cq(rxq_obj->cq)); > break; > case MLX5_RXQ_OBJ_TYPE_DEVX_RQ: > + assert(rxq_obj->cq); > + assert(rxq_obj->rq); > rxq_free_elts(rxq_obj->rxq_ctrl); > claim_zero(mlx5_devx_cmd_destroy(rxq_obj->rq)); > rxq_release_rq_resources(rxq_obj->rxq_ctrl); > claim_zero(mlx5_glue->destroy_cq(rxq_obj->cq)); > break; > case MLX5_RXQ_OBJ_TYPE_DEVX_HAIRPIN: > + assert(rxq_obj->rq); > rxq_obj_hairpin_release(rxq_obj); > break; > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh