From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F9F0A2EEB for ; Tue, 10 Sep 2019 16:28:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC4691EE63; Tue, 10 Sep 2019 16:28:07 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by dpdk.org (Postfix) with ESMTP id C4B9D1EDE6; Tue, 10 Sep 2019 16:28:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Po1O0tcebcJdi8IXZVNtkpbMq+r5K3GfoDW7xISlgDGMuRoln14lfzqPUmyFJuKJC6h/GPjbfYp1HMnbxfPOMYJq6LQBf8ijToBa4u018k4ib+gnwdGQS3qEpjBLSoczsTglLE6YBKahadVWnFKsHc6CX1xL71dAxlBRPVlLnBJqO6mDxW80QX+kwazQ/MSjNodofQvqGbA3L/4S7LkySRW1SYQMDq6QySedSXIZ5tb4leMhcmASpZ/kftlA8VDLeH406k5GjaT/m+iz9+q3+6N9/hJv+oWMeDPRsMjnCmPtOuCAM+p0m/mTBx+Qz8aEQdD4uAW5O7zPs+kcpii9gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QmqoGtDFSjvwwsTovPlL1UCIuwtCOPILScCDN+n/ihk=; b=jmF3T7bPJ7cSLrSNMxP5lrN6eAW10/4WpXt652SwzYwWHcAGAsaO6ZQx4Oc9ATYXO4ogt5qQt/0g/f84I+oeGIQ87EaVY8zxV+MuKcBWOqrqBFJ05iBGDbF6j/OibJDDycWPyGJE9CBlO1uQnS4Wa0DbzC/Hr5IRj9SqheqrvAgi23maUPmT+bRB0/v5fqLPasJGf2udbMySWQlM4Iu/k0nBjsVPlMkWtqcqr17PAiAEl74X2lJTWBjs4k1R3yu0nJuipYUZeBT9xwAs5AKf7SawNVoprhwBAQ7Mc7gN2RrxGuvv3T2qRKQ4PgfB1+D6Y53KHoLGO0um62zEUmL9Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QmqoGtDFSjvwwsTovPlL1UCIuwtCOPILScCDN+n/ihk=; b=DQhmyuOu+GcH12fTd4Zu/bb4KWXQ9evtiKMaOsQqe10gAviPcDC6niBXP4SoesLDIiH1UiMyWFnCcUhUpwDDUPkkf2ks3fP6u/J0y97v/lE7g+p2bclK7gRDeIEnZFqm2/ESNKKvUXCdxz3ktGtiRXRrgmOi7M4L/Uf5pM1nb8c= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3993.eurprd05.prod.outlook.com (52.134.70.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.18; Tue, 10 Sep 2019 14:28:05 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::75d2:b478:8f56:e4fd]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::75d2:b478:8f56:e4fd%4]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 14:28:05 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix netlink rdma socket callback routine Thread-Index: AQHVZ97rzMGJ6Ul8DEylZqrxAmWnNack9+bg Date: Tue, 10 Sep 2019 14:28:05 +0000 Message-ID: References: <1568123511-20153-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1568123511-20153-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 276be322-0047-4807-8c29-08d735fb185b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3993; x-ms-traffictypediagnostic: DB3PR0502MB3993:|DB3PR0502MB3993: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(199004)(189003)(13464003)(6506007)(76116006)(66066001)(8676002)(64756008)(71200400001)(71190400001)(81166006)(53546011)(86362001)(81156014)(76176011)(33656002)(7696005)(74316002)(6246003)(102836004)(55016002)(316002)(53936002)(5660300002)(66446008)(256004)(486006)(476003)(6306002)(478600001)(229853002)(6436002)(11346002)(7736002)(52536014)(446003)(966005)(99286004)(45080400002)(305945005)(110136005)(26005)(186003)(25786009)(3846002)(450100002)(8936002)(6116002)(4326008)(2501003)(9686003)(66476007)(66556008)(2906002)(66946007)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3993; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: y1lAy2gsQ9QUbPrzoIOG9tupEI+lMAylGKeOsd5cgXfdDahqCN9vx1Q9SZVHxb5RmIhAn+UXsMbMFjMpyOGA4Vvtoqmf4JnSSl4kkflCLtLsIuXkFx3DnPAG+ZtVF9LFWvm63hJPBu0a0KVGvEecsfiNgb45dzj/oz+Unz0h3s4PJ/3JTsR/fQQoVp12WLYf3eCG8U3EzmKgZRhgO29ySAVjyq5tO0tS2TNIlM0cSCEIp7cCzpFZR3PPlYF3b1eqyydgMqpbvkNr+UNRGlp9MI0ycvdYyp6s3l6lfVLBHjy74va3cGMnVk6Dpy6ILgK+RPJy95Xj2c1gIbC/c/g7xmUygiK4vT7UOSNJZekFYYnpYyXUK5u1KOSjGAEsMmZmcRBm8NQTN+ERmrpNJosSpIV2gSR11mEeG6cDoskW2ug= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 276be322-0047-4807-8c29-08d735fb185b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 14:28:05.6361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /07o9rTda8T0HFgbJhAoXq8YHo7M0HSe7AyunoJzk4/obTx6ei4YuWSeBbL9cnfbhE9MgkZHIVdWWuYfwpBMBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3993 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix netlink rdma socket callback routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Tuesday, September 10, 2019 4:52 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix netlink rdma socket callback routine >=20 > The mlx5 PMD uses Netlink socket to communicate with Infiniband > devices kernel drivers to perform some control and setup operations. > The kernel drivers send the information back to the user mode > with Netlink messages which are processed in libnl callback routine. > This routine perform reply message (or set of messages) processing > and returned the processing result in ibindex field of provided > context structure (of mlx5_nl_ifindex_data type). The zero ibindex > value meant an error of reply message processing. It was found in > some configurations the zero is valid value for ibindex and error > was wrongly raised. To avoid this the new flags field is provided > in context structure, attribute processing flags are introduced > and these flags are used to decide whether no error occurred and > valid queried values are returned. >=20 > Fixes: e505508a3858 ("net/mlx5: modify get ifindex routine for multiport = IB") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > v2: reverted back local parameter gathering within one Netlink message > in callback routine. It allows to avoid parameters overwriting in > case of reply contains multiple messages for all Infiniband devices > in the system. >=20 > v1: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F59057%2F&data=3D02%7C01%7Crasland%40mell > anox.com%7C8e8cc6e9af8a4552ba8e08d735f60c17%7Ca652971c7d2e4d9ba6a > 4d149256f461b%7C0%7C0%7C637037203199776325&sdata=3DE4XI4EG%2B > ri7OuNiWGWOtA1vZL31LYvVOPUpsiR%2Bz2p8%3D&reserved=3D0 >=20 Replaced V1 with V2 due to some issue was in V1, So applied v2 to next-net-mlx, Kindest regards, Raslan Darawsheh