From: Raslan Darawsheh <rasland@mellanox.com>
To: Jack Min <jackmin@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jack Min <jackmin@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP
Date: Tue, 6 Aug 2019 10:38:07 +0000 [thread overview]
Message-ID: <DB3PR0502MB3964B0CD8981607E33458AC0C2D50@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <ef74a1f612a7844e182396ddfab3faaf62ae3a05.1563960401.git.jackmin@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Wednesday, July 24, 2019 2:32 PM
> To: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Jack Min <jackmin@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP
>
> The RSS expand function for IP-in-IP tunnel type is missed,
> which leads to create following flow failed:
>
> flow create 0 ingress pattern eth / ipv4 proto is 4 /
> ipv4 / udp / end actions rss queues 0 1 end level 2
> types ip ipv4-other udp ipv4 ipv4-frag end /
> mark id 221 / count / end
>
> In order to make RSS expand function working correctly,
> now the way to check whether a IP tunnel existing is to
> check whether there is the second IPv4/IPv6 item and whether the
> first IPv4/IPv6 item's next protocl is IPPROTO_IPIP/IPPROTO_IPV6.
> For example:
> ... pattern eth / ipv4 proto is 4 / ipv4 / ....
>
> Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel")
> Cc: jackmin@mellanox.com
>
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 8 +++-
> drivers/net/mlx5/mlx5_flow_dv.c | 79 ++++++++++++++++++++-------------
> 2 files changed, 53 insertions(+), 34 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2019-08-06 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 11:31 Xiaoyu Min
2019-08-06 9:20 ` [dpdk-dev] [Suspected-Phishing][PATCH] " Slava Ovsiienko
2019-08-06 10:38 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB3964B0CD8981607E33458AC0C2D50@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).