From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BDD2A00E6 for ; Tue, 6 Aug 2019 12:38:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2F231BE3F; Tue, 6 Aug 2019 12:38:11 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 5F50C1BE38 for ; Tue, 6 Aug 2019 12:38:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YV1LK7Ay/vICfKpoIH8BkRvbPzc84tjpUw2XPSlQgKHF4CktNk4eog8achHjGS3kw9uoXG2IVxF/1Adej8KkDr6tfd0bTl0B1gkEM2UkUmPygvaWWh8cFB8tfYPUL0ZpxEPvjLolGipKVgdYiRHeFsjv8uOGatEzTQw1TAxBrD7cJndVUcl5XbEvBck1+SZbD+35rgbT4R58vMuAO7utf7GqBW91yaJ1clNUMNWd0Og2R5oreIW9GHGiageAARPVIZKsWjAko2ZfRic5pygzlCPcPN2gQF9b3cBevUhVcwmdrLCtjaRst6lkIvwgnGkwqHWDIOfpaEM4YG6rM85IMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJgEG0SBR7yOlBZ1Q5OrFkELIGpwX6xfqpNAQHqYhvM=; b=OFXAPTFV/xOwkpFOtnUctQcgACrtmQbeuR2IOOIPPYlKNFRIDeX/yajn58JP0c6Axocwa8OMSUwYsnYy/7PuWIephL3EVRONWitLt7dQTakjZmEfMg9aKrh8Qk7Bpue6oUgo20GCBfFRwctd7COfJAKitWnYNpBrLE5OOObYCMHTGqb3ZZFRsKXgCl7Hfcu2ingblAcHcF4vDuqce55DbR7Ex+w4QnGxREHCEmYimPD2UwLPfv8F0pPFDgC3E6d/mZFlqyA85RyF1ckNCQZEeQCnrxdXO5gYy0nEDGdfZK3UkjX9V4tlcVeAsA92kaNdQFktJVeBtlvOuvMBjrj1Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJgEG0SBR7yOlBZ1Q5OrFkELIGpwX6xfqpNAQHqYhvM=; b=oLxPYQWZVxRfZNwB2CCep4NuG+jQVjGB4eeF54REB8YUDz7h3DXizmEgTborn2PT+5z5Fx/qO6xWUTVQZbxwNr1GnjSZPPNfYcopk6N35jlKzHKbTTUk9W9ICZs/nmlxZtRTcGKkmmSR7r4q3MJvUPDfYaCIQWazwMEGDUsSTC4= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4043.eurprd05.prod.outlook.com (52.134.68.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Tue, 6 Aug 2019 10:38:08 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 10:38:08 +0000 From: Raslan Darawsheh To: Jack Min , Shahaf Shuler , Yongseok Koh , Slava Ovsiienko CC: "dev@dpdk.org" , Jack Min Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP Thread-Index: AQHVQhNvmwlz8S/GokK8+llZaqtUzqbuAdJg Date: Tue, 6 Aug 2019 10:38:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 22def105-9af9-430c-2859-08d71a5a2be2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4043; x-ms-traffictypediagnostic: DB3PR0502MB4043: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(136003)(39860400002)(396003)(346002)(199004)(189003)(13464003)(486006)(102836004)(107886003)(54906003)(68736007)(6246003)(33656002)(5660300002)(4326008)(81166006)(81156014)(8676002)(316002)(8936002)(478600001)(66476007)(2906002)(110136005)(66946007)(14454004)(229853002)(25786009)(305945005)(7736002)(3846002)(476003)(446003)(11346002)(6116002)(99286004)(256004)(66556008)(14444005)(64756008)(74316002)(76116006)(186003)(76176011)(52536014)(26005)(71190400001)(71200400001)(66446008)(6636002)(6506007)(66066001)(53546011)(9686003)(53936002)(55016002)(6436002)(7696005)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4043; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lieRNajJ8qsnYOZ2a55fYYyPqWjSjD4kC40VF/39xmBcTMTPFqEPVUFAcv64cT0lcSY6afalddVcDqm/GZf2Bzv86GGZDLUq3T4XiGXYAgffRCP/gdvFHEm6rW1tvoKfX3Kme8SHJ7k9WNN5hjI1eP1+54e1EusDEUNeqGcAa5ON4VYFr32z4xRg9+R15ExDtnLILYiggisQbZ9ObmYO06HDylbVURwT3QvlzzkFeetb3s5Zdlzk2vQKVqhgoDCavzqXmYSll3fgbS3JDR8k5FTkEx7KdX5hWPVpXxpDtr6FSWIUt57dH/J/WtYTXW1zQU2QwR6xCFsXmXCGgrKSzNvgRnFk9zQsJvI3DX7M9bk0eVhW09xvRv0oW0+WOsUnzs9ysIXL0qxV5zJVNA+PH/9ttgUsiDZ2iXyftBZ/MsI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22def105-9af9-430c-2859-08d71a5a2be2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 10:38:07.8337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4043 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, July 24, 2019 2:32 PM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; Jack Min > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP >=20 > The RSS expand function for IP-in-IP tunnel type is missed, > which leads to create following flow failed: >=20 > flow create 0 ingress pattern eth / ipv4 proto is 4 / > ipv4 / udp / end actions rss queues 0 1 end level 2 > types ip ipv4-other udp ipv4 ipv4-frag end / > mark id 221 / count / end >=20 > In order to make RSS expand function working correctly, > now the way to check whether a IP tunnel existing is to > check whether there is the second IPv4/IPv6 item and whether the > first IPv4/IPv6 item's next protocl is IPPROTO_IPIP/IPPROTO_IPV6. > For example: > ... pattern eth / ipv4 proto is 4 / ipv4 / .... >=20 > Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel") > Cc: jackmin@mellanox.com >=20 > Signed-off-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5_flow.c | 8 +++- > drivers/net/mlx5/mlx5_flow_dv.c | 79 ++++++++++++++++++++------------- > 2 files changed, 53 insertions(+), 34 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh