From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34881A04C1; Tue, 26 Nov 2019 10:21:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524A72A5D; Tue, 26 Nov 2019 10:21:04 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60084.outbound.protection.outlook.com [40.107.6.84]) by dpdk.org (Postfix) with ESMTP id 39322CF3 for ; Tue, 26 Nov 2019 10:21:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8ffhZ2GPabpkTBkT4gAQ1tbIubfYXbGnnaDxwI0Xj8X1X/vSIzdrwh/z9jp4GBwDYIugW4NIqE8HfFUHr8bNRFpRkG+t7K/H1/I9lozEnVEIwcQbV5MYFrBz9Qh7cVes3km8E5F5biV1HMXhiTmPCbtO8D7K95IL4OBA4yBPxVwomXb3gzsd2vOko5bIAaTMmZJYdS1CvRCrmfJwbf8D3O/SKiMrKBk8gHjbsovGpM2Vj1lN6Asl+MLQmX25eH59GovjAQkQm3olLdTK+HS20nkyTBM6xAg7/zAb/LAxBbLwtGfyoFUsMCgFso94vqSNXyvqCyKJ7pNANXZjCOqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h1tw+rfqhc9K/zWHWkYW8J7LP4kEQr+r/aCTJPD5u0c=; b=WLT1t95x62UmidoXHhkEk5Z1DcpkTO2kM5yuiEzm/5AR924bxU6IOMNYX50hVdhO3kcjyUAnK+v8g2NZdVUVpFmQn2slkGAgKBiTyZc/4/0xD9EbYvturbfweJ6akV7JbOAD4AUYOfvxLLLfVcaUTacgig/jIW0ksXiqzIXI5I+614KUNTf8WYnfjE1mLGaIUgS+nrudDlrsEdHTzKlb43S0RUn5YPVnK7wGDVj2ZYuLdnZZUxfdxTVdxLkpN3oOnBROkPtzowtFU/8y9Wv0fbqGMJiErW1prXSu5oR/Iq6lTThpU5cny0XfE2mTrIPg9dfUHm4VCJfUCKKVYNuL+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h1tw+rfqhc9K/zWHWkYW8J7LP4kEQr+r/aCTJPD5u0c=; b=BEsCL8a95NiqJ97oYYrxHcn50j/Zrvi1F2os31nxw+WCxN2Lxn3zEeqhqaW77Y3biUleRQG6QmT7rKszgR2g0hFJxwRpkg9Ccro95dsiBh/EWZ0dDFTZkJk5R+KqyeOkfKJHxhDKOEUv9Kw1Zt2HyU/J/yTke2aeiD/R+8NCcKI= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.22; Tue, 26 Nov 2019 09:21:02 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2474.023; Tue, 26 Nov 2019 09:21:02 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver Thread-Index: AQHVpDRvp48YIFpNGUeVMm7WdoIOkaedLSSQ Date: Tue, 26 Nov 2019 09:21:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f72b3677-f1bf-45db-f997-08d77251f4e5 x-ms-traffictypediagnostic: DB3PR0502MB4058:|DB3PR0502MB4058: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0233768B38 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(346002)(366004)(136003)(13464003)(199004)(189003)(229853002)(186003)(25786009)(2906002)(66066001)(6306002)(9686003)(26005)(55016002)(8676002)(99286004)(81156014)(81166006)(6436002)(45080400002)(305945005)(33656002)(7736002)(8936002)(66556008)(966005)(478600001)(66476007)(64756008)(66946007)(76116006)(86362001)(11346002)(52536014)(66446008)(74316002)(14454004)(256004)(14444005)(6246003)(4326008)(446003)(6506007)(53546011)(102836004)(71190400001)(7696005)(71200400001)(3846002)(6116002)(110136005)(316002)(6636002)(76176011)(54906003)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C1jufT/gCHNzLhwsu99AALmzQExRpFWB2crwZcRFzsleXU5guxAjT21h7oq+s2aFafNDjWZWR3yp2pe3ybkkJPQXjaVJDbj80f1THSKXWXis9110fdtBxgAVykM+aaAOvhgk/nI/5Jp22WdInRAaj5XZC6/luhlUGVZoYUsyFxjH03FUIhixD9aIwIRnayDpeCqLHhYtKOYSOEkZwAxjX+/m62V1CqACi/kRS61spA3KCmPPaz8I7FTSv/pr2oOMhu/9Gw1Mnv5Zr1TZ0VLAB3oC74pGhxGOkltxe3pQRRvhuVP4I8fuAZYUEEoOcGvdiyatWb+LMGH2PzaqdIbCCZZueC0UG2qMD62uF+wiltqvLqOjCwz+0gAprKDfi8Rp+7r/Q0Htj4j02qq1P8S9nT3fmvqzvkROsTe+PvQKcaRLoH5NZHTN9JAWFTX2I2HA Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f72b3677-f1bf-45db-f997-08d77251f4e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2019 09:21:02.1025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JuIgHodoEHzjQIScCEKzra0ejESiwinnQww3UrDWghBA0ayVwrmV6UUy3Zcd602tos1v/UrNcCo5HYhX1SRYqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, November 26, 2019 10:34 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core > ver >=20 > Recent patch [1] sets the DV (Direct Verbs) flow engine as default. > Newer versions of DV flow engine use the DR (Direct Rules) features. > DR is supported from RDMA Core library version rdma-core-24.0. > This cause failure to start port when using older rdma-core version, > without DR support. >=20 > This patch selects DV flow engine if rdma-core version is v24.0 or > higher. Verbs flow engine is selected otherwise. >=20 > [1] > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > es.dpdk.org%2Fpatch%2F61900%2F&data=3D02%7C01%7Crasland%40mell > anox.com%7Cdb36281e31894da1c6cf08d7724b90cb%7Ca652971c7d2e4d9ba6 > a4d149256f461b%7C0%7C0%7C637103541194195326&sdata=3DaWt67T9fB > Hliav7wUm1gFNHHmJh8jnWYqKNTCTA1D6Q%3D&reserved=3D0 >=20 > Fixes: cd4569d2bf3c ("net/mlx5: change default flow engine to DV") >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam > --- > doc/guides/nics/mlx5.rst | 2 +- > doc/guides/rel_notes/release_19_11.rst | 3 +++ > drivers/net/mlx5/mlx5.c | 2 +- > 3 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index 2080766..771970f 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -673,7 +673,7 @@ Run-time configuration > - ``dv_flow_en`` parameter [int] >=20 > A nonzero value enables the DV flow steering assuming it is supported > - by the driver. > + by the driver (RDMA Core library version is rdma-core-24.0 or higher). >=20 > Enabled by default if supported. >=20 > diff --git a/doc/guides/rel_notes/release_19_11.rst > b/doc/guides/rel_notes/release_19_11.rst > index 48c80e5..928698e 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -193,6 +193,9 @@ New Features > * Added support for matching on packets withe Geneve tunnel header. > * Added hairpin support. > * Added ConnectX6-DX support. > + * Flow engine selected based on RDMA Core library version. > + DV flow engine selected if version is rdma-core-24.0 or higher. > + Verbs flow engine selected otherwise. >=20 > * **Updated the AF_XDP PMD.** >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 59ae408..8abd1b1 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -2428,7 +2428,7 @@ struct mlx5_flow_id_pool * > !defined(HAVE_IBV_DEVICE_COUNTERS_SET_V45) > DRV_LOG(DEBUG, "counters are not supported"); > #endif > -#ifndef HAVE_IBV_FLOW_DV_SUPPORT > +#if !defined(HAVE_IBV_FLOW_DV_SUPPORT) || > !defined(HAVE_MLX5DV_DR) > if (config.dv_flow_en) { > DRV_LOG(WARNING, "DV flow is not supported"); > config.dv_flow_en =3D 0; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh