From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFF0AA04C1; Wed, 13 Nov 2019 12:59:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A347E2B8B; Wed, 13 Nov 2019 12:59:12 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30058.outbound.protection.outlook.com [40.107.3.58]) by dpdk.org (Postfix) with ESMTP id 07EE72B86 for ; Wed, 13 Nov 2019 12:59:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZPK0FAhlw2oQcUVdlMFd8P/iBvaZvdod74bv2IsWNr+V9A4bLeqs3k2GZg3oErX2d9I71UvyaK3HZepLO2awEpLElks4/vsD3daCFDSq6oJLAFA6DHGJbVtBQ937AO6zXdxvmzLpCAnmFfaKFAXD/DQ9QzwXXdkKdk+cump//QKZWZSY1GWc3gX99Bn5s01mrFJDmRL50XPtykiELuP9Wq3dh9G8Cy3It9lF/5386jX513aATCpN9QnVFXFznm+uoK4czsvQKtMMCjBBjwZARzGl+xQgS32sJltEQaq6GIcYAa69p2iDqpjtbLOsj1I6BNKSxbKfN+FinsayKt9Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ETC7xCl/Ajpv3YyOnyJY/CJRu97u7dFc2ybMu2YPZ8=; b=fqnXgj0bqrurzjKiu0E36YOLKEgT0zqB95PDoTN+oa9orCXMBJG+9rWHSvhGu/EKsYcsRWP34nvAj8S6rLoGhHD/TTQqvup/Xrktw6rQVuksdWNqqc1GFb/jEYPZc1Dej4mpiQxQkmk0D1XBeW5MkmR6BVeQg6TF92wZXeh9IXzdNQl0aRbfn9i7tuTQxq4t5iV4PtCY00O6UYnEFr9LbrOGFtjMx6Rq0atainWhbHtM6JaZY3ESuEYlajs3XZqsCxTLOk7KmfAQPCgnm5JTEZSIBzKeEVWVIHXlLEivdTbjNyZe9XUwJ60e0bO4Eb4gklUJMTWeS2aHChoLp/ZQAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ETC7xCl/Ajpv3YyOnyJY/CJRu97u7dFc2ybMu2YPZ8=; b=jmlY+lnvVT2MugQZpkZiMtVVQPOlweu/JVSRED9VfSXIEG+SJZvJhDiv4qsHepZcgnITD1dp+c4zip03i3mINeDrQFuJhL5CiVkWmssdcX5pV+XK+GkpGmTAFyS1QV3nhUVdOUv4xY0zXTbGJuWp+Rh0ydsm7xGdwMtDgnxcjYY= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4028.eurprd05.prod.outlook.com (52.134.68.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Wed, 13 Nov 2019 11:59:10 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Wed, 13 Nov 2019 11:59:10 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query Thread-Index: AQHVmWQ9zOd7zrZ5I0qXgeydQfHZtqeJAKBw Date: Wed, 13 Nov 2019 11:59:09 +0000 Message-ID: References: <639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com> In-Reply-To: <639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: eba8d1a5-66e3-49ca-84c5-08d76830e4b1 x-ms-traffictypediagnostic: DB3PR0502MB4028:|DB3PR0502MB4028: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(13464003)(199004)(189003)(7736002)(229853002)(25786009)(66066001)(478600001)(14454004)(76176011)(7696005)(102836004)(6506007)(53546011)(486006)(11346002)(446003)(476003)(26005)(186003)(33656002)(6246003)(305945005)(74316002)(6436002)(9686003)(4326008)(6116002)(8676002)(2906002)(6636002)(55016002)(81156014)(81166006)(8936002)(86362001)(316002)(66446008)(3846002)(110136005)(64756008)(54906003)(66556008)(66476007)(14444005)(256004)(5660300002)(99286004)(66946007)(71190400001)(71200400001)(76116006)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4028; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DJo3zzRM9Bs3zhFMRXstHF5Rf4Y9hF0tNdKFFUeMQD8jF5MvVq6AABSGUa9vaiJ4PhpOoHHc3kSvO81oVGkRXXGcT6u6/lssMWXTINmnN/en1DlR12YnSbZfN5BJ91Ay4nVZn/A2EzgRlraTJeds2aAq7FELlPq4v+2qGjFADdSpAVG7hN/O3ww+iKKfFyT64bBG0uj0YD1Vi7bbcasyoABsqG39m8DKWDsSmmZ8NwUtNb0ourwgss4SwDSteBbYTDp84vzhXUBCl0jFmw2JVezwZM44TYPBaJnc7Fs/5z8KgWnQFVVkzUmm/JF2DVpW8nC/URCqgcaNwXqjUR6CObyfUQpPNxSgn2Awy4QU13vBryFecEKOAWFQzm3+B57a5ry3HcQxW8OaXNHtOx3h6ZiNzXSlmq1p9Ezf2ym/jqA6i1ylpbxY/TEENMe7zbdA Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eba8d1a5-66e3-49ca-84c5-08d76830e4b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 11:59:09.9073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UA3rMn5LHKPVQDyhF4sLbnsJsaX7XwzTQbvLmbKrvtnqmXb1kEEOfNuYsUPqEDUZsh5XRr+F4JVY0GSCSx2WXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4028 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, November 12, 2019 4:19 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query >=20 > Function flow_verbs_counter_query() was recently modified. > The new 'if' condition uses a pointer to flow counter-set. > This pointer is valid only if flow contains a count action. >=20 > This patch adds check to verify the pointer is valid. >=20 > Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows") > Cc: orika@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index ea85fa1..c787c98 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -191,7 +191,7 @@ > { > #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42) || \ > defined(HAVE_IBV_DEVICE_COUNTERS_SET_V45) > - if (flow->counter->cs) { > + if (flow->counter && flow->counter->cs) { > struct rte_flow_query_count *qc =3D data; > uint64_t counters[2] =3D {0, 0}; > #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42) > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh