From: Raslan Darawsheh <rasland@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
Date: Tue, 23 Jul 2019 06:39:46 +0000 [thread overview]
Message-ID: <DB3PR0502MB3964CDCB7D21D82E44C3CAC1C2C70@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190722102002.300f2640@xps13>
Tested-by: Raslan Darawsheh <rasland@mellanox.com>
Seems OK for me,
Kindest regards,
Raslan Darawsheh
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, July 22, 2019 8:20 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
>
> On Mon, 22 Jul 2019 18:02:09 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> > > MAC address parsing was causing failure [1], this patch partially
> > > reverts the commit commit b5ddce8959b2 ("app/testpmd: use new
> > > ethernet address parser")
> > >
> > > [1]
> > > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth
> > > testpmd> dst
> > > is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad
> > > arguments
> > >
> > > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> > >
> > > Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> > > Cc: Stephen Hemminger <stephen@networkplumber.org>
> >
> > If there is no objection, or more proper fix, till tomorrow morning
> > (europe time), I am planning to merge this one, fyi.
>
> Works for me, testpmd always has the cmdline library anyway.
next prev parent reply other threads:[~2019-07-23 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 16:58 Ferruh Yigit
2019-07-22 17:02 ` Ferruh Yigit
2019-07-22 17:17 ` Ferruh Yigit
2019-07-22 17:20 ` Stephen Hemminger
2019-07-23 6:39 ` Raslan Darawsheh [this message]
2019-07-23 10:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB3964CDCB7D21D82E44C3CAC1C2C70@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).