From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56472A046B for ; Tue, 23 Jul 2019 08:39:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3CA21BF85; Tue, 23 Jul 2019 08:39:48 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id BF3061BEB4 for ; Tue, 23 Jul 2019 08:39:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bVBxdN5UVK4iKOj4zw2YIlyCEmn74A2YDyZcAFemsjm2XGRZN1n2mw+x+Gm7M+3njRBTE30qr0mjpF45/GwdF818bl8xwouOIQjmAcpTPfBWiv7Otq/d8NQR6Y8zBY+XOe0J2XI1jiLwh0CAUtHvkOixQbWWBFrLpcCicILqileCZveK+hZ0wjMriea5iEIdWNN+pqCXUbVVic19RhAfUrOcOoOLEOHnZ8nda5k5JbC1TKJl4UzM/vscAgAHLvKn6M+HgQ5YoKDMPtmu+lFUhmexbEYduTZKPQkXsjcjJrmHbhOSgmEsIGQbS7GWEpDOw3KCx7wcW2Vulxts9x8h+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OBAMVTjicpZb4/omOPeLywr94NiAtZXxqCKKkTRkqI=; b=Qx7IsHJu5w4UFb8U9nCAnAkSf5dKi9snQqZu+ABuoXdSb5Ou5hSMPzMHGthsF/Xrns6NxkJI8FQYTLUm0SdlJTdI8CI0KN4Z8enN8llW9EM7tqGo/KvPKd23EwDme3I06tGbXofbKoWf4ZtNfjJev+vCEI7N8UiZVx+qmCLY1M6BadesJgats/5CqU00r1TB9MhOmLdVZ4EPC4cQA0hR1z4VJrfZ/gpm1a7bCpUtIL2hFE310L9JpxwuRlxYEGaP74Tn/NpUQCA+oTp5FntfAQIJkyTdbnf0KtbXWqGn+4jiL7M/VQXYHRCwDXo99zHEYkZtFY0k1ZJBkbYVMJj3fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OBAMVTjicpZb4/omOPeLywr94NiAtZXxqCKKkTRkqI=; b=rSK6Hsy5bxUv/7+wcZFkxOAXTIIq/TNFZdx2rDvTSw56STIZYVYmLbyAPgWQvDBgX09UyUEsXSv8h85I1quFHrBLP1VzGDdGTQTuUJl5UIJtrKXqTFzqtmaNLF3uERVK1+hi3ERHJpatIYX9gy+yLMZZDl0ZyaslV3lCl+xP0cw= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4073.eurprd05.prod.outlook.com (52.134.68.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Tue, 23 Jul 2019 06:39:46 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 06:39:46 +0000 From: Raslan Darawsheh To: Stephen Hemminger , Ferruh Yigit CC: Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow Thread-Index: AQHVQK621c8n/RkXakqMVpACmIrWQ6bW3QeAgAAE/wCAAN8lwA== Date: Tue, 23 Jul 2019 06:39:46 +0000 Message-ID: References: <20190722165832.38054-1-ferruh.yigit@intel.com> <6167ab0b-c37e-fef5-5fdf-3162e58f69ee@intel.com> <20190722102002.300f2640@xps13> In-Reply-To: <20190722102002.300f2640@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0561cd1-f8f5-4969-d958-08d70f388d9c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4073; x-ms-traffictypediagnostic: DB3PR0502MB4073: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:597; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(13464003)(199004)(189003)(6116002)(11346002)(186003)(66066001)(6436002)(446003)(476003)(26005)(53936002)(102836004)(33656002)(478600001)(8936002)(14454004)(25786009)(256004)(14444005)(486006)(71200400001)(81156014)(110136005)(305945005)(7736002)(316002)(3846002)(4326008)(74316002)(81166006)(99286004)(8676002)(76116006)(86362001)(6246003)(54906003)(66446008)(71190400001)(64756008)(7696005)(5660300002)(55016002)(2906002)(68736007)(76176011)(9686003)(52536014)(53546011)(229853002)(6506007)(66476007)(66946007)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4073; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: VPkOnoJb+PG+Py9dCPUQwjvZVaTh5+XhjD10VAxMWeWQkkggSgeV7M+Ob1VkH7QZoKwOXAjNHVp/Lkmyvy0rbOGq96N2Mq4BjDvqdutRBvi/n1PKwOgDI9m6H+/CmqtuXo1ugB4GoHwf8xSDpofKFFJcZnuwW6zmSiK8vjRODWvEI+2KdP1qlkiMmOYmM7z3H4vdgpz4xVg4yhA9ZPrmynymrXhj/tARil61+Rb1LOK9fitxPSasqysFBb/AUICaOCGmYuXMnhdcKPjclB9bq1DkYYaw9Hvph9KpAGUlM/jD//BQp8MxQcZA9nLFhtNZan07VpIvs/p7pctndthmPBupIwkvwibdREqtSJRINDrWFrOcE/Erx34kjib/TgK0cFiSUFASbxx6LIoFDpUR8HxDKS+Ga+15GvCN4DJino4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0561cd1-f8f5-4969-d958-08d70f388d9c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 06:39:46.3637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4073 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Raslan Darawsheh Seems OK for me,=20 Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Stephen Hemminger > Sent: Monday, July 22, 2019 8:20 PM > To: Ferruh Yigit > Cc: Adrien Mazarguil ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; dev@dpdk.org; Raslan > Darawsheh > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow >=20 > On Mon, 22 Jul 2019 18:02:09 +0100 > Ferruh Yigit wrote: >=20 > > On 7/22/2019 5:58 PM, Ferruh Yigit wrote: > > > MAC address parsing was causing failure [1], this patch partially > > > reverts the commit commit b5ddce8959b2 ("app/testpmd: use new > > > ethernet address parser") > > > > > > [1] > > > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth > > > testpmd> dst > > > is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad > > > arguments > > > > > > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser") > > > > > > Reported-by: Raslan Darawsheh > > > Signed-off-by: Ferruh Yigit > > > --- > > > Cc: Stephen Hemminger > > > > If there is no objection, or more proper fix, till tomorrow morning > > (europe time), I am planning to merge this one, fyi. >=20 > Works for me, testpmd always has the cmdline library anyway.