From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E659CA0352; Sun, 3 Nov 2019 15:27:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51CE51E874; Sun, 3 Nov 2019 15:27:40 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30050.outbound.protection.outlook.com [40.107.3.50]) by dpdk.org (Postfix) with ESMTP id ED9BC1D420 for ; Sun, 3 Nov 2019 15:27:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffyLWxoKYzgDoqOmmPa/3f1X0+AlAH8et1cf9jXM4HZOjmNYID1S6gmAaailMBkoFI6ew3sLLwrCQOl8vULblVLKw2xqA/uKnw+2rpf8A4Kza6oE2XcoV3v1YV/ozpqjmJEtztj3+tS1TfhktxMAnA5GyKEULZeCkZAhbC8rP4PFWptFjZEYbNzHBIoztJQgqO76Q6qr7EIoLF149f8Z8l8+tp0QWyK2jRKu5LgYSVfFhzC6Jbkm1ug1CCmDV25HXAtB5Pri9H48cPz2a0lysLpCKeRzDAqRzetPjYn+TwEk8iqK7fNuwN/bCkEdpRiH4YexwtmcytCAIlw/VrhUfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvucrbtq86NF66b8mtJvB4YMSf6SqTeM5pPTdtjfPK0=; b=Z3+mTT2PiI7PSmJwRTxSEYl3rLWoFjgbBkc1pk5LGrPOg6XRIggsOw6FsFPm0TN7IbGvVmSJfSxhRuyD1cf5yThYBD4OLe7S5XqqRpQdC0l2FUrSZdJcjRtThtMZZj18WgLnw5pEp/09aWmDoTCD6sDsnQ3m6sPu76ZCek6OFEPqJh7hl7oqiXANJr2TwMW4wNjNmN80a1jsmcBFuXR95hPzgBJoUvOoUBKe1ECCI2n+wGFn1cQW4EPxMSZQuBB+e9pJquNjR29BaP2H99PMW/29t1+jE9Jocs1+drc7qp+07nrqtPeF3gQxUpUUAmP12tSARIM/9e1SeR37GXgDkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvucrbtq86NF66b8mtJvB4YMSf6SqTeM5pPTdtjfPK0=; b=pRNt017Csqitcl5teOWco54U2Nk2tMtEMNCUdCsVkFKTerCsOK9mJjkEb39gSA4r33qikxsZZZvrAx7y9P+HUmAomgJkJ0CNygKKSKrogZkzXzwq1hQGxaNWXvi28xWfCfZZLt8/AfH+bEeT7gg1TXlvFQWzsuBXe20fa/wUzr0= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4044.eurprd05.prod.outlook.com (52.134.72.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Sun, 3 Nov 2019 14:27:38 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b%5]) with mapi id 15.20.2387.028; Sun, 3 Nov 2019 14:27:38 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , Moti Haimovsky Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header Thread-Index: AQHVkFRE82+zalffrECME2TbCefXb6d5hNCg Date: Sun, 3 Nov 2019 14:27:36 +0000 Message-ID: References: <3044c96c749c83daf43e85754113c5bef68af855.1572571554.git.jackmin@mellanox.com> In-Reply-To: <3044c96c749c83daf43e85754113c5bef68af855.1572571554.git.jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 87d28a24-2a05-4234-445c-08d76069fa1d x-ms-traffictypediagnostic: DB3PR0502MB4044:|DB3PR0502MB4044: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 0210479ED8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39850400004)(366004)(376002)(136003)(396003)(13464003)(199004)(189003)(486006)(52536014)(53546011)(6436002)(9686003)(6636002)(71190400001)(71200400001)(26005)(55016002)(186003)(110136005)(66446008)(64756008)(99286004)(76116006)(66946007)(7696005)(66476007)(66556008)(14454004)(86362001)(54906003)(33656002)(76176011)(81156014)(81166006)(8676002)(316002)(8936002)(102836004)(5660300002)(229853002)(476003)(107886003)(66066001)(6246003)(6506007)(478600001)(305945005)(3846002)(6116002)(2906002)(25786009)(7736002)(74316002)(256004)(4326008)(11346002)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4044; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T7wFcJNHk/BrxgF+xueCCTxiY3sS1aY+3IZXq/PFKkDepbgqq+N3fhhZl0+59IqI6dDLUozZNyg9qoaZWdPeBUIbuEwErQFCiy3YFun0YJlQt5PickTAMxObEOrZLFpcTcpuAPXDgMd5Osuo23Q6G75eImHFV7j8l/tKaYk6xdYCEhjGuMSjm3vr8JL6U5NmA1jPM/fGbUfZF9FHN4loWXxF/VyulSd08HXwu6mFsJOmgfV63fY7JgEEWuJnJT3E2wxg93xVHhec9ELGJh7ttec52tF9ulMiOLNtYSXSais6Pd8/W/uf1CiAMnhYiN6vjFcDLC0uGwux0kCFWGFeFcjVJdRYNePtn2FTljfiOklP+bFbj92Mi0ZrCALGQEB9XFCBEdBqb18L9GvkjlmcNm4ytNTWYQj6vtemVq7yMlLJ+enj83smhRgtJwRIE7cH Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87d28a24-2a05-4234-445c-08d76069fa1d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2019 14:27:36.8815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rI1M6Z6C6bsy2S79WhHfNOJXXWhCX0df2CApjmlOhFiDkyDx8/guX7lGDIjDzjLA4wFp2b31vm9IjFDhkgF5sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4044 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN > header >=20 > Currently if user want to set VLAN id/pcp on an about to be pushed VLAN > header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_ > action of_push_vlan: >=20 > [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ... >=20 > This is misleading because people think rule [1] intends to set VLAN id > on the existing VLAN header and then push one new VLAN header on top of > it. >=20 > A more natual way to set VLAN id/pcp on an to be pushed VLAN header > should be: >=20 > [2] ... actions of_push_vlan / of_set_vlan_vid vlan_vid 2 / ... >=20 > Fixes: a5f2da0b816b ("net/mlx5: support modify VLAN ID on new VLAN > header") > Fixes: 68fad3635042 ("net/mlx5: support modifying VLAN priority on VLAN > header") > Cc: motih@mellanox.com >=20 > Signed-off-by: Xiaoyu Min > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh