From: Raslan Darawsheh <rasland@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables number
Date: Sun, 4 Aug 2019 10:29:15 +0000 [thread overview]
Message-ID: <DB3PR0502MB3964DE42183C4068475695FEC2DB0@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <dfd655fdf1c72229ab777db735dce3ef7b039b1f.1564665506.git.dekelp@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, August 1, 2019 4:23 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables
> number
>
> MLX5 PMD limits the number of SW steering tables to 32.
> This patch updates the limit to 65535, to allow wide range of values.
>
> Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch")
>
> v2: remove Cc to stable release, not relevant for this fix.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.h | 4 ++--
> drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index caf2491..f559f83 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -513,8 +513,8 @@ struct mlx5_flow_tbl_resource {
> rte_atomic32_t refcnt; /**< Reference counter. */
> };
>
> -#define MLX5_MAX_TABLES 1024
> -#define MLX5_MAX_TABLES_FDB 32
> +#define MLX5_MAX_TABLES 0xffff
> +#define MLX5_MAX_TABLES_FDB 0xffff
> #define MLX5_GROUP_FACTOR 1
>
> #define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 9c0a261..14e70ed 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2817,7 +2817,7 @@ struct field_modify_info modify_tcp[] = {
> (error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
> NULL, "group must be smaller than "
> - RTE_STR(MLX5_MAX_FDB_TABLES));
> + RTE_STR(MLX5_MAX_TABLES_FDB));
> }
> if (!(attributes->egress ^ attributes->ingress))
> return rte_flow_error_set(error, ENOTSUP,
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2019-08-04 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:37 [dpdk-dev] [PATCH] " Dekel Peled
2019-08-01 13:22 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-08-04 5:43 ` Slava Ovsiienko
2019-08-04 10:29 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB3964DE42183C4068475695FEC2DB0@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).