From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD517A2EEB for ; Tue, 10 Sep 2019 14:08:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BB1C1EC61; Tue, 10 Sep 2019 14:08:56 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by dpdk.org (Postfix) with ESMTP id 3761E1E8EE; Tue, 10 Sep 2019 14:08:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OStWpfWUCykTa5Zogu3y2fsqVAV9I6UqVNKWFwG08MAdmArBVOeUyXhJjpj8DwpoeMlVJN8Zmu7FKhMFgvQyHK/TZr+t95GIjJmZBodXnVSlGSVq/VB0UEuEIa84odRjByTbFPr+l4vNWVfdHKGaowG1uPtbu/JolZmdFx5inJ8hJRZYWx1o2AjhrLwYFmkUAZuc4tgDbePSofSyiMRx+mqn6f1rNmeRC9zd39O2oR8aMBzdOgPDQz2dGKFwPOz0TQJUdm1QeGitF9jQFvUfyf2JPuRTn07X59a3vB8sdWrTvEA+8OFvPSdYfOXF/Qwmn1PU9/Ge3AQRBp2lLlUXjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmLtjgweAiIueY2wzMrwRPUqBw2QRucClC4kv6zthTM=; b=dHhbk+7hGqUxHjWI6g43J8UPl1+ZCakDXzkx3sqfLfUNEp4GZzG6JDq0c+W0ASdxKqZw3I+CJdpSEH5MVoSRRTapi5/8CWmbmWqJhRRs/RI89a2hr3x2T8eVUx824Y1EvOG7qhAQf7Pq9WmRd3R5MILQ2knauvXzdhBn7NP0/lqhl2u2mIyI0UkJbvD0L2yI1fnTP3HeNuXvuqBlHBXP2aZ4F+hLepjgUB/kABlKt2yOIXyJVcKegyRFrxTLhuAaFCtEv03OWykUlT/oMzSJ6P3VGnBX5ULe0h3Oiju2e5j27K7UJPMJDSaZppdfQAe6LG5JdTAAh3eQYc65T8MG2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmLtjgweAiIueY2wzMrwRPUqBw2QRucClC4kv6zthTM=; b=amkib/bfh2FXA6FEAx/+lpmewA/dF2yur2yEHJiGV0LNRipa60m6YqvnxQIJ3MP18W63bPU6F18nrg1GG5DPqcn+PxzVJv8WoHDmdjBEopRoSRoMSyHk643raoruoiHtGSMSToKE/YFIcs5OjOq0z9D9cbefDfG5Xwp13KUCXow= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4026.eurprd05.prod.outlook.com (52.134.72.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.19; Tue, 10 Sep 2019 12:08:53 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::75d2:b478:8f56:e4fd]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::75d2:b478:8f56:e4fd%4]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 12:08:53 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions Thread-Index: AQHVYlQOFncETO+xZU2NQ15XasONVqck3Ecg Date: Tue, 10 Sep 2019 12:08:53 +0000 Message-ID: References: <1567514105-24264-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1567514105-24264-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8cbc084d-e7d9-43f0-b629-08d735e7a5e7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4026; x-ms-traffictypediagnostic: DB3PR0502MB4026:|DB3PR0502MB4026: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(199004)(189003)(13464003)(4326008)(6246003)(6116002)(3846002)(4744005)(6436002)(229853002)(2906002)(486006)(71200400001)(5660300002)(66066001)(14454004)(81166006)(76116006)(11346002)(476003)(316002)(110136005)(54906003)(450100002)(25786009)(446003)(6506007)(102836004)(53936002)(186003)(478600001)(74316002)(52536014)(33656002)(8936002)(7696005)(76176011)(9686003)(26005)(55016002)(2501003)(71190400001)(66946007)(66476007)(66446008)(64756008)(66556008)(7736002)(305945005)(53546011)(86362001)(81156014)(99286004)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4026; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s2DYeTkWAaUl/T4TaeNfAKKStjt9brUw5rHDIj1IR6n/PhUC/eljtAhCwKnc2RdmMvcpEB+9cpzLCS67OkCWZ1keqDpB06PnjsmK2wEIP/QyhcLwW6/mCPeV+ijgNmQInYKDWyRE5trGWax5gAxUno2EMoRdTF9g7JMNQnUBQhxHhok//uDrMF6G7LU1PThjGD2FJEkTw43pr/UcM7QeAluejotxp464PSYcFz8UkdqHtRo5AiTkM7jubS/Wf6qtMRtZ+kqhlLpqH2E2QE0AmX+7BqnGGnuc0Xt0ino1PfjPWV3PCcGlB71gaLYoyfjIjQ2oz0F9TcGaAq9vLNtub4dYsd/hhAQrENaQp12cYluMGfQR7kDOtKiQuFJa3oKaBGGCCTXhi2A5HfpFL+CexIYECkz43y85EeQ7BQmPY/g= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbc084d-e7d9-43f0-b629-08d735e7a5e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 12:08:53.2098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mJ6qvueucfU6PPJ3QcA4lxFTc1m5mSIevnB/HLWUnIHNRhQ7oT8yfgGfFK6OSQHbRvP/WpXZ+0Y2Gk2W2PPDXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4026 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, September 3, 2019 3:35 PM > To: dev@dpdk.org > Cc: Matan Azrad ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN > insertions >=20 > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length = is > not adjusted. Also, the ring buffer wrapup is not handled correctly. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh