From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter attributes
Date: Tue, 12 Nov 2019 11:41:57 +0000 [thread overview]
Message-ID: <DB3PR0502MB3964E577AB3087802EB4006DC2770@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1573548838-11322-1-git-send-email-viacheslavo@mellanox.com>
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Tuesday, November 12, 2019 10:54 AM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix query host adapter attributes
>
> Host adapter attributes are queried from kernel via multiple
> DevX calls. The retrieved data were erroneously overwritten,
> the order of querying is fixed.
>
> Fixes: e470ec789d4d ("net/mlx5: fill meter capabilities using DevX")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_devx_cmds.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_devx_cmds.c
> b/drivers/net/mlx5/mlx5_devx_cmds.c
> index dcb7609..9893287 100644
> --- a/drivers/net/mlx5/mlx5_devx_cmds.c
> +++ b/drivers/net/mlx5/mlx5_devx_cmds.c
> @@ -335,6 +335,11 @@ struct mlx5_devx_obj *
> attr->log_max_hairpin_num_packets = MLX5_GET
> (cmd_hca_cap, hcattr, log_min_hairpin_wq_data_sz);
> attr->vhca_id = MLX5_GET(cmd_hca_cap, hcattr, vhca_id);
> + attr->eth_net_offloads = MLX5_GET(cmd_hca_cap, hcattr,
> + eth_net_offloads);
> + attr->eth_virt = MLX5_GET(cmd_hca_cap, hcattr, eth_virt);
> + attr->flex_parser_protocols = MLX5_GET(cmd_hca_cap, hcattr,
> + flex_parser_protocols);
> attr->qos.sup = MLX5_GET(cmd_hca_cap, hcattr, qos);
> if (attr->qos.sup) {
> MLX5_SET(query_hca_cap_in, in, op_mod,
> @@ -358,11 +363,6 @@ struct mlx5_devx_obj *
> attr->qos.flow_meter_reg_c_ids =
> MLX5_GET(qos_cap, hcattr, flow_meter_reg_id);
> }
> - attr->eth_net_offloads = MLX5_GET(cmd_hca_cap, hcattr,
> - eth_net_offloads);
> - attr->eth_virt = MLX5_GET(cmd_hca_cap, hcattr, eth_virt);
> - attr->flex_parser_protocols = MLX5_GET(cmd_hca_cap, hcattr,
> - flex_parser_protocols);
> if (!attr->eth_net_offloads)
> return 0;
>
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2019-11-12 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:53 Viacheslav Ovsiienko
2019-11-12 8:56 ` Matan Azrad
2019-11-12 11:41 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB3964E577AB3087802EB4006DC2770@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).