From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E98FA04C0; Tue, 12 Nov 2019 12:42:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 870E32AB; Tue, 12 Nov 2019 12:42:01 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50059.outbound.protection.outlook.com [40.107.5.59]) by dpdk.org (Postfix) with ESMTP id E2E92271 for ; Tue, 12 Nov 2019 12:41:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Llj/qNDq/3PM7ofsAGBoKN0kl5WUzw/PGEPodD5oWzhdK5UeftEYwFTNDaq064k7aHdw+C/Niinkg7YivHgbtg/1cXUuY9Ty7Le5WjDp2R4EiesdwYsfTvd96oEJ/tTZIiLEfH+Cr93h91twX4RwoPnNrz5C5j0cvOB7nXSrB403M/4QUoLgTdl0DJeRiqv/M3JBZgs2b1QURNmBrtfKqhTx4J1XWq0nzSfvBupKWRlDSxI0TmVvbI6s359vLndn03SJKdEiYdtE/rSltw8pTwxE8FR4PXtATGuSRRf49bYMpeBmwcqlpOnSXsGume3iukcIW4RUvc9p9Z6vSXsmEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20wK+GK5Zal8NBaXKpsAsC0d1rTAJhFwqUk9MkpfL9M=; b=oLZlxhEgeUe/I0sLPBTP1egchkfww6eqgtGID8NH61mgf488yEfT30ZSBxbDgjNI+/+IsSbmEMNqX7FMrngbq5em3JcLi6SC5/wvKKp7TZFj4HRNjMQ0x/bbZ8xY/QaA6RNZl6utICw6OSW/l80KIi/80AAEgC8Z2woVggA2fbxeR9dk7c2YreohW83PBKzfyX3lrEIhRHZX9kEAD6FWg4BZPYgYA09aolpWjKyq2CXcFMkaWNGq52vQW0ZeOPdN6qfKHpOlcft1cE9wQ1sg1RCyggY4UBk7udn756SvZs6wAO01gUZj49jyQ5OUcGAYyNGV7vPd50gjsWI+Mf5Dmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20wK+GK5Zal8NBaXKpsAsC0d1rTAJhFwqUk9MkpfL9M=; b=AQpPvGm2sFGLZto0wXjkOGtivtUnPeJcjAczlkTmCQYnkzSyUfdME4HLd2y6RVQm+UGdPMb57WoCe050pnpxvlyGtTBrC1dPtKNXHoIDfXHEXGdx55mog5yy4jS4emoenH3Z3BkMcLeqp2eTNN7k9PPbCRsCyH1MJRDhBW8hZJk= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4076.eurprd05.prod.outlook.com (52.134.66.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.23; Tue, 12 Nov 2019 11:41:57 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Tue, 12 Nov 2019 11:41:57 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix query host adapter attributes Thread-Index: AQHVmTa9KDjYEtz0A0S52qOgaRnLz6eHaeCQ Date: Tue, 12 Nov 2019 11:41:57 +0000 Message-ID: References: <1573548838-11322-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1573548838-11322-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7d150ff0-d7ae-4aec-74a4-08d7676552e9 x-ms-traffictypediagnostic: DB3PR0502MB4076:|DB3PR0502MB4076: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:849; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(189003)(199004)(13464003)(76176011)(9686003)(71190400001)(11346002)(5660300002)(6246003)(478600001)(446003)(14444005)(256004)(486006)(476003)(81156014)(81166006)(4326008)(2501003)(8936002)(305945005)(7736002)(229853002)(107886003)(14454004)(74316002)(8676002)(52536014)(71200400001)(6116002)(66556008)(316002)(3846002)(66446008)(66476007)(64756008)(186003)(26005)(76116006)(33656002)(110136005)(2906002)(7696005)(86362001)(54906003)(99286004)(66066001)(6436002)(53546011)(6506007)(66946007)(55016002)(102836004)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4076; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BHPeFgiQ82gAyhBYEdlXQ/DYuySyG2+sbFfJW21lXm9JGT1q+KE4AO0AHHu6AnzK04XTV2RqRJr0bVmdknHTob9043V5WmuEpezg+glSwNGaWkDTHaXsH0KpFnyTJ1sNpRaJIgdabw68PUQlPp4LbFs9TFuHqABYFwiHaQXimKuKk/8WHuv+pPfr5102o45zh1XAmIlaImzC+BHUDqxJ0nbsjvOuLlqvt0bs4st64wLpaDnJj6O0NvTtKvW43AULpgdc4Kb2kAHdrsk2oIFj4Cj7uA7+fBbJcXoZUVCUA3Q7aaoqEqaJY+EswZnsYOml7VjUK3m9toaqE3A5PSNXnpOGZHoZr9CEqUFnqycsKHryA2RK8/vFzAdr5DFIvz+FCdl7eKc2dxdnx6R++2HFWq1lERXTK3I6yGV/tHkJeaEji2DWi9sFlsbwfy6u0o+8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d150ff0-d7ae-4aec-74a4-08d7676552e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2019 11:41:57.5914 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nPGVo3qqfiNj6MPxO+osu9NAvMzDTAhmc/UwWEXauIMIYyaRpWbkpOZrzal9rox7sOaWakZCe8/9lk7jVsXUnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4076 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter attributes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 12, 2019 10:54 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix query host adapter attributes >=20 > Host adapter attributes are queried from kernel via multiple > DevX calls. The retrieved data were erroneously overwritten, > the order of querying is fixed. >=20 > Fixes: e470ec789d4d ("net/mlx5: fill meter capabilities using DevX") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_devx_cmds.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_devx_cmds.c > b/drivers/net/mlx5/mlx5_devx_cmds.c > index dcb7609..9893287 100644 > --- a/drivers/net/mlx5/mlx5_devx_cmds.c > +++ b/drivers/net/mlx5/mlx5_devx_cmds.c > @@ -335,6 +335,11 @@ struct mlx5_devx_obj * > attr->log_max_hairpin_num_packets =3D MLX5_GET > (cmd_hca_cap, hcattr, log_min_hairpin_wq_data_sz); > attr->vhca_id =3D MLX5_GET(cmd_hca_cap, hcattr, vhca_id); > + attr->eth_net_offloads =3D MLX5_GET(cmd_hca_cap, hcattr, > + eth_net_offloads); > + attr->eth_virt =3D MLX5_GET(cmd_hca_cap, hcattr, eth_virt); > + attr->flex_parser_protocols =3D MLX5_GET(cmd_hca_cap, hcattr, > + flex_parser_protocols); > attr->qos.sup =3D MLX5_GET(cmd_hca_cap, hcattr, qos); > if (attr->qos.sup) { > MLX5_SET(query_hca_cap_in, in, op_mod, > @@ -358,11 +363,6 @@ struct mlx5_devx_obj * > attr->qos.flow_meter_reg_c_ids =3D > MLX5_GET(qos_cap, hcattr, flow_meter_reg_id); > } > - attr->eth_net_offloads =3D MLX5_GET(cmd_hca_cap, hcattr, > - eth_net_offloads); > - attr->eth_virt =3D MLX5_GET(cmd_hca_cap, hcattr, eth_virt); > - attr->flex_parser_protocols =3D MLX5_GET(cmd_hca_cap, hcattr, > - flex_parser_protocols); > if (!attr->eth_net_offloads) > return 0; >=20 > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh