DPDK patches and discussions
 help / color / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: "xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant	assignment
Date: Sun, 15 Dec 2019 08:55:19 +0000
Message-ID: <DB3PR0502MB3964F1A51AC21DFC5602922CC2560@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1574864323-85580-2-git-send-email-xiangxia.m.yue@gmail.com>

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> xiangxia.m.yue@gmail.com
> Sent: Wednesday, November 27, 2019 4:19 PM
> To: dev@dpdk.org
> Cc: Tonghao Zhang <xiangxia.m.yue@gmail.com>; Ori Kam
> <orika@mellanox.com>
> Subject: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant
> assignment
> 
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> The type of txq has been assigned in mlx5_txq_hairpin_new.
> 
> Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues")
> Cc: Ori Kam <orika@mellanox.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index a0d61644cb7f..e6a841c8d359 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -271,7 +271,6 @@ mlx5_tx_hairpin_queue_setup(struct rte_eth_dev
> *dev, uint16_t idx,
>  	DRV_LOG(DEBUG, "port %u adding Tx queue %u to list",
>  		dev->data->port_id, idx);
>  	(*priv->txqs)[idx] = &txq_ctrl->txq;
> -	txq_ctrl->type = MLX5_TXQ_TYPE_HAIRPIN;
>  	return 0;
>  }
> 
> --
> 2.23.0

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 14:18 [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues xiangxia.m.yue
2019-11-27 14:18 ` [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment xiangxia.m.yue
2019-11-27 14:51   ` Ori Kam
2019-12-15  8:55   ` Raslan Darawsheh [this message]
2019-11-27 14:18 ` [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq xiangxia.m.yue
2019-11-27 14:52   ` Ori Kam
2019-11-28  1:18     ` Tonghao Zhang
2019-11-27 14:50 ` [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues Ori Kam
2019-12-15  8:54 ` Raslan Darawsheh
2019-12-15  9:02   ` Raslan Darawsheh

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0502MB3964F1A51AC21DFC5602922CC2560@DB3PR0502MB3964.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=orika@mellanox.com \
    --cc=xiangxia.m.yue@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox