From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0077.outbound.protection.outlook.com [157.55.234.77]) by dpdk.org (Postfix) with ESMTP id 3F63D2C72 for ; Tue, 9 Feb 2016 19:37:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ezchip.onmicrosoft.com; s=selector1-ezchip-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fxr/qNUqXAlo2F3Zwprl8J86F2V3bPnovbxmaea+eGE=; b=USjIpW4BsXxEqQe5ktKFDjJW0SEDxDXndAc0UtuLy5g+gXTTjxhl4cxo9P0JkoaioUTlnAX1t0rIPPU6Y22kpQssDXTeTdQSinc+ZrhN9od4gp3viPN5fg4yGAwirLKRacM5EmVdXgOVmv4fdjr+fglzSKaWiqZat7kT3bN9vOI= Received: from DB5PR02MB1015.eurprd02.prod.outlook.com (10.162.162.21) by DB5PR02MB1014.eurprd02.prod.outlook.com (10.162.162.20) with Microsoft SMTP Server (TLS) id 15.1.403.16; Tue, 9 Feb 2016 18:37:42 +0000 Received: from DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) by DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) with mapi id 15.01.0403.017; Tue, 9 Feb 2016 18:37:41 +0000 From: Liming Sun To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. Thread-Index: AQHRY1Vn+a74pPFqfUCX5YGQVbZIXp8j5L8w Date: Tue, 9 Feb 2016 18:37:41 +0000 Message-ID: References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1452263438-21634-1-git-send-email-lsun@ezchip.com> <1642628.fgbdceb2p5@xps13> In-Reply-To: <1642628.fgbdceb2p5@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=ezchip.com; x-originating-ip: [12.216.194.146] x-microsoft-exchange-diagnostics: 1; DB5PR02MB1014; 5:v9WUaD0wIzM3ukwZSl2UlvE0aYPiyjkleC/go9HFk+xCq/Tx3nVEUsnb+udi7Xty7ln36w1Yk8K0AxZIPOwU+ssmRmCNbe63mVCEtoRFo2/nBs4ty9Jqg3WbZM/6AUsAUY1IeR+UU+Zp0wCYilzdDA==; 24:kTxpv+dh0SVx+FczaZ6A7/1ZGZ+Pfq0vIMYx2NnK8r+CljEoxUq6vgciKCEfoQAuT1wFO4uW+veLHcbuJMxRtvZB1hySqKBPlbvnna3nhYM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1014; x-ms-office365-filtering-correlation-id: eca62295-e4d8-47d7-8a69-08d331801817 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:DB5PR02MB1014; BCL:0; PCL:0; RULEID:; SRVR:DB5PR02MB1014; x-forefront-prvs: 08476BC6EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(164054003)(377424004)(3846002)(33656002)(86362001)(87936001)(92566002)(5002640100001)(106116001)(586003)(74316001)(102836003)(19580405001)(6116002)(76576001)(1220700001)(19580395003)(122556002)(1096002)(3660700001)(5004730100002)(3280700002)(2900100001)(15975445007)(2950100001)(4326007)(50986999)(66066001)(110136002)(5003600100002)(54356999)(2906002)(76176999)(5008740100001)(5001960100002)(77096005)(10400500002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR02MB1014; H:DB5PR02MB1015.eurprd02.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2016 18:37:41.7423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1014 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2016 18:37:43 -0000 Thanks Thomas for the comments. Please see the response inline. Thanks, Liming -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Tuesday, February 09, 2016 11:16 AM To: Liming Sun Cc: dev@dpdk.org; bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native bui= ld on tilegx platform. Hi, Sorry for being late for commenting. 2016-01-08 09:30, Liming Sun: > -EZchip TILE-Gx > +EZchip TILE-Gx/Mx A comment about the TILE-Mx would be welcome. Is it supported currently? Isn't it an ARM arch? [lsun] Yes, it's ARM arch, but with similar mpipe driver. It's not fully supported yet. I'll remove this change and add it in a diffe= rent serie when it's ready. > M: Zhigang Lu > +M: Liming Sun > F: lib/librte_eal/common/include/arch/tile/ > F: drivers/net/mpipe/ [...] > +# Compile combined lib by default. > +CONFIG_RTE_BUILD_COMBINE_LIBS=3Dy Why forcing this option in the defconfig file? [lsun] It's just trying to make it handy for other applications like OVS or= ODP on top of DPDK. However we could remove this change if it's not the re= commended way. [...] > ARCH ?=3D tile > + > +HOST_ARCH :=3D ${shell uname -m} > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS =3D else > CROSS ?=3D tile- > +endif I don't think the CROSS variable should have a default value. It really depends on the toolchain. [lsun] Make sense. The current code (before the change) has default value '= CROSS ?=3D tile-' defined, which cause some issue when doing native build. = Another way is to define it as "CROSS ?=3D" just like other platforms. So w= hen doing cross-compile, we could pass " CROSS=3Dtile-" . Talking about the toolchain, is it possible to build DPDK with the provided= binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ? This is the Tilera Open Source page: http://www.tilera.com/scm/ [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of s= ome header files and libraries to compile DPDK. We're looking into it to see whether it can be easily fixed.